WebMCP: Remove the ModelContextTesting API [chromium/src : main]
0 views
Skip to first unread message
Dominic Farolino (Gerrit)
Jul 7, 2026, 8:11:32 PM (11 hours ago) Jul 7
to Fr, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Khushal Sagar, Raphael Kubo da Costa, alexmo...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
Attention needed from Fr and Nasko Oskov
Dominic Farolino voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominic Farolino
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Dominic Farolino . resolved
Hey François and Nasko! This is a reland of https://crrev.com/c/7895790. The only change between this and the original CL is a test timeout modification, described in the commit description. So this should be good to go!
Related details
Attention is currently required from:
- Fr
- Nasko Oskov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nasko Oskov (Gerrit)
1:53 AM (5 hours ago) 1:53 AM
to Dominic Farolino, Chromium LUCI CQ, Fr, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Khushal Sagar, Raphael Kubo da Costa, alexmo...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
Attention needed from Dominic Farolino and Fr
Nasko Oskov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nasko Oskov
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Dominic Farolino
- Fr
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
2:05 AM (5 hours ago) 2:05 AM
to Dominic Farolino, Chromium LUCI CQ, Fr, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Khushal Sagar, Raphael Kubo da Costa, alexmo...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
Attention needed from Dominic Farolino and Fr
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/61137.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Dominic Farolino
- Fr
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fr (Gerrit)
2:54 AM (4 hours ago) 2:54 AM
to Dominic Farolino, Blink W3C Test Autoroller, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Khushal Sagar, Raphael Kubo da Costa, alexmo...@chromium.org, android-web...@chromium.org, ashleynewson+watch-...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org
Attention needed from Dominic Farolino
Fr added 6 comments![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/webmcp/declarative/form_removal_submit_crash.https.html
Line 40, Patchset 2 (Latest):
await promise_rejects_dom(t, "UnknownError", promise,Fr . unresolved
Why did you add `await`?
File third_party/blink/web_tests/external/wpt/webmcp/imperative/executeTool-invalid-dictionary.https.html
Line 40, Patchset 2 (Latest):
document.modelContext.registerTool({Fr . unresolved
I believe we should have `await`.
File third_party/blink/web_tests/external/wpt/webmcp/resources/helpers.js
Line 4, Patchset 2 (Latest):
let tool = tools.find(t => t.name === name);Fr . unresolved
Nit: s/let/const/
Line 11, Patchset 2 (Latest):
let tool = tools.find(t => t.name === name);Fr . unresolved
Nit: s/let/const/
File third_party/blink/web_tests/fast/webmcp/list_tools.html
Line 90, Patchset 2 (Parent):
} else if (echoTool.inputSchema !== expectedSchema) {Fr . unresolved
Do we have tests that cover expected input schemas from getTools()?
File tools/metrics/histograms/enums.xml
Line 10719, Patchset 2 (Latest):
<int value="-1237255399" label="WebMCP:enabled"/>Fr . unresolved
Should you also remove "WebMCPTesting" enums?
Related details
Attention is currently required from:
- Dominic Farolino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages