extensions: Fix crash on drilldown navigation [chromium/src : main]
0 views
Skip to first unread message
Masa Fujita (Gerrit)
Jul 10, 2026, 11:41:43 AM (yesterday) Jul 10
to chromium...@chromium.org, yusufo...@chromium.org, gogeral...@chromium.org, yuezhang...@chromium.org, browser-comp...@chromium.org, meilian...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, android-web...@chromium.org, davidj...@chromium.org, wychen...@chromium.org
Masa Fujita has uploaded the change for review![]( "Open in Gerrit")
Commit message
extensions: Fix crash on drilldown navigation
This CL fixes a crash that happens when using drilldown navigation for
extension injected menus. We were using an empty PropertyModel to create
the dividers. ModelListAdapter tries to recycle views, so we should
ensure that all dividers use the same set of keys
(ListSectionDividerProperties.ALL_KEYS). We can achieve this by using
the proper divider builder.
Bug: 433410990
Change-Id: I82ce225d09d0da7f21d6b02ad674f83f9612cb24
Change diff
Change information
Files:
- M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinator.java
- M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuMediator.java
- M chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ContextMenuMediatorTest.java
Change size: S
Delta: 3 files changed, 13 insertions(+), 3 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Masa Fujita (Gerrit)
Jul 10, 2026, 11:41:57 AM (yesterday) Jul 10
to chromium...@chromium.org, android-web...@chromium.org, browser-comp...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Masa Fujita voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Masa Fujita (Gerrit)
7:37 AM (7 hours ago) 7:37 AM
to Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, browser-comp...@chromium.org, davidj...@chromium.org, gogeral...@chromium.org, hanxi...@chromium.org, mattsimm...@chromium.org, meilian...@chromium.org, wychen...@chromium.org, yuezhang...@chromium.org, yusufo...@chromium.org
Masa Fujita voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages