Rewrite FocusModeController around FocusModeTasksModel [chromium/src : main]
0 views
Skip to first unread message
Sean Kau (Gerrit)
Jul 1, 2024, 9:34:49 PM (yesterday) Jul 1
to Richard Chui, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org
Attention needed from Richard Chui
Sean Kau added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Richard Chui
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Richard Chui (Gerrit)
6:34 PM (5 hours ago) 6:34 PM
to Sean Kau, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org
Attention needed from Sean Kau
Richard Chui voted and added 3 comments![]( "Open in Gerrit")
Votes added by Richard Chui
| Code-Review | +1 |
3 comments
Patchset-level comments
File ash/system/focus_mode/focus_mode_controller.cc
Line 497, Patchset 8 (Latest):
return !!tasks_model_.selected_task();Richard Chui . unresolved
do we need this?
Line 696, Patchset 8 (Latest):
// If there is a selected task, we will save its `task_list_id` and
// `task_id`; otherwise, we will store an empty dict.Richard Chui . unresolved
```suggestion
// If there is a selected task, we will save its `task_id.list_id` and
// `task_id.id`; otherwise, we will store an empty dict.
```
Related details
Attention is currently required from:
- Sean Kau
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Kau (Gerrit)
8:46 PM (3 hours ago) 8:46 PM
to Toni Barzic, Richard Chui, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org
Attention needed from Toni Barzic
Sean Kau voted and added 3 comments![]( "Open in Gerrit")
Votes added by Sean Kau
| Commit-Queue | +1 |
3 comments
Patchset-level comments
File-level comment, Patchset 9 (Latest):
Sean Kau . resolved
tbarzic@ would you mind reviewing the change to the tasks API?
File ash/system/focus_mode/focus_mode_controller.cc
Line 497, Patchset 8:
return !!tasks_model_.selected_task();Richard Chui . resolved
Sean Kaudo we need this?
It's somewhat conventional for pointers so you don't accidentally invoke the `()` operator. Strictly speaking, it's not necessary here.
Line 696, Patchset 8:
// If there is a selected task, we will save its `task_list_id` and
// `task_id`; otherwise, we will store an empty dict.Richard Chui . resolved
```suggestion
// If there is a selected task, we will save its `task_id.list_id` and
// `task_id.id`; otherwise, we will store an empty dict.
```
Attention is currently required from:
- Toni Barzic
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Kau (Gerrit)
8:55 PM (3 hours ago) 8:55 PM
to Toni Barzic, Richard Chui, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blundell+...@chromium.org
Attention needed from Toni Barzic
Sean Kau voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Toni Barzic
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages