Migrate ChromeDownloadManagerDelegate off CanSupportWindowFeature [chromium/src : main]
0 views
Skip to first unread message
Antonio Gomes Netto (Gerrit)
Jul 8, 2026, 5:28:57 PM (11 hours ago) Jul 8
to Antonio Gomes Netto, chromium-bedrock-reviews, chromium...@chromium.org, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, dtraino...@chromium.org
Attention needed from chromium-bedrock-reviews
Antonio Gomes Netto added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- chromium-bedrock-reviews
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Jul 8, 2026, 5:32:29 PM (11 hours ago) Jul 8
to Antonio Gomes Netto, chromium-bedrock-reviews, Thomas Lukaszewicz, chromium...@chromium.org, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, dtraino...@chromium.org
Attention needed from Thomas Lukaszewicz
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
tl...@chromium.org is from context(googleclient/chrome/chromium_gwsq/chrome/browser/config.gwsq)
Related details
Attention is currently required from:
- Thomas Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Lukaszewicz (Gerrit)
Jul 8, 2026, 6:37:19 PM (10 hours ago) Jul 8
to Antonio Gomes Netto, chromium-bedrock-reviews, chromium...@chromium.org, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, dtraino...@chromium.org
Attention needed from Antonio Gomes Netto
Thomas Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Lukaszewicz
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Antonio Gomes Netto
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Gomes Netto (Gerrit)
1:19 AM (3 hours ago) 1:19 AM
to Antonio Gomes Netto, Thomas Lukaszewicz, chromium-bedrock-reviews, chromium...@chromium.org, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, dtraino...@chromium.org
Antonio Gomes Netto voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:31 AM (3 hours ago) 1:31 AM
to Antonio Gomes Netto, Thomas Lukaszewicz, chromium-bedrock-reviews, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, dtraino...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Migrate ChromeDownloadManagerDelegate off CanSupportWindowFeature
OpenDownloadUsingPlatformHandler used
ScopedTabbedBrowserDisplayer::browser() only to call the deprecated
Browser::CanSupportWindowFeature() (the other uses, ShowSettingsSubPage
and OpenURL, already take a BrowserWindowInterface). Browser's method
just forwards to WindowFeatureController::From(this), and
WindowFeatureController::From() takes a BrowserWindowInterface, so call
it directly on browser_window_interface() instead.
This removes the last concrete-Browser use in the file, so drop the
chrome/browser/ui/browser.h include (adding window_feature_controller.h
and its GN dep).
R=chromium-bed...@google.com
Bug: 353332589
Change-Id: I55d70bc85a8b6e56ab36ec79decbd337f9302ae4
Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
Commit-Queue: Antonio Gomes Netto <toni...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1659322}
Files:
- M chrome/browser/download/BUILD.gn
- M chrome/browser/download/chrome_download_manager_delegate.cc
Change size: S
Delta: 2 files changed, 7 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Lukaszewicz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages