Only download Gemini Threads for a Gemini Eligible user [chromium/src : refs/branch-heads/7727]
0 views
Skip to first unread message
David Maunder (Gerrit)
Mar 21, 2026, 9:54:38 AM (2 days ago) Mar 21
to AyeAye, chromium...@chromium.org, Sophie Chang
Message from David Maunder![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Maunder (Gerrit)
9:39 AM (8 hours ago) 9:39 AM
to Matthew Jones, Ankush Singh, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Attention needed from Ankush Singh and Matthew Jones
David Maunder added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
David Maunder . resolved
Ankush ptal /*sync*/
Matt ptal /*contextual_tasks*/
Related details
Attention is currently required from:
- Ankush Singh
- Matthew Jones
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ankush Singh (Gerrit)
9:44 AM (8 hours ago) 9:44 AM
to David Maunder, Matthew Jones, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Attention needed from David Maunder and Matthew Jones
Ankush Singh voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ankush Singh
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- David Maunder
- Matthew Jones
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthew Jones (Gerrit)
9:56 AM (8 hours ago) 9:56 AM
to David Maunder, Ankush Singh, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
Attention needed from David Maunder
Matthew Jones voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- David Maunder
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Maunder (Gerrit)
10:11 AM (8 hours ago) 10:11 AM
to Matthew Jones, Ankush Singh, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang
David Maunder voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:20 PM (6 hours ago) 12:20 PM
to David Maunder, Matthew Jones, Ankush Singh, AyeAye, chromium...@chromium.org, Sophie Chang
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M147] Only download Gemini Threads for a Gemini Eligible user
This CL integrates the Gemini Thread integration with
GlicKeyedServiceFactory and only downloads threads for a user
profile which is Gemini thread eligible. If it isn't Gemini eligible
downloads are paused and existing threads are retained.
(cherry picked from commit f59936359c9ed7a51a9d1c4ebb50764df3cf5f99)
Bug: 493324697
Fixed: 494823185
Change-Id: I6884215f8a9abe3ef439fc948168b843d74c1719
Reviewed-by: Ankush Singh <ankus...@google.com>
Reviewed-by: Matthew Jones <mdj...@chromium.org>
Commit-Queue: David Maunder <dav...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1602392}
Cr-Commit-Position: refs/branch-heads/7727@{#1247}
Cr-Branched-From: ce01102937348db7b88c8a4257ee4b3ac702eb1a-refs/heads/main@{#1596535}
Files:
- M chrome/browser/contextual_tasks/BUILD.gn
- M chrome/browser/contextual_tasks/contextual_tasks_service_factory.cc
- M components/browser_sync/common_controller_builder.cc
- M components/contextual_tasks/internal/contextual_tasks_service_impl.cc
- M components/contextual_tasks/internal/contextual_tasks_service_impl.h
- M components/contextual_tasks/internal/contextual_tasks_service_impl_unittest.cc
- M components/contextual_tasks/public/BUILD.gn
- M components/contextual_tasks/public/contextual_tasks_service.h
- A components/contextual_tasks/public/gemini_thread_data_type_controller.cc
- A components/contextual_tasks/public/gemini_thread_data_type_controller.h
- A components/contextual_tasks/public/gemini_thread_data_type_controller_unittest.cc
- M components/contextual_tasks/public/mock_contextual_tasks_service.h
Change size: M
Delta: 12 files changed, 197 insertions(+), 13 deletions(-)
Branch: refs/branch-heads/7727
Submit Requirements:
Code-Review: +1 by Ankush Singh, +1 by Matthew Jones
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages