[vpython] Add best-effort update_wheel.py helper script [infra/infra : main]
Camillo Bruni (Gerrit)
Camillo Bruni added 1 comment![]( "Open in Gerrit")
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ovsienko (Gerrit)
Alex Ovsienko added 1 comment![]( "Open in Gerrit")
May I have some context why we need this? That's quite a big change to approve with no context of what this is and why do we need it.
Related details
- Camillo Bruni
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ovsienko (Gerrit)
Alex Ovsienko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Ovsienko
| Code-Review | -1 |
1 comment
If I read this correctly, this works is superseded by my work with UV, I'm sorry to inform you of that. Please check go/vpython-to-uv-greendoc and see if I got it right.
Related details
- Camillo Bruni
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
Camillo Bruni added 1 comment![]( "Open in Gerrit")
If I read this correctly, this works is superseded by my work with UV, I'm sorry to inform you of that. Please check go/vpython-to-uv-greendoc and see if I got it right.
I think not... this is just to use a helper script to get a pytohn package + it's deps names and add them to the current vpython wheels.
It does not change the package manager and is orthogonal to your proposal.
Please consider landing this to speed up maintenance fo vpython packages until we have proper replacement.
What is the timeline on the uv proposal? If we're talking about weeks, then I tihnk holding back makes sense. Otherwise my heper script would be a very nice additional that we can rip out once the uv-approach is shipped.
Related details
- Alex Ovsienko
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ovsienko (Gerrit)
Alex Ovsienko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Ovsienko
| Code-Review | +0 |
Camillo BruniIf I read this correctly, this works is superseded by my work with UV, I'm sorry to inform you of that. Please check go/vpython-to-uv-greendoc and see if I got it right.
I think not... this is just to use a helper script to get a pytohn package + it's deps names and add them to the current vpython wheels.
It does not change the package manager and is orthogonal to your proposal.
Please consider landing this to speed up maintenance fo vpython packages until we have proper replacement.What is the timeline on the uv proposal? If we're talking about weeks, then I tihnk holding back makes sense. Otherwise my heper script would be a very nice additional that we can rip out once the uv-approach is shipped.
Right, I think I got your point. Got no objections for this CL, however we can't fetch versions from pypi directly as you may have noticed. You will need to redirect this to airlock and use the luci credentials, see how it's done in dockerbuild/util.py. Here is AI generated flow:
1. Source Registry Endpoints
In util.py, dockerbuild configures the upstream package indices pointing to the internal Artifact Registry:
python
PACKAGE_INDEX_URLS = [
'https://us-python.pkg.dev/artifact-foundry-prod/python-3p-trusted/simple/',
'https://us-python.pkg.dev/artifact-foundry-prod/ah-3p-staging-python/simple/',
]
2. Authentication & Resolution Flow
When building wheels (defined in source.py), the fetch process works as follows:
2.1. Authentication: dockerbuild calls luci-auth to generate an OAuth2 access token with Cloud Platform scopes.
2.2. Simple API Query (PEP 503): It makes authenticated HTTP GET requests to the standard Simple API endpoint for the normalized package name:
https://us-python.pkg.dev/.../simple/<package-name>/
2.3. HTML Parsing: It parses the returned HTML page to find the source distribution (e.g., .tar.gz or .zip) matching the requested version and expected hash.
2.4. Download: Once the target link is identified, the archive is downloaded and securely verified against its SHA256 hash.
Related details
- Camillo Bruni
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Ovsienko (Gerrit)
Alex Ovsienko added 1 comment![]( "Open in Gerrit")
Please sync to head, your cl should pass presbumit now.
Related details
- Camillo Bruni
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |