cros/recovery: Update DUT visibility checks for Maui (Config Changes) [infra/infra : main]

0 views
Skip to first unread message

Otabek Kasimov (Gerrit)

unread,
Jul 6, 2026, 4:58:39 PM (2 days ago) Jul 6
to chromium...@chromium.org, infra-rev...@chromium.org

Otabek Kasimov has uploaded the change for review

Commit message

cros/recovery: Update DUT visibility checks for Maui (Config Changes)

Update "Wait to be pingable" actions to use cros_dut_is_visible exec.
Keep "Android:Device is pingable" and "Device is pingable" using cros_ping (with skip condition for Maui on Android one).

BUG=b:514817209
TEST=make trees, go test ./...
TAG=agy
CONV=e33a1a21-b4ff-4ec9-93fb-36bcaabf90ad
Change-Id: Id839e12036bdaf0a628acf02108f494d4724dd16

Change diff


Change information

Files:
  • M go/src/infra/cros/recovery/config/config_cros_repair.go
  • M go/src/infra/cros/recovery/config_trees/browser_cros_audit_storage.yaml
  • M go/src/infra/cros/recovery/config_trees/browser_cros_audit_storage_short.yaml
  • M go/src/infra/cros/recovery/config_trees/browser_deploy.yaml
  • M go/src/infra/cros/recovery/config_trees/browser_deploy_short.yaml
  • M go/src/infra/cros/recovery/config_trees/browser_repair.yaml
  • M go/src/infra/cros/recovery/config_trees/browser_repair_short.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_android_deep_repair.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_android_deep_repair_short.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_android_deploy.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_android_deploy_short.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_android_repair.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_android_repair_short.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_audit_storage.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_audit_storage_short.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_deep_repair.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_deep_repair_short.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_deploy.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_deploy_short.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_repair.yaml
  • M go/src/infra/cros/recovery/config_trees/cros_repair_short.yaml
  • M go/src/infra/cros/recovery/config_trees/labqual.yaml
  • M go/src/infra/cros/recovery/config_trees/labqual_canary.yaml
  • M go/src/infra/cros/recovery/config_trees/labqual_canary_short.yaml
  • M go/src/infra/cros/recovery/config_trees/labqual_short.yaml
Change size: XL
Delta: 25 files changed, 3746 insertions(+), 3746 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: Id839e12036bdaf0a628acf02108f494d4724dd16
Gerrit-Change-Number: 8046854
Gerrit-PatchSet: 1
Gerrit-Owner: Otabek Kasimov <ota...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Otabek Kasimov (Gerrit)

unread,
Jul 6, 2026, 5:09:53 PM (2 days ago) Jul 6
to Chrome Fleet Automation Reviewers, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Chrome Fleet Automation Reviewers

Otabek Kasimov voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chrome Fleet Automation Reviewers
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: Id839e12036bdaf0a628acf02108f494d4724dd16
Gerrit-Change-Number: 8046854
Gerrit-PatchSet: 1
Gerrit-Owner: Otabek Kasimov <ota...@google.com>
Gerrit-Reviewer: Chrome Fleet Automation Reviewers <chrome-fleet-in...@google.com>
Gerrit-Reviewer: Otabek Kasimov <ota...@google.com>
Gerrit-Attention: Chrome Fleet Automation Reviewers <chrome-fleet-in...@google.com>
Gerrit-Comment-Date: Mon, 06 Jul 2026 21:09:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jul 6, 2026, 5:13:25 PM (2 days ago) Jul 6
to Otabek Kasimov, Chrome Fleet Automation Reviewers, Tiffany Zhang, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Tiffany Zhang

Message from gwsq

Reviewer source(s):
zhangtiff is from group(chrome-fleet-in...@google.com)

Open in Gerrit

Related details

Attention is currently required from:
  • Tiffany Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: Id839e12036bdaf0a628acf02108f494d4724dd16
Gerrit-Change-Number: 8046854
Gerrit-PatchSet: 1
Gerrit-Owner: Otabek Kasimov <ota...@google.com>
Gerrit-Reviewer: Otabek Kasimov <ota...@google.com>
Gerrit-Reviewer: Tiffany Zhang <zhan...@chromium.org>
Gerrit-CC: Chrome Fleet Automation Reviewers <chrome-fleet-in...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Tiffany Zhang <zhan...@chromium.org>
Gerrit-Comment-Date: Mon, 06 Jul 2026 21:13:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tiffany Zhang (Gerrit)

unread,
Jul 6, 2026, 5:21:02 PM (2 days ago) Jul 6
to Otabek Kasimov, Chrome Fleet Automation Reviewers, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Otabek Kasimov

Tiffany Zhang voted and added 1 comment

Votes added by Tiffany Zhang

Code-Review+1

1 comment

File go/src/infra/cros/recovery/config/config_cros_repair.go
Line 2807, Patchset 1 (Latest): ExecName: "cros_dut_is_visible",
Tiffany Zhang . unresolved

Since the executor has been updated to `cros_dut_is_visible`, consider updating the `Docs` string (and potentially renaming the action in a future cleanup) from "pingable" to "visible" to avoid confusion.

Open in Gerrit

Related details

Attention is currently required from:
  • Otabek Kasimov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: Id839e12036bdaf0a628acf02108f494d4724dd16
Gerrit-Change-Number: 8046854
Gerrit-PatchSet: 1
Gerrit-Owner: Otabek Kasimov <ota...@google.com>
Gerrit-Reviewer: Otabek Kasimov <ota...@google.com>
Gerrit-Reviewer: Tiffany Zhang <zhan...@chromium.org>
Gerrit-CC: Chrome Fleet Automation Reviewers <chrome-fleet-in...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Otabek Kasimov <ota...@google.com>
Gerrit-Comment-Date: Mon, 06 Jul 2026 21:20:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Otabek Kasimov (Gerrit)

unread,
Jul 6, 2026, 5:59:42 PM (2 days ago) Jul 6
to Tiffany Zhang, Chrome Fleet Automation Reviewers, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Tiffany Zhang

Otabek Kasimov voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tiffany Zhang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/infra
Gerrit-Branch: main
Gerrit-Change-Id: Id839e12036bdaf0a628acf02108f494d4724dd16
Gerrit-Change-Number: 8046854
Gerrit-PatchSet: 2
Gerrit-Owner: Otabek Kasimov <ota...@google.com>
Gerrit-Reviewer: Otabek Kasimov <ota...@google.com>
Gerrit-Reviewer: Tiffany Zhang <zhan...@chromium.org>
Gerrit-CC: Chrome Fleet Automation Reviewers <chrome-fleet-in...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Tiffany Zhang <zhan...@chromium.org>
Gerrit-Comment-Date: Mon, 06 Jul 2026 21:59:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Otabek Kasimov (Gerrit)

unread,
Jul 6, 2026, 6:00:03 PM (2 days ago) Jul 6
to Tiffany Zhang, Chrome Fleet Automation Reviewers, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
Attention needed from Tiffany Zhang

Otabek Kasimov added 1 comment

File go/src/infra/cros/recovery/config/config_cros_repair.go
Line 2807, Patchset 1: ExecName: "cros_dut_is_visible",
Tiffany Zhang . resolved

Since the executor has been updated to `cros_dut_is_visible`, consider updating the `Docs` string (and potentially renaming the action in a future cleanup) from "pingable" to "visible" to avoid confusion.

Otabek Kasimov

you are right. Done

Open in Gerrit

Related details

Attention is currently required from:
  • Tiffany Zhang
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: infra/infra
    Gerrit-Branch: main
    Gerrit-Change-Id: Id839e12036bdaf0a628acf02108f494d4724dd16
    Gerrit-Change-Number: 8046854
    Gerrit-PatchSet: 2
    Gerrit-Owner: Otabek Kasimov <ota...@google.com>
    Gerrit-Reviewer: Otabek Kasimov <ota...@google.com>
    Gerrit-Reviewer: Tiffany Zhang <zhan...@chromium.org>
    Gerrit-CC: Chrome Fleet Automation Reviewers <chrome-fleet-in...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Tiffany Zhang <zhan...@chromium.org>
    Gerrit-Comment-Date: Mon, 06 Jul 2026 22:00:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Tiffany Zhang <zhan...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Otabek Kasimov (Gerrit)

    unread,
    Jul 6, 2026, 8:05:44 PM (2 days ago) Jul 6
    to Jordan Sihno Mbeleg, Tiffany Zhang, Chrome Fleet Automation Reviewers, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
    Attention needed from Jordan Sihno Mbeleg and Tiffany Zhang

    Otabek Kasimov voted

    Auto-Submit+1
    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jordan Sihno Mbeleg
    • Tiffany Zhang
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: infra/infra
    Gerrit-Branch: main
    Gerrit-Change-Id: Id839e12036bdaf0a628acf02108f494d4724dd16
    Gerrit-Change-Number: 8046854
    Gerrit-PatchSet: 4
    Gerrit-Owner: Otabek Kasimov <ota...@google.com>
    Gerrit-Reviewer: Jordan Sihno Mbeleg <jordan...@google.com>
    Gerrit-Reviewer: Otabek Kasimov <ota...@google.com>
    Gerrit-Reviewer: Tiffany Zhang <zhan...@chromium.org>
    Gerrit-CC: Chrome Fleet Automation Reviewers <chrome-fleet-in...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Jordan Sihno Mbeleg <jordan...@google.com>
    Gerrit-Attention: Tiffany Zhang <zhan...@chromium.org>
    Gerrit-Comment-Date: Tue, 07 Jul 2026 00:05:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yang Yang (Gerrit)

    unread,
    4:01 PM (2 hours ago) 4:01 PM
    to Otabek Kasimov, Jordan Sihno Mbeleg, Tiffany Zhang, Chrome Fleet Automation Reviewers, LUCI CQ, chromium...@chromium.org, infra-rev...@chromium.org
    Attention needed from Jordan Sihno Mbeleg, Otabek Kasimov and Tiffany Zhang

    Yang Yang voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jordan Sihno Mbeleg
    • Otabek Kasimov
    • Tiffany Zhang
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: infra/infra
    Gerrit-Branch: main
    Gerrit-Change-Id: Id839e12036bdaf0a628acf02108f494d4724dd16
    Gerrit-Change-Number: 8046854
    Gerrit-PatchSet: 6
    Gerrit-Owner: Otabek Kasimov <ota...@google.com>
    Gerrit-Reviewer: Jordan Sihno Mbeleg <jordan...@google.com>
    Gerrit-Reviewer: Otabek Kasimov <ota...@google.com>
    Gerrit-Reviewer: Tiffany Zhang <zhan...@chromium.org>
    Gerrit-Reviewer: Yang Yang <echo...@chromium.org>
    Gerrit-CC: Chrome Fleet Automation Reviewers <chrome-fleet-in...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Jordan Sihno Mbeleg <jordan...@google.com>
    Gerrit-Attention: Otabek Kasimov <ota...@google.com>
    Gerrit-Attention: Tiffany Zhang <zhan...@chromium.org>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 20:01:24 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    LUCI CQ (Gerrit)

    unread,
    4:04 PM (2 hours ago) 4:04 PM
    to Otabek Kasimov, Yang Yang, Jordan Sihno Mbeleg, Tiffany Zhang, Chrome Fleet Automation Reviewers, chromium...@chromium.org, infra-rev...@chromium.org

    LUCI CQ submitted the change

    Change information

    Commit message:
    cros/recovery: Update DUT visibility checks for Maui (Config Changes)

    Update "Wait to be pingable" actions to use cros_dut_is_visible exec.
    Keep "Android:Device is pingable" and "Device is pingable" using cros_ping (with skip condition for Maui on Android one).

    BUG=b:514817209
    TEST=make trees, go test ./...
    TAG=agy
    CONV=e33a1a21-b4ff-4ec9-93fb-36bcaabf90ad
    Change-Id: Id839e12036bdaf0a628acf02108f494d4724dd16
    Commit-Queue: Yang Yang <echo...@chromium.org>
    Auto-Submit: Otabek Kasimov <ota...@google.com>
    Reviewed-by: Yang Yang <echo...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81716}
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Yang Yang
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: infra/infra
    Gerrit-Branch: main
    Gerrit-Change-Id: Id839e12036bdaf0a628acf02108f494d4724dd16
    Gerrit-Change-Number: 8046854
    Gerrit-PatchSet: 7
    Gerrit-Owner: Otabek Kasimov <ota...@google.com>
    Gerrit-Reviewer: Jordan Sihno Mbeleg <jordan...@google.com>
    Gerrit-Reviewer: Otabek Kasimov <ota...@google.com>
    Gerrit-Reviewer: Tiffany Zhang <zhan...@chromium.org>
    Gerrit-Reviewer: Yang Yang <echo...@chromium.org>
    Gerrit-CC: Chrome Fleet Automation Reviewers <chrome-fleet-in...@google.com>
    Gerrit-CC: gwsq
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages