PA: Move AMSC off of `AllocInline()` [chromium/src : main]
0 views
Skip to first unread message
Kalvin Lee (Gerrit)
Jul 7, 2026, 3:22:03 AM (3 days ago) Jul 7
to Greg Thompson, Chromium LUCI CQ, chromium...@chromium.org, gavinp...@chromium.org
Attention needed from Greg Thompson
Kalvin Lee added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kalvin Lee . resolved
Ignoring the CrOS bot (infra failure) -> accept Gerrit-surfaced reviewer -> Greg to review, please.
Related details
Attention is currently required from:
- Greg Thompson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Greg Thompson (Gerrit)
Jul 7, 2026, 7:15:38 AM (3 days ago) Jul 7
to Kalvin Lee, Benoit Lize, Chromium LUCI CQ, chromium...@chromium.org, gavinp...@chromium.org
Attention needed from Benoit Lize and Kalvin Lee
Greg Thompson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Greg Thompson . resolved
I think a PA owner is more suited to this. @li...@chromium.org: Does this LGTY?
Related details
Attention is currently required from:
- Benoit Lize
- Kalvin Lee
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benoit Lize (Gerrit)
Jul 7, 2026, 8:48:15 AM (3 days ago) Jul 7
to Kalvin Lee, Greg Thompson, Chromium LUCI CQ, chromium...@chromium.org, gavinp...@chromium.org
Attention needed from Kalvin Lee
Benoit Lize voted and added 1 comment![]( "Open in Gerrit")
Votes added by Benoit Lize
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Kalvin Lee
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Greg Thompson (Gerrit)
Jul 7, 2026, 9:00:01 AM (3 days ago) Jul 7
to Kalvin Lee, Benoit Lize, Chromium LUCI CQ, chromium...@chromium.org, gavinp...@chromium.org
Attention needed from Kalvin Lee
Greg Thompson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Kalvin Lee
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:36 AM (5 hours ago) 5:36 AM
to Kalvin Lee, Greg Thompson, Benoit Lize, chromium...@chromium.org, gavinp...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
PA: Move AMSC off of `AllocInline()`
`AllocInline()` is being removed from PA's public interface.
Bug: 531793723
Change-Id: Ibf4b882ba4f9b5a03e8eb03ee62894d7e542b404
Reviewed-by: Greg Thompson <g...@chromium.org>
Commit-Queue: Kalvin Lee <kd...@chromium.org>
Reviewed-by: Benoit Lize <li...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1660143}
Files:
- M base/memory/advanced_memory_safety_checks.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Benoit Lize, +1 by Greg Thompson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages