a11y-common: Use MV3 `accessibilityPrivate` type defs [chromium/src : main]

0 views
Skip to first unread message

Xiyuan Xia (Gerrit)

unread,
Jun 30, 2025, 4:11:53 PMJun 30
to Akihiro Ota, David Tseng, Achuith Bhandarkar, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, anastas...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
Attention needed from Akihiro Ota

Xiyuan Xia voted and added 1 comment

Votes added by Xiyuan Xia

Commit-Queue+1

1 comment

File chrome/browser/resources/chromeos/accessibility/definitions/accessibility_private_mv3.d.ts
Line 13, Patchset 1 (Latest):import type {ChromeEvent} from '../../../../../../tools/typescript/definitions/chrome_event.js';
Xiyuan Xia . unresolved

The file is generated via `json_schema_compiler`. And this is the only change to update the path to `chorme_event.js`.

Open in Gerrit

Related details

Attention is currently required from:
  • Akihiro Ota
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If1c4d502758d541e523c636c15b42626d982d4ab
Gerrit-Change-Number: 6691078
Gerrit-PatchSet: 1
Gerrit-Owner: Xiyuan Xia <xiy...@chromium.org>
Gerrit-Reviewer: Akihiro Ota <akihi...@chromium.org>
Gerrit-Reviewer: Xiyuan Xia <xiy...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
Gerrit-CC: David Tseng <dts...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Attention: Akihiro Ota <akihi...@chromium.org>
Gerrit-Comment-Date: Mon, 30 Jun 2025 20:11:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Xiyuan Xia (Gerrit)

unread,
Jun 30, 2025, 4:49:59 PMJun 30
to Chromium LUCI CQ, Akihiro Ota, David Tseng, Achuith Bhandarkar, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, anastas...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
Attention needed from Akihiro Ota

Xiyuan Xia voted and added 1 comment

Votes added by Xiyuan Xia

Commit-Queue+1

1 comment

File chrome/browser/resources/chromeos/accessibility/accessibility_common/mv3/BUILD.gn
Line 106, Patchset 2 (Parent): "../../definitions/settings_private_mv2.d.ts",
Xiyuan Xia . unresolved

This is a dup of L103 above. Looks like an accidental copy/paste error.

Open in Gerrit

Related details

Attention is currently required from:
  • Akihiro Ota
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If1c4d502758d541e523c636c15b42626d982d4ab
Gerrit-Change-Number: 6691078
Gerrit-PatchSet: 2
Gerrit-Owner: Xiyuan Xia <xiy...@chromium.org>
Gerrit-Reviewer: Akihiro Ota <akihi...@chromium.org>
Gerrit-Reviewer: Xiyuan Xia <xiy...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
Gerrit-CC: David Tseng <dts...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Attention: Akihiro Ota <akihi...@chromium.org>
Gerrit-Comment-Date: Mon, 30 Jun 2025 20:49:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Akihiro Ota (Gerrit)

unread,
Jun 30, 2025, 5:07:36 PMJun 30
to Xiyuan Xia, Chromium LUCI CQ, David Tseng, Achuith Bhandarkar, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, anastas...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
Attention needed from Xiyuan Xia

Akihiro Ota voted and added 3 comments

Votes added by Akihiro Ota

Code-Review+1

3 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Akihiro Ota . resolved

Thanks for the cleanup!

File chrome/browser/resources/chromeos/accessibility/accessibility_common/mv3/BUILD.gn
Line 106, Patchset 2 (Parent): "../../definitions/settings_private_mv2.d.ts",
Xiyuan Xia . resolved

This is a dup of L103 above. Looks like an accidental copy/paste error.

Akihiro Ota

Thanks for removing this!

File chrome/browser/resources/chromeos/accessibility/definitions/accessibility_private_mv3.d.ts
Line 13, Patchset 1:import type {ChromeEvent} from '../../../../../../tools/typescript/definitions/chrome_event.js';
Xiyuan Xia . resolved

The file is generated via `json_schema_compiler`. And this is the only change to update the path to `chorme_event.js`.

Akihiro Ota

Acknowledged, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Xiyuan Xia
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If1c4d502758d541e523c636c15b42626d982d4ab
    Gerrit-Change-Number: 6691078
    Gerrit-PatchSet: 2
    Gerrit-Owner: Xiyuan Xia <xiy...@chromium.org>
    Gerrit-Reviewer: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Reviewer: Xiyuan Xia <xiy...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
    Gerrit-CC: David Tseng <dts...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Attention: Xiyuan Xia <xiy...@chromium.org>
    Gerrit-Comment-Date: Mon, 30 Jun 2025 21:07:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Xiyuan Xia <xiy...@chromium.org>
    satisfied_requirement
    open
    diffy

    Xiyuan Xia (Gerrit)

    unread,
    Jun 30, 2025, 5:25:16 PMJun 30
    to Chromium LUCI CQ, David Tseng, Achuith Bhandarkar, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, anastas...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

    Xiyuan Xia voted and added 1 comment

    Votes added by Xiyuan Xia

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Xiyuan Xia . resolved

    Thanks for the quick review.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If1c4d502758d541e523c636c15b42626d982d4ab
    Gerrit-Change-Number: 6691078
    Gerrit-PatchSet: 2
    Gerrit-Owner: Xiyuan Xia <xiy...@chromium.org>
    Gerrit-Reviewer: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Reviewer: Xiyuan Xia <xiy...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
    Gerrit-CC: David Tseng <dts...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Comment-Date: Mon, 30 Jun 2025 21:25:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Xiyuan Xia (Gerrit)

    unread,
    Jul 1, 2025, 1:08:55 PMJul 1
    to Akihiro Ota, Chromium LUCI CQ, David Tseng, Achuith Bhandarkar, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, anastas...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
    Attention needed from Akihiro Ota

    Xiyuan Xia voted and added 1 comment

    Votes added by Xiyuan Xia

    Commit-Queue+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Xiyuan Xia . resolved

    PTAL. Updated `mock_accessibility_private.js` to allow using promise version of `accessibityPrivate` api. Thanks.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Akihiro Ota
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If1c4d502758d541e523c636c15b42626d982d4ab
      Gerrit-Change-Number: 6691078
      Gerrit-PatchSet: 3
      Gerrit-Owner: Xiyuan Xia <xiy...@chromium.org>
      Gerrit-Reviewer: Akihiro Ota <akihi...@chromium.org>
      Gerrit-Reviewer: Xiyuan Xia <xiy...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
      Gerrit-CC: David Tseng <dts...@chromium.org>
      Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-Attention: Akihiro Ota <akihi...@chromium.org>
      Gerrit-Comment-Date: Tue, 01 Jul 2025 17:08:45 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Akihiro Ota (Gerrit)

      unread,
      Jul 1, 2025, 2:43:19 PMJul 1
      to Xiyuan Xia, Chromium LUCI CQ, David Tseng, Achuith Bhandarkar, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, anastas...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
      Attention needed from Xiyuan Xia

      Akihiro Ota voted and added 1 comment

      Votes added by Akihiro Ota

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 4 (Latest):
      Akihiro Ota . resolved

      Thanks, still LGTM

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Xiyuan Xia
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: If1c4d502758d541e523c636c15b42626d982d4ab
        Gerrit-Change-Number: 6691078
        Gerrit-PatchSet: 4
        Gerrit-Owner: Xiyuan Xia <xiy...@chromium.org>
        Gerrit-Reviewer: Akihiro Ota <akihi...@chromium.org>
        Gerrit-Reviewer: Xiyuan Xia <xiy...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
        Gerrit-CC: David Tseng <dts...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-Attention: Xiyuan Xia <xiy...@chromium.org>
        Gerrit-Comment-Date: Tue, 01 Jul 2025 18:43:12 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Xiyuan Xia (Gerrit)

        unread,
        Jul 1, 2025, 3:41:17 PMJul 1
        to Chromium LUCI CQ, David Tseng, Achuith Bhandarkar, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, anastas...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

        Xiyuan Xia voted and added 1 comment

        Votes added by Xiyuan Xia

        Commit-Queue+2

        1 comment

        Patchset-level comments
        Xiyuan Xia . resolved

        Thank you for the review.

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: If1c4d502758d541e523c636c15b42626d982d4ab
        Gerrit-Change-Number: 6691078
        Gerrit-PatchSet: 4
        Gerrit-Owner: Xiyuan Xia <xiy...@chromium.org>
        Gerrit-Reviewer: Akihiro Ota <akihi...@chromium.org>
        Gerrit-Reviewer: Xiyuan Xia <xiy...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
        Gerrit-CC: David Tseng <dts...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-Comment-Date: Tue, 01 Jul 2025 19:41:06 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Jul 1, 2025, 3:43:59 PMJul 1
        to Xiyuan Xia, Akihiro Ota, David Tseng, Achuith Bhandarkar, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, anastas...@google.com, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        a11y-common: Use MV3 `accessibilityPrivate` type defs

        Add `accessibilityPrivate` MV3 type defs and update callers.
        AX-Relnotes: n/a.
        Bug: 388867838
        Change-Id: If1c4d502758d541e523c636c15b42626d982d4ab
        Reviewed-by: Akihiro Ota <akihi...@chromium.org>
        Commit-Queue: Xiyuan Xia <xiy...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1481211}
        Files:
        • M chrome/browser/resources/chromeos/accessibility/accessibility_common/mv3/BUILD.gn
        • M chrome/browser/resources/chromeos/accessibility/accessibility_common/mv3/accessibility_common_loader.ts
        • M chrome/browser/resources/chromeos/accessibility/accessibility_common/mv3/dictation/dictation.ts
        • M chrome/browser/resources/chromeos/accessibility/accessibility_common/mv3/dictation/parse/pumpkin_parse_strategy.ts
        • M chrome/browser/resources/chromeos/accessibility/accessibility_common/mv3/facegaze/facegaze.ts
        • M chrome/browser/resources/chromeos/accessibility/accessibility_common/mv3/facegaze/mouse_controller.ts
        • M chrome/browser/resources/chromeos/accessibility/accessibility_common/mv3/facegaze/web_cam_face_landmarker.ts
        • M chrome/browser/resources/chromeos/accessibility/common/testing/mock_accessibility_private.js
        • A chrome/browser/resources/chromeos/accessibility/definitions/accessibility_private_mv3.d.ts
        Change size: L
        Delta: 9 files changed, 587 insertions(+), 55 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Akihiro Ota
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: If1c4d502758d541e523c636c15b42626d982d4ab
        Gerrit-Change-Number: 6691078
        Gerrit-PatchSet: 5
        Gerrit-Owner: Xiyuan Xia <xiy...@chromium.org>
        Gerrit-Reviewer: Akihiro Ota <akihi...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Xiyuan Xia <xiy...@chromium.org>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Achuith Bhandarkar <ach...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages