Reland "Specifies a null TimeTicks for input_start time when unsure" [chromium/src : main]
0 views
Skip to first unread message
Minoru Chikamune (Gerrit)
7:00 PM (4 hours ago) 7:00 PM
to Alex Moshchuk, Tsuyoshi Horo, Chromium LUCI CQ, Annie Sullivan, Rakina Zata Amni, Charlie Reis, AyeAye, chromium...@chromium.org, Peter Wen, Minoru Chikamune
Minoru Chikamune has uploaded the change for review![]( "Open in Gerrit")
Minoru Chikamune would like Alex Moshchuk, Tsuyoshi Horo, Chromium LUCI CQ, Annie Sullivan, Rakina Zata Amni and Charlie Reis to review this change.
Commit message
Reland "Specifies a null TimeTicks for input_start time when unsure"
This reverts commit 811fd55daaa71a97c99e0e21202e176034f92c5f.
Reason for revert: This was not the culprit.
Original change's description:
> Revert "Specifies a null TimeTicks for input_start time when unsure"
>
> This reverts commit a83a55af8a96e0f0b29cade6b6e883bcf285de7f.
>
> Reason for revert: Per the following comment, we suspect that this is causing crashes. Let me revert the CL, and see if it is relevant or not.
>
> https://chromium-review.googlesource.com/c/chromium/src/+/7250968/comments/20787fbb_ef3dfe74
>
> crash:
> https://crash.corp.google.com/browse?q=product_name+IN+%28%27AndroidWebView%27%2C%27Chrome%27%2C%27Chrome_Android%27%2C%27Chrome_ChromeOS%27%2C%27Chrome_Headless%27%2C%27Chrome_Linux%27%2C%27Chrome_Mac%27%2C%27Chrome_iOS%27%2C%27Chrome_iOS_MetricKit%27%29+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3ANavigationRequest%3A%3AScopedCrashKeys%3A%3AScopedCrashKeys%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27canary%27#-samplereports:115,+productname:20,-productversion:200,-processtype:100,channel:100,-chromiumcomponent,-directory:20,magicsignature2:30,-clientid:100,-operatingsystemfamily,osversion:100,day:60,hour:100,gpusubsystemid:6,experiments:100
>
> Original change's description:
> > Specifies a null TimeTicks for input_start time when unsure
> >
> > The input_start field must be set for the navigation when there is a
> > user input event. The value must be the OS-level timestamp. But the
> > current `NavigationRequest::CreateForSynchronousRendererCommit()`
> > specifies the current time instead of the timestamp of the user input
> > event. This CL specifies a null TimeTicks instead.
> >
> > Ref:
> > https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/mojom/navigation/navigation_params.mojom;l=308-311;drc=c095fc3a4c773ca8dbf348fb375daefa28b9a816
> >
> > https://docs.google.com/document/d/1Vk6ZyQcTrEUmUCEKU-NE0aDYOS0WGmGHE6jmph__DcI/edit?tab=t.0#heading=h.esot33hckmf
> >
> > Bug: 444575624
> > Bug: 467158532
> > Change-Id: I7fd0feab9b565ccd8d260a4532e8ee4355510955
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7250968
> > Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
> > Commit-Queue: Minoru Chikamune <chik...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1557890}
>
> Bug: 470054231
> Bug: 444575624
> Bug: 467158532
> Change-Id: I4546d7c3a93731d1d5e12c0de121cfd25938b951
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7460260
> Auto-Submit: Minoru Chikamune <chik...@chromium.org>
> Reviewed-by: Tsuyoshi Horo <ho...@chromium.org>
> Owners-Override: Tsuyoshi Horo <ho...@chromium.org>
> Commit-Queue: Tsuyoshi Horo <ho...@chromium.org>
> Commit-Queue: Minoru Chikamune <chik...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1568257}
Bug: 470054231
Bug: 444575624
Bug: 467158532
Change-Id: Ifc8f7d0ec478b168e74c113ae6f47f2e9f36e687
Change diff
diff --git a/content/browser/renderer_host/navigation_request.cc b/content/browser/renderer_host/navigation_request.cc
index 920cd98..8d33d307 100644
--- a/content/browser/renderer_host/navigation_request.cc
+++ b/content/browser/renderer_host/navigation_request.cc
@@ -1525,7 +1525,7 @@
std::vector<int>() /* initiator_origin_trial_features */,
std::string() /* href_translate */,
false /* is_history_navigation_in_new_child_frame */,
- base::TimeTicks::Now() /* input_start */,
+ base::TimeTicks() /* input_start */,
network::mojom::RequestDestination::kEmpty);
// Note that some params are set to default values (e.g. page_state set to
// the default blink::PageState()) even if the DidCommit message that came
Change information
Files:
- M content/browser/renderer_host/navigation_request.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Minoru Chikamune (Gerrit)
7:33 PM (4 hours ago) 7:33 PM
to Minoru Chikamune, Rubber Stamper, Alex Moshchuk, Tsuyoshi Horo, Chromium LUCI CQ, Annie Sullivan, Rakina Zata Amni, Charlie Reis, AyeAye, chromium...@chromium.org, Peter Wen, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org
Attention needed from Alex Moshchuk, Annie Sullivan, Charlie Reis, Rakina Zata Amni and Tsuyoshi Horo
Message from Minoru Chikamune![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention is currently required from:
- Alex Moshchuk
- Annie Sullivan
- Charlie Reis
- Rakina Zata Amni
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
7:34 PM (4 hours ago) 7:34 PM
to Minoru Chikamune, Alex Moshchuk, Tsuyoshi Horo, Chromium LUCI CQ, Annie Sullivan, Rakina Zata Amni, Charlie Reis, AyeAye, chromium...@chromium.org, Peter Wen, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org
Attention needed from Alex Moshchuk, Annie Sullivan, Charlie Reis, Rakina Zata Amni and Tsuyoshi Horo
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Alex Moshchuk
- Annie Sullivan
- Charlie Reis
- Rakina Zata Amni
- Tsuyoshi Horo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
8:24 PM (3 hours ago) 8:24 PM
to Minoru Chikamune, Rubber Stamper, Alex Moshchuk, Chromium LUCI CQ, Annie Sullivan, Rakina Zata Amni, Charlie Reis, AyeAye, chromium...@chromium.org, Peter Wen, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org
Attention needed from Alex Moshchuk, Annie Sullivan, Charlie Reis, Minoru Chikamune and Rakina Zata Amni
Tsuyoshi Horo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tsuyoshi Horo
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Alex Moshchuk
- Annie Sullivan
- Charlie Reis
- Minoru Chikamune
- Rakina Zata Amni
Alex Moshchuk (Gerrit)
8:35 PM (3 hours ago) 8:35 PM
to Minoru Chikamune, Tsuyoshi Horo, Rubber Stamper, Chromium LUCI CQ, Annie Sullivan, Rakina Zata Amni, Charlie Reis, AyeAye, chromium...@chromium.org, Peter Wen, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org
Attention needed from Annie Sullivan, Charlie Reis, Minoru Chikamune and Rakina Zata Amni
Alex Moshchuk voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Annie Sullivan
- Charlie Reis
- Minoru Chikamune
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Minoru Chikamune (Gerrit)
9:31 PM (2 hours ago) 9:31 PM
to Minoru Chikamune, Alex Moshchuk, Tsuyoshi Horo, Rubber Stamper, Chromium LUCI CQ, Annie Sullivan, Rakina Zata Amni, Charlie Reis, AyeAye, chromium...@chromium.org, Peter Wen, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org
Attention needed from Annie Sullivan, Charlie Reis and Rakina Zata Amni
Minoru Chikamune voted and added 1 comment![]( "Open in Gerrit")
Votes added by Minoru Chikamune
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Annie Sullivan
- Charlie Reis
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:12 PM (1 hour ago) 10:12 PM
to Minoru Chikamune, Alex Moshchuk, Tsuyoshi Horo, Rubber Stamper, Annie Sullivan, Rakina Zata Amni, Charlie Reis, AyeAye, chromium...@chromium.org, Peter Wen, alexmo...@chromium.org, navigation...@chromium.org, creis...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Minoru Chikamune <chik...@chromium.org>
Reviewed-by: Alex Moshchuk <ale...@chromium.org>
Reviewed-by: Tsuyoshi Horo <ho...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568873}
Files:
- M content/browser/renderer_host/navigation_request.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tsuyoshi Horo, +1 by Alex Moshchuk, Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages