[html-in-canvas] Update layout before checking eligibility [chromium/src : main]
0 views
Skip to first unread message
Philip Rogers (Gerrit)
Sep 25, 2025, 9:29:27 AM (yesterday) Sep 25
to Stephen Chenney, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Stephen Chenney
Philip Rogers voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Stephen Chenney
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Rogers (Gerrit)
Sep 25, 2025, 11:25:41 AM (yesterday) Sep 25
to Chromium LUCI CQ, Stephen Chenney, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Stephen Chenney
Philip Rogers voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Stephen Chenney
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Harrelson (Gerrit)
Sep 25, 2025, 11:57:55 AM (yesterday) Sep 25
to Philip Rogers, Chromium LUCI CQ, Stephen Chenney, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Philip Rogers and Stephen Chenney
Chris Harrelson added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/drawing-display-none-fails.html
Line 18, Patchset 2 (Latest):
canvas_2d_div.style.display = 'none';Chris Harrelson . unresolved
Also add a test for display: contents to address https://github.com/WICG/html-in-canvas/issues/48 ?
(I think a display:contents element should likely not be allowed with this API)
Related details
Attention is currently required from:
- Philip Rogers
- Stephen Chenney
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Rogers (Gerrit)
Sep 25, 2025, 12:01:32 PM (yesterday) Sep 25
to Chris Harrelson, Chromium LUCI CQ, Stephen Chenney, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Chris Harrelson and Stephen Chenney
Philip Rogers voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philip Rogers
| Commit-Queue | +1 |
1 comment
File third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/drawing-display-none-fails.html
Line 18, Patchset 2 (Latest):
canvas_2d_div.style.display = 'none';Chris Harrelson . unresolved
Also add a test for display: contents to address https://github.com/WICG/html-in-canvas/issues/48 ?
(I think a display:contents element should likely not be allowed with this API)
Philip Rogers
Mind if we do this as a followup? It's not directly connected to the crash bug being fixed here.
Related details
Attention is currently required from:
- Chris Harrelson
- Stephen Chenney
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Harrelson (Gerrit)
Sep 25, 2025, 12:01:57 PM (yesterday) Sep 25
to Philip Rogers, Chromium LUCI CQ, Stephen Chenney, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Philip Rogers and Stephen Chenney
Chris Harrelson added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/drawing-display-none-fails.html
Line 18, Patchset 2 (Latest):
canvas_2d_div.style.display = 'none';Chris Harrelson . resolved
Philip RogersAlso add a test for display: contents to address https://github.com/WICG/html-in-canvas/issues/48 ?
(I think a display:contents element should likely not be allowed with this API)
Mind if we do this as a followup? It's not directly connected to the crash bug being fixed here.
Attention is currently required from:
- Philip Rogers
- Stephen Chenney
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stephen Chenney (Gerrit)
Sep 25, 2025, 12:05:31 PM (yesterday) Sep 25
to Philip Rogers, Chris Harrelson, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Philip Rogers
Stephen Chenney voted and added 1 comment![]( "Open in Gerrit")
Votes added by Stephen Chenney
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Philip Rogers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 25, 2025, 12:09:42 PM (yesterday) Sep 25
to Philip Rogers, Stephen Chenney, Chris Harrelson, chromium...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[html-in-canvas] Update layout before checking eligibility
texElementImage2D had a bug where eligibility was checked prior to
updating layout. Credit to Emilio (emi...@mozilla.com) for spotting
this bug!
Change-Id: I1b83f44b8757bd555284ce3ddfbec4d4bc3db963
Reviewed-by: Stephen Chenney <sche...@chromium.org>
Commit-Queue: Stephen Chenney <sche...@chromium.org>
Auto-Submit: Philip Rogers <p...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1520657}
Files:
- M third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
- A third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/drawing-display-none-fails.html
- M third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/nested-webgl-canvas.html
Change size: M
Delta: 3 files changed, 47 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Stephen Chenney
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages