Add default font family mappings for Devanagari script [chromium/src : main]

0 views
Skip to first unread message

Dileep Maurya (Gerrit)

unread,
Feb 24, 2026, 5:29:23 AM (6 days ago) Feb 24
to Chromium LUCI CQ, AyeAye, chromium...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org
Attention needed from Dileep Maurya

Message from Dileep Maurya

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Dileep Maurya
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie9bef36347e147fca5f86278644016a0854f6dff
Gerrit-Change-Number: 7583873
Gerrit-PatchSet: 3
Gerrit-Owner: Dileep Maurya <dileep...@microsoft.com>
Gerrit-Reviewer: Dileep Maurya <dileep...@microsoft.com>
Gerrit-Attention: Dileep Maurya <dileep...@microsoft.com>
Gerrit-Comment-Date: Tue, 24 Feb 2026 10:29:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Sejal Anand (Gerrit)

unread,
Feb 26, 2026, 12:00:01 AM (4 days ago) Feb 26
to Dileep Maurya, Vinay Singh, Ragvesh Sharma, Gaurav Kumar, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org
Attention needed from Dileep Maurya and Gaurav Kumar

Sejal Anand added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Sejal Anand . unresolved

overall LGTM, do we need any test to verify these changes ?

Open in Gerrit

Related details

Attention is currently required from:
  • Dileep Maurya
  • Gaurav Kumar
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie9bef36347e147fca5f86278644016a0854f6dff
    Gerrit-Change-Number: 7583873
    Gerrit-PatchSet: 5
    Gerrit-Owner: Dileep Maurya <dileep...@microsoft.com>
    Gerrit-Reviewer: Dileep Maurya <dileep...@microsoft.com>
    Gerrit-Reviewer: Gaurav Kumar <gaur...@microsoft.com>
    Gerrit-Reviewer: Sejal Anand <sejal...@microsoft.com>
    Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
    Gerrit-CC: Vinay Singh <vinay...@microsoft.com>
    Gerrit-Attention: Gaurav Kumar <gaur...@microsoft.com>
    Gerrit-Attention: Dileep Maurya <dileep...@microsoft.com>
    Gerrit-Comment-Date: Thu, 26 Feb 2026 04:59:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sejal Anand (Gerrit)

    unread,
    Feb 26, 2026, 12:02:04 AM (4 days ago) Feb 26
    to Dileep Maurya, Vinay Singh, Ragvesh Sharma, Gaurav Kumar, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org
    Attention needed from Dileep Maurya and Gaurav Kumar

    Sejal Anand added 1 comment

    Commit Message
    Line 22, Patchset 5 (Latest):defaults in prefs_tab_helper.cc, which was previously missing.
    Sejal Anand . unresolved

    Can you please add spec link ?

    Gerrit-Comment-Date: Thu, 26 Feb 2026 05:01:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gaurav Kumar (Gerrit)

    unread,
    Feb 27, 2026, 6:43:27 AM (3 days ago) Feb 27
    to Dileep Maurya, Vinay Singh, Ragvesh Sharma, Sejal Anand, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org
    Attention needed from Dileep Maurya

    Gaurav Kumar added 1 comment

    Patchset-level comments
    Sejal Anand . unresolved

    overall LGTM, do we need any test to verify these changes ?

    Gaurav Kumar

    +1

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dileep Maurya
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie9bef36347e147fca5f86278644016a0854f6dff
    Gerrit-Change-Number: 7583873
    Gerrit-PatchSet: 5
    Gerrit-Owner: Dileep Maurya <dileep...@microsoft.com>
    Gerrit-Reviewer: Dileep Maurya <dileep...@microsoft.com>
    Gerrit-Reviewer: Gaurav Kumar <gaur...@microsoft.com>
    Gerrit-Reviewer: Sejal Anand <sejal...@microsoft.com>
    Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
    Gerrit-CC: Vinay Singh <vinay...@microsoft.com>
    Gerrit-Attention: Dileep Maurya <dileep...@microsoft.com>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 11:42:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Sejal Anand <sejal...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dileep Maurya (Gerrit)

    unread,
    12:32 AM (3 hours ago) 12:32 AM
    to Vinay Singh, Ragvesh Sharma, Sejal Anand, Gaurav Kumar, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org
    Attention needed from Gaurav Kumar and Sejal Anand

    Dileep Maurya added 2 comments

    Patchset-level comments
    File-level comment, Patchset 5:
    Sejal Anand . resolved

    overall LGTM, do we need any test to verify these changes ?

    Gaurav Kumar

    +1

    Dileep Maurya

    Added the test. Thanks.

    Commit Message
    Line 22, Patchset 5:defaults in prefs_tab_helper.cc, which was previously missing.
    Sejal Anand . resolved

    Can you please add spec link ?

    Dileep Maurya

    There is no spec link for this issue. This is not a spec-driven feature - it's a browser configuration/UX improvement.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Gaurav Kumar
    • Sejal Anand
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie9bef36347e147fca5f86278644016a0854f6dff
      Gerrit-Change-Number: 7583873
      Gerrit-PatchSet: 6
      Gerrit-Owner: Dileep Maurya <dileep...@microsoft.com>
      Gerrit-Reviewer: Dileep Maurya <dileep...@microsoft.com>
      Gerrit-Reviewer: Gaurav Kumar <gaur...@microsoft.com>
      Gerrit-Reviewer: Sejal Anand <sejal...@microsoft.com>
      Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
      Gerrit-CC: Vinay Singh <vinay...@microsoft.com>
      Gerrit-Attention: Gaurav Kumar <gaur...@microsoft.com>
      Gerrit-Attention: Sejal Anand <sejal...@microsoft.com>
      Gerrit-Comment-Date: Mon, 02 Mar 2026 05:31:36 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Gaurav Kumar <gaur...@microsoft.com>
      Comment-In-Reply-To: Sejal Anand <sejal...@microsoft.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Dileep Maurya (Gerrit)

      unread,
      3:46 AM (10 minutes ago) 3:46 AM
      to Dominik Röttsches, Elly FJ, Vinay Singh, Ragvesh Sharma, Sejal Anand, Gaurav Kumar, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org
      Attention needed from Dominik Röttsches, Elly FJ, Gaurav Kumar and Sejal Anand

      Dileep Maurya voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dominik Röttsches
      • Elly FJ
      • Gaurav Kumar
      • Sejal Anand
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie9bef36347e147fca5f86278644016a0854f6dff
      Gerrit-Change-Number: 7583873
      Gerrit-PatchSet: 6
      Gerrit-Owner: Dileep Maurya <dileep...@microsoft.com>
      Gerrit-Reviewer: Dileep Maurya <dileep...@microsoft.com>
      Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
      Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
      Gerrit-Reviewer: Gaurav Kumar <gaur...@microsoft.com>
      Gerrit-Reviewer: Sejal Anand <sejal...@microsoft.com>
      Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
      Gerrit-CC: Vinay Singh <vinay...@microsoft.com>
      Gerrit-Attention: Gaurav Kumar <gaur...@microsoft.com>
      Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
      Gerrit-Attention: Elly FJ <elly...@chromium.org>
      Gerrit-Attention: Sejal Anand <sejal...@microsoft.com>
      Gerrit-Comment-Date: Mon, 02 Mar 2026 08:45:40 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Dominik Röttsches (Gerrit)

      unread,
      3:48 AM (7 minutes ago) 3:48 AM
      to Dileep Maurya, Koji Ishii, Elly FJ, Vinay Singh, Ragvesh Sharma, Sejal Anand, Gaurav Kumar, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org
      Attention needed from Dileep Maurya, Elly FJ, Gaurav Kumar, Koji Ishii and Sejal Anand

      Dominik Röttsches voted and added 1 comment

      Votes added by Dominik Röttsches

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 6 (Latest):
      Dominik Röttsches . resolved

      LGTM, but it'd be good to have Koji's opinion on this.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dileep Maurya
      • Elly FJ
      • Gaurav Kumar
      • Koji Ishii
      • Sejal Anand
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie9bef36347e147fca5f86278644016a0854f6dff
        Gerrit-Change-Number: 7583873
        Gerrit-PatchSet: 6
        Gerrit-Owner: Dileep Maurya <dileep...@microsoft.com>
        Gerrit-Reviewer: Dileep Maurya <dileep...@microsoft.com>
        Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
        Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
        Gerrit-Reviewer: Gaurav Kumar <gaur...@microsoft.com>
        Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
        Gerrit-Reviewer: Sejal Anand <sejal...@microsoft.com>
        Gerrit-CC: Ragvesh Sharma <rags...@microsoft.com>
        Gerrit-CC: Vinay Singh <vinay...@microsoft.com>
        Gerrit-Attention: Gaurav Kumar <gaur...@microsoft.com>
        Gerrit-Attention: Elly FJ <elly...@chromium.org>
        Gerrit-Attention: Sejal Anand <sejal...@microsoft.com>
        Gerrit-Attention: Dileep Maurya <dileep...@microsoft.com>
        Gerrit-Attention: Koji Ishii <ko...@chromium.org>
        Gerrit-Comment-Date: Mon, 02 Mar 2026 08:48:30 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages