Update a devtools test before a UI migration [chromium/src : main]

0 views
Skip to first unread message

Philip Pfaffe (Gerrit)

unread,
6:07 AM (1 hour ago) 6:07 AM
to Danil Somsikov, devtools...@chromium.org, chromium...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org
Attention needed from Danil Somsikov

Philip Pfaffe has uploaded the change for review

Philip Pfaffe would like Danil Somsikov to review this change.

Commit message

Update a devtools test before a UI migration

R=d...@chromium.org
Bug: 407751377
Change-Id: Ic779b9722b1c6b2a0dff89def5ce803d71d2a90b

Change diff

diff --git a/third_party/blink/web_tests/http/tests/devtools/a11y-axe-core/settings/locations-a11y-test.js b/third_party/blink/web_tests/http/tests/devtools/a11y-axe-core/settings/locations-a11y-test.js
index 9950a580..f6a33b08 100644
--- a/third_party/blink/web_tests/http/tests/devtools/a11y-axe-core/settings/locations-a11y-test.js
+++ b/third_party/blink/web_tests/http/tests/devtools/a11y-axe-core/settings/locations-a11y-test.js
@@ -11,6 +11,7 @@

await UI.ViewManager.ViewManager.instance().showView('emulation-locations');
const locationsWidget = await UI.ViewManager.ViewManager.instance().view('emulation-locations').widget();
+ await UI.Widget.Widget.allUpdatesComplete;

async function testAddLocation() {
const addLocationButton = locationsWidget.contentElement.querySelector('.add-locations-button');

Change information

Files:
  • M third_party/blink/web_tests/http/tests/devtools/a11y-axe-core/settings/locations-a11y-test.js
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Danil Somsikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic779b9722b1c6b2a0dff89def5ce803d71d2a90b
Gerrit-Change-Number: 8074081
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Attention: Danil Somsikov <d...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages