Yoshiki IGUCHI (Gerrit)

unread,

Jun 15, 2026, 2:44:09 AM (11 days ago) Jun 15

to Yoshiki IGUCHI, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, asumane...@google.com, tbarzi...@chromium.org, rrsilva+wat...@google.com

Attention needed from Hidehiko Abe

Yoshiki IGUCHI added 1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Yoshiki IGUCHI . resolved

Hidehiko-san, PTAL. Thanks.

Open in Gerrit

Related details

Attention is currently required from:

Hidehiko Abe

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hidehiko Abe (Gerrit)

unread,

Jun 18, 2026, 2:16:54 AM (8 days ago) Jun 18

to Yoshiki IGUCHI, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, asumane...@google.com, tbarzi...@chromium.org, rrsilva+wat...@google.com

Attention needed from Yoshiki IGUCHI

Hidehiko Abe voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Yoshiki IGUCHI

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Yoshiki IGUCHI (Gerrit)

unread,

Jun 18, 2026, 3:00:55 AM (8 days ago) Jun 18

to Yoshiki IGUCHI, Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, asumane...@google.com, tbarzi...@chromium.org, rrsilva+wat...@google.com

Yoshiki IGUCHI voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 18, 2026, 4:12:55 AM (8 days ago) Jun 18

to Yoshiki IGUCHI, Hidehiko Abe, Di Wu, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, asumane...@google.com, tbarzi...@chromium.org, rrsilva+wat...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

ASH Refactoring: Move 50 login-related strings to ash/ (Part 4)

Move 50 login-related strings from chrome/app/chromeos_strings.grdp
to ash/login/resources/login_strings.grd.

Moved strings:
- IDS_LOGIN_ACCOUNT_SETUP_CANCEL_DIALOG_NO
- IDS_LOGIN_ACCOUNT_SETUP_CANCEL_DIALOG_TITLE
- IDS_LOGIN_ACCOUNT_SETUP_CANCEL_DIALOG_YES
- IDS_LOGIN_CONFIRM_PASSWORD_INCORRECT_PASSWORD
- IDS_LOGIN_CONFIRM_PASSWORD_LABEL
- IDS_LOGIN_CONFIRM_PASSWORD_TITLE
- IDS_LOGIN_DEVICE_MANAGED_BY_NOTICE
- IDS_LOGIN_FACTORS_REMOVED_SUBTITLE
- IDS_LOGIN_FACTORS_REMOVED_TITLE
- IDS_LOGIN_FACTOR_SETUP_SUCCESS_LOCAL_PASSWORD_SET_TITLE
- IDS_LOGIN_FACTOR_SETUP_SUCCESS_LOCAL_PASSWORD_SUBTITLE
- IDS_LOGIN_FACTOR_SETUP_SUCCESS_LOCAL_PASSWORD_UPDATED_TITLE
- IDS_LOGIN_FATAL_ERROR_AUTO_ENROLLMENT_SKIPPED
- IDS_LOGIN_FATAL_ERROR_NO_ACCOUNT_DETAILS
- IDS_LOGIN_FATAL_ERROR_NO_AUTH_TOKEN
- IDS_LOGIN_FATAL_ERROR_NO_PASSWORD
- IDS_LOGIN_FATAL_ERROR_PASSWORD_VERIFICATION
- IDS_LOGIN_FATAL_ERROR_RESTART_AND_POWERWASH_BUTTON
- IDS_LOGIN_FATAL_ERROR_TEXT_INSECURE_URL
- IDS_LOGIN_FATAL_ERROR_TRY_AGAIN_BUTTON
- IDS_LOGIN_GENERIC_DONE_BUTTON
- IDS_LOGIN_GENERIC_RETRY_BUTTON
- IDS_LOGIN_LOCAL_PASSWORD_RESET_TITLE
- IDS_LOGIN_LOCAL_PASSWORD_SETUP_SUBTITLE
- IDS_LOGIN_LOCAL_PASSWORD_SETUP_TITLE
- IDS_LOGIN_MANUAL_PASSWORD_INPUT_LABEL
- IDS_LOGIN_MANUAL_PASSWORD_MISMATCH
- IDS_LOGIN_MANUAL_PASSWORD_TITLE
- IDS_LOGIN_SAML_CHANGE_PROVIDER_BUTTON
- IDS_LOGIN_SAML_CHANGE_PROVIDER_MESSAGE
- IDS_LOGIN_SAML_INTERSTITIAL_CHANGE_ACCOUNT_LINK_TEXT
- IDS_LOGIN_SAML_INTERSTITIAL_MESSAGE
- IDS_LOGIN_SAML_INTERSTITIAL_NEXT_BUTTON_TEXT
- IDS_LOGIN_SAML_NOTICE_SHORT
- IDS_LOGIN_SAML_NOTICE_WITH_VIDEO
- IDS_LOGIN_SAML_PASSWORD_CHANGE_NOTICE
- IDS_LOGIN_WELCOME_MESSAGE
- IDS_OFFLINE_LOGIN_CLOSE_BUTTON_TEXT
- IDS_OFFLINE_LOGIN_EMAIL
- IDS_OFFLINE_LOGIN_FORGOT_PASSWORD_BUTTON_TEXT
- IDS_OFFLINE_LOGIN_FORGOT_PASSWORD_DIALOG_TEXT
- IDS_OFFLINE_LOGIN_INVALID_EMAIL
- IDS_OFFLINE_LOGIN_INVALID_PASSWORD
- IDS_OFFLINE_LOGIN_INVALID_PIN
- IDS_OFFLINE_LOGIN_NEXT_BUTTON_TEXT
- IDS_OFFLINE_LOGIN_OK_BUTTON_TEXT
- IDS_OFFLINE_LOGIN_PASSWORD
- IDS_OFFLINE_LOGIN_PIN
- IDS_OFFLINE_LOGIN_WARNING_TEXT
- IDS_OFFLINE_LOGIN_WARNING_TITLE

Also move 21 string image files from
chrome/app/chromeos_strings_grdp to ash/login/resources/login_strings_grd.

Bug: 487122295

Test: CQ passes

Skip-Translation-Screenshots-Check: True

Change-Id: Ifa9951de98385baff1f2ce5ca4ac9929af5e96f6

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7931468

Commit-Queue: Yoshiki IGUCHI <yos...@chromium.org>

Reviewed-by: Hidehiko Abe <hide...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1648856}

Files:

M ash/login/resources/login_strings.grd
R ash/login/resources/login_strings_grd/IDS_LOGIN_DEVICE_MANAGED_BY_NOTICE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_FACTORS_REMOVED_SUBTITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_FACTORS_REMOVED_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_FACTOR_SETUP_SUCCESS_LOCAL_PASSWORD_SET_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_FACTOR_SETUP_SUCCESS_LOCAL_PASSWORD_SUBTITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_FACTOR_SETUP_SUCCESS_LOCAL_PASSWORD_UPDATED_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_FATAL_ERROR_AUTO_ENROLLMENT_SKIPPED.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_FATAL_ERROR_RESTART_AND_POWERWASH_BUTTON.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_GENERIC_DONE_BUTTON.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_GENERIC_RETRY_BUTTON.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_LOCAL_PASSWORD_RESET_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_LOCAL_PASSWORD_SETUP_SUBTITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_LOCAL_PASSWORD_SETUP_TITLE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_SAML_CHANGE_PROVIDER_BUTTON.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_SAML_CHANGE_PROVIDER_MESSAGE.png.sha1
R ash/login/resources/login_strings_grd/IDS_LOGIN_SAML_NOTICE_SHORT.png.sha1
R ash/login/resources/login_strings_grd/IDS_OFFLINE_LOGIN_INVALID_PIN.png.sha1
R ash/login/resources/login_strings_grd/IDS_OFFLINE_LOGIN_OK_BUTTON_TEXT.png.sha1
R ash/login/resources/login_strings_grd/IDS_OFFLINE_LOGIN_PIN.png.sha1
R ash/login/resources/login_strings_grd/IDS_OFFLINE_LOGIN_WARNING_TEXT.png.sha1
R ash/login/resources/login_strings_grd/IDS_OFFLINE_LOGIN_WARNING_TITLE.png.sha1
M chrome/app/chromeos_strings.grdp
M chrome/browser/ash/login/saml/BUILD.gn
M chrome/browser/ash/login/saml/DEPS
M chrome/browser/ash/login/saml/saml_browsertest.cc
M chrome/browser/ui/ash/login/BUILD.gn
M chrome/browser/ui/ash/login/login_display_host_common.cc
M chrome/browser/ui/webui/ash/in_session_password_change/BUILD.gn
M chrome/browser/ui/webui/ash/in_session_password_change/password_change_ui.cc
M chrome/browser/ui/webui/ash/login/enrollment_screen_handler.cc
M chrome/browser/ui/webui/ash/login/local_password_setup_handler.cc
M chrome/browser/ui/webui/ash/login/offline_login_screen_handler.cc
M chrome/browser/ui/webui/ash/login/osauth/factor_setup_success_screen_handler.cc
M chrome/browser/ui/webui/ash/login/osauth/osauth_error_screen_handler.cc
M chrome/browser/ui/webui/ash/login/remove_local_auth_factors_screen_handler.cc
M chrome/browser/ui/webui/ash/login/saml_confirm_password_handler.cc
M chrome/browser/ui/webui/ash/login/signin_fatal_error_screen_handler.cc

Change size: L

Delta: 38 files changed, 166 insertions(+), 160 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Hidehiko Abe

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

ASH Refactoring: Move 50 login-related strings to ash/ (Part 4) [chromium/src : main]

Yoshiki IGUCHI (Gerrit)

Yoshiki IGUCHI added 1 comment

Related details

Hidehiko Abe (Gerrit)

Hidehiko Abe voted Code-Review+1

Related details

Yoshiki IGUCHI (Gerrit)

Yoshiki IGUCHI voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information