[iOS Blink] Include video_capture_metrics_mac.h in video_capture_device_avfoundation.mm [chromium/src : main]

0 views
Skip to first unread message

Gyuyoung Kim (Gerrit)

unread,
Dec 4, 2025, 4:55:55 PM (2 days ago) Dec 4
to Miguel Casas-Sanchez, Dave Tapuska, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, AyeAye, chromium...@chromium.org, Rijubrata Bhaumik, cobalt-...@google.com, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Dave Tapuska and Miguel Casas-Sanchez

Gyuyoung Kim added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Gyuyoung Kim . resolved

PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
  • Miguel Casas-Sanchez
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I311f319bef74d9fbb2e6094d622fcf22c14bb937
Gerrit-Change-Number: 7227215
Gerrit-PatchSet: 2
Gerrit-Owner: Gyuyoung Kim <gyuy...@igalia.com>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Miguel Casas-Sanchez <mca...@chromium.org>
Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Miguel Casas-Sanchez <mca...@chromium.org>
Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Dec 2025 21:55:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dave Tapuska (Gerrit)

unread,
Dec 5, 2025, 9:49:01 AM (17 hours ago) Dec 5
to Gyuyoung Kim, Miguel Casas-Sanchez, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, AyeAye, chromium...@chromium.org, Rijubrata Bhaumik, cobalt-...@google.com, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Gyuyoung Kim and Miguel Casas-Sanchez

Dave Tapuska voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Gyuyoung Kim
  • Miguel Casas-Sanchez
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I311f319bef74d9fbb2e6094d622fcf22c14bb937
    Gerrit-Change-Number: 7227215
    Gerrit-PatchSet: 2
    Gerrit-Owner: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Miguel Casas-Sanchez <mca...@chromium.org>
    Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
    Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Miguel Casas-Sanchez <mca...@chromium.org>
    Gerrit-Attention: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Comment-Date: Fri, 05 Dec 2025 14:48:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gyuyoung Kim (Gerrit)

    unread,
    Dec 5, 2025, 8:25:15 PM (7 hours ago) Dec 5
    to Tomas Gunnarsson, Dave Tapuska, Miguel Casas-Sanchez, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, AyeAye, chromium...@chromium.org, Rijubrata Bhaumik, cobalt-...@google.com, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Miguel Casas-Sanchez and Tomas Gunnarsson

    Gyuyoung Kim added 1 comment

    Patchset-level comments
    Gyuyoung Kim . resolved

    Add Tommi to reviewers as well.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Miguel Casas-Sanchez
    • Tomas Gunnarsson
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I311f319bef74d9fbb2e6094d622fcf22c14bb937
    Gerrit-Change-Number: 7227215
    Gerrit-PatchSet: 2
    Gerrit-Owner: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Miguel Casas-Sanchez <mca...@chromium.org>
    Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
    Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
    Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Tomas Gunnarsson <to...@chromium.org>
    Gerrit-Attention: Miguel Casas-Sanchez <mca...@chromium.org>
    Gerrit-Comment-Date: Sat, 06 Dec 2025 01:24:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Miguel Casas-Sanchez (Gerrit)

    unread,
    Dec 5, 2025, 11:21:56 PM (4 hours ago) Dec 5
    to Gyuyoung Kim, Tomas Gunnarsson, Dave Tapuska, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, AyeAye, chromium...@chromium.org, Rijubrata Bhaumik, cobalt-...@google.com, chfreme...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Gyuyoung Kim and Tomas Gunnarsson

    Miguel Casas-Sanchez voted and added 1 comment

    Votes added by Miguel Casas-Sanchez

    Code-Review+1

    1 comment

    Patchset-level comments
    Miguel Casas-Sanchez . resolved

    Didn't see this. LGTM !

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Gyuyoung Kim
    • Tomas Gunnarsson
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I311f319bef74d9fbb2e6094d622fcf22c14bb937
    Gerrit-Change-Number: 7227215
    Gerrit-PatchSet: 2
    Gerrit-Owner: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Miguel Casas-Sanchez <mca...@chromium.org>
    Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
    Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
    Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Tomas Gunnarsson <to...@chromium.org>
    Gerrit-Attention: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Comment-Date: Sat, 06 Dec 2025 04:21:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages