Add the dimensions through flatbuffer when attaching embedding model [chromium/src : main]

0 views
Skip to first unread message

Seung Jae Lim (Gerrit)

unread,
5:28 PM (3 hours ago) 5:28 PM
to Xinghui Lu, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, druber...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Xinghui Lu

Seung Jae Lim added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Seung Jae Lim . resolved

Hi @xing...@chromium.org, would you be able to take a look? Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Xinghui Lu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I66264a0e3941167280114b9e8303559b35b5eafd
Gerrit-Change-Number: 7485680
Gerrit-PatchSet: 1
Gerrit-Owner: Seung Jae Lim <andy...@chromium.org>
Gerrit-Reviewer: Seung Jae Lim <andy...@chromium.org>
Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
Gerrit-Attention: Xinghui Lu <xing...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Jan 2026 22:28:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Xinghui Lu (Gerrit)

unread,
6:21 PM (2 hours ago) 6:21 PM
to Seung Jae Lim, Xinghui Lu, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, druber...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Seung Jae Lim

Xinghui Lu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Seung Jae Lim
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I66264a0e3941167280114b9e8303559b35b5eafd
    Gerrit-Change-Number: 7485680
    Gerrit-PatchSet: 1
    Gerrit-Owner: Seung Jae Lim <andy...@chromium.org>
    Gerrit-Reviewer: Seung Jae Lim <andy...@chromium.org>
    Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
    Gerrit-Attention: Seung Jae Lim <andy...@chromium.org>
    Gerrit-Comment-Date: Thu, 15 Jan 2026 23:21:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Seung Jae Lim (Gerrit)

    unread,
    7:06 PM (2 hours ago) 7:06 PM
    to Xinghui Lu, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, druber...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

    Seung Jae Lim voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I66264a0e3941167280114b9e8303559b35b5eafd
    Gerrit-Change-Number: 7485680
    Gerrit-PatchSet: 1
    Gerrit-Owner: Seung Jae Lim <andy...@chromium.org>
    Gerrit-Reviewer: Seung Jae Lim <andy...@chromium.org>
    Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
    Gerrit-Comment-Date: Fri, 16 Jan 2026 00:05:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    7:08 PM (2 hours ago) 7:08 PM
    to Seung Jae Lim, Xinghui Lu, chromium...@chromium.org, andysjl...@chromium.org, druber...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Add the dimensions through flatbuffer when attaching embedding model
    Bug: 467732055
    Change-Id: I66264a0e3941167280114b9e8303559b35b5eafd
    Fixed: 476138936
    Reviewed-by: Xinghui Lu <xing...@chromium.org>
    Commit-Queue: Seung Jae Lim <andy...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1570077}
    Files:
    • M components/safe_browsing/content/renderer/phishing_classifier/scorer.cc
    Change size: XS
    Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Xinghui Lu
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I66264a0e3941167280114b9e8303559b35b5eafd
    Gerrit-Change-Number: 7485680
    Gerrit-PatchSet: 2
    Gerrit-Owner: Seung Jae Lim <andy...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Seung Jae Lim <andy...@chromium.org>
    Gerrit-Reviewer: Xinghui Lu <xing...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages