Test //net AbslHashValue() implementations [chromium/src : main]
0 views
Skip to first unread message
Adam Rice (Gerrit)
Feb 27, 2026, 7:19:44 AM (3 days ago) Feb 27
to Nidhi Jaju, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Nidhi Jaju
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Nidhi Jaju
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nidhi Jaju (Gerrit)
Mar 1, 2026, 9:51:01 PM (6 hours ago) Mar 1
to Adam Rice, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Attention needed from Adam Rice
Nidhi Jaju voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nidhi Jaju
| Code-Review | +1 |
2 comments
Patchset-level comments
File net/base/schemeful_site_unittest.cc
Line 198, Patchset 2 (Latest):
// This doesn't strictly belong in this test but the list of non-equal originsNidhi Jaju . unresolved
optional: We could also move kTestOrigins out of this test and create a new test for VerifyTypeImplementsAbslHashCorrectly.
Related details
Attention is currently required from:
- Adam Rice
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
12:30 AM (3 hours ago) 12:30 AM
to Nidhi Jaju, Chromium LUCI CQ, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Adam Rice voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Rice
| Commit-Queue | +2 |
1 comment
File net/base/schemeful_site_unittest.cc
Line 198, Patchset 2 (Latest):
// This doesn't strictly belong in this test but the list of non-equal originsNidhi Jaju . resolved
optional: We could also move kTestOrigins out of this test and create a new test for VerifyTypeImplementsAbslHashCorrectly.
Adam Rice
I decided that wasn't worth it.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:55 AM (3 hours ago) 12:55 AM
to Adam Rice, Nidhi Jaju, chromium...@chromium.org, bnc+...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Test //net AbslHashValue() implementations
Some implementation of AbslHashValue() in //net did not have tests. Add
them, using the standard absl::VerifyTypeImplementsAbslHashCorrectly()
function.
Tests mostly written by Gemini.
Change-Id: I97dff1f9a906aa6b071cf91a25ec0b42fcfc082a
Reviewed-by: Nidhi Jaju <nidh...@chromium.org>
Commit-Queue: Adam Rice <ri...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1592254}
Files:
- M net/base/ip_endpoint_unittest.cc
- M net/base/network_anonymization_key_unittest.cc
- M net/base/network_isolation_key_unittest.cc
- M net/base/schemeful_site_unittest.cc
Change size: M
Delta: 4 files changed, 75 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nidhi Jaju
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages