Add structured test id experiment for presubmit tests [chromium/tools/depot_tools : main]

[Benjamin Joyce (Ben) (Gerrit)]

Attention needed from Scott Lee and Yiwei Zhang

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Scott Lee
• Yiwei Zhang

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/tools/depot_tools

Gerrit-Branch: main

Gerrit-Change-Id: Iaf42e5cf173754302648ab7e27fc39b8b8c8732b

Gerrit-Change-Number: 7231163

Gerrit-PatchSet: 2

Gerrit-Owner: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Reviewer: Scott Lee <ddo...@chromium.org>

Gerrit-Reviewer: Yiwei Zhang <yiwz...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Scott Lee <ddo...@chromium.org>

Gerrit-Attention: Yiwei Zhang <yiwz...@google.com>

Gerrit-Comment-Date: Fri, 05 Dec 2025 20:53:55 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Yiwei Zhang (Gerrit)]

Attention needed from Benjamin Joyce (Ben) and Scott Lee

Yiwei Zhang added 1 comment

File recipes/recipe_modules/presubmit/api.py

Line 39, Patchset 5 (Latest): if in_rdb_exp:

Yiwei Zhang . unresolved

I think you are missing the declaration of the `in_rdb_exp` variable.

Open in Gerrit

Related details

Attention is currently required from:

• Benjamin Joyce (Ben)
• Scott Lee

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/tools/depot_tools

Gerrit-Branch: main

Gerrit-Change-Id: Iaf42e5cf173754302648ab7e27fc39b8b8c8732b

Gerrit-Change-Number: 7231163

Gerrit-PatchSet: 5

Gerrit-Owner: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Reviewer: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Reviewer: Scott Lee <ddo...@chromium.org>

Gerrit-Reviewer: Yiwei Zhang <yiwz...@google.com>

Gerrit-CC: LUCI CQ <infra-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Attention: Scott Lee <ddo...@chromium.org>

Gerrit-Comment-Date: Fri, 05 Dec 2025 20:56:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Benjamin Joyce (Ben) (Gerrit)]

Attention needed from Scott Lee

Benjamin Joyce (Ben) added 1 comment

File recipes/recipe_modules/presubmit/api.py

Line 39, Patchset 5: if in_rdb_exp:

Yiwei Zhang . resolved

I think you are missing the declaration of the `in_rdb_exp` variable.

Benjamin Joyce (Ben)

APologies. I was wanting to ask if this has access to the

api.buildbucket.build.input.experiments and got sidetracked.

Open in Gerrit

Related details

Attention is currently required from:

• Scott Lee

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/tools/depot_tools

Gerrit-Branch: main

Gerrit-Change-Id: Iaf42e5cf173754302648ab7e27fc39b8b8c8732b

Gerrit-Change-Number: 7231163

Gerrit-PatchSet: 7

Gerrit-Owner: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Reviewer: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Reviewer: Scott Lee <ddo...@chromium.org>

Gerrit-Reviewer: Yiwei Zhang <yiwz...@google.com>

Gerrit-CC: LUCI CQ <infra-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Scott Lee <ddo...@chromium.org>

Gerrit-Comment-Date: Fri, 05 Dec 2025 21:17:56 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Yiwei Zhang <yiwz...@google.com>

[Yiwei Zhang (Gerrit)]

Attention needed from Benjamin Joyce (Ben) and Scott Lee

Yiwei Zhang added 1 comment

File recipes/recipe_modules/presubmit/api.py

Line 40, Patchset 7 (Latest): in api.buildbucket.build.input.experiments):

Yiwei Zhang . unresolved

self.m

Open in Gerrit

Related details

Attention is currently required from:

• Benjamin Joyce (Ben)
• Scott Lee

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/tools/depot_tools

Gerrit-Branch: main

Gerrit-Change-Id: Iaf42e5cf173754302648ab7e27fc39b8b8c8732b

Gerrit-Change-Number: 7231163

Gerrit-PatchSet: 7

Gerrit-Owner: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Reviewer: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Reviewer: Scott Lee <ddo...@chromium.org>

Gerrit-Reviewer: Yiwei Zhang <yiwz...@google.com>

Gerrit-CC: LUCI CQ <infra-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Attention: Scott Lee <ddo...@chromium.org>

Gerrit-Comment-Date: Fri, 05 Dec 2025 21:22:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Benjamin Joyce (Ben) (Gerrit)]

Attention needed from Scott Lee and Yiwei Zhang

Benjamin Joyce (Ben) added 1 comment

File recipes/recipe_modules/presubmit/api.py

Line 40, Patchset 7: in api.buildbucket.build.input.experiments):

Yiwei Zhang . resolved

self.m

Benjamin Joyce (Ben)

Done

Open in Gerrit

Related details

Attention is currently required from:

• Scott Lee
• Yiwei Zhang

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/tools/depot_tools

Gerrit-Branch: main

Gerrit-Change-Id: Iaf42e5cf173754302648ab7e27fc39b8b8c8732b

Gerrit-Change-Number: 7231163

Gerrit-PatchSet: 8

Gerrit-Owner: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Reviewer: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Reviewer: Scott Lee <ddo...@chromium.org>

Gerrit-Reviewer: Yiwei Zhang <yiwz...@google.com>

Gerrit-CC: LUCI CQ <infra-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Scott Lee <ddo...@chromium.org>

Gerrit-Attention: Yiwei Zhang <yiwz...@google.com>

Gerrit-Comment-Date: Sat, 06 Dec 2025 01:09:59 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Yiwei Zhang <yiwz...@google.com>

[Yiwei Zhang (Gerrit)]

Attention needed from Benjamin Joyce (Ben) and Scott Lee

Yiwei Zhang added 1 comment

File recipes/recipe_modules/presubmit/api.py

Line 40, Patchset 8 (Latest): in self.m.api.buildbucket.build.input.experiments):

Yiwei Zhang . unresolved

```suggestion
            in self.m.buildbucket.build.input.experiments):
```

Open in Gerrit

Related details

Attention is currently required from:

• Benjamin Joyce (Ben)
• Scott Lee

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/tools/depot_tools

Gerrit-Branch: main

Gerrit-Change-Id: Iaf42e5cf173754302648ab7e27fc39b8b8c8732b

Gerrit-Change-Number: 7231163

Gerrit-PatchSet: 8

Gerrit-Owner: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Reviewer: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Reviewer: Scott Lee <ddo...@chromium.org>

Gerrit-Reviewer: Yiwei Zhang <yiwz...@google.com>

Gerrit-CC: LUCI CQ <infra-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Benjamin Joyce (Ben) <bjo...@google.com>

Gerrit-Attention: Scott Lee <ddo...@chromium.org>

Gerrit-Comment-Date: Sat, 06 Dec 2025 05:37:26 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No