[CodeHealth] Spanify AudioEncoderOpus [chromium/src : main]
0 views
Skip to first unread message
Thomas Guilbert (Gerrit)
Feb 26, 2026, 8:35:09 PM (2 days ago) Feb 26
to Thomas Guilbert, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Yuwei Huang
Thomas Guilbert voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Guilbert
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Thomas Guilbert . resolved
PTAL!
Apologies for the rewrite... I tried many ways to gradually spanify this class, field by field, but it was very hard to make forward progress. These attempts did give me the understanding needed to write this CL though.
The core code was written by hand, the UTs were assisted by Gemini.
Related details
Attention is currently required from:
- Yuwei Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yuwei Huang (Gerrit)
Feb 27, 2026, 2:26:09 PM (10 hours ago) Feb 27
to Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Attention needed from Thomas Guilbert
Yuwei Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Thomas Guilbert
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Guilbert (Gerrit)
Feb 27, 2026, 10:28:32 PM (2 hours ago) Feb 27
to Thomas Guilbert, Yuwei Huang, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org
Thomas Guilbert voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 27, 2026, 11:01:51 PM (2 hours ago) Feb 27
to Thomas Guilbert, Yuwei Huang, chromium...@chromium.org, chromotin...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[CodeHealth] Spanify AudioEncoderOpus
This CL rewrites AudioEncoderOpus to use spans instead of raw pointers.
Previous attempts at gradual spanification were unsuccessful, due to the
complexity of making incremental changes.
It breaks down the encoding flows into two distinct flows: with and
without resampling. To help manage samples before resampling, the CL
introduces an internal helper FIFO, which minimizes copies.
The CL also cleans up a previous TODO, which makes sure to use the
proper resampling input size, and adds more unit test coverage.
Bug: 373960632
Change-Id: Ie41f5bd97d72ee258db58107edbde06f9e2e7636
Reviewed-by: Yuwei Huang <yuw...@chromium.org>
Commit-Queue: Thomas Guilbert <tgui...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1591960}
Files:
- M remoting/codec/audio_encoder_opus.cc
- M remoting/codec/audio_encoder_opus.h
- M remoting/codec/audio_encoder_opus_unittest.cc
Change size: L
Delta: 3 files changed, 521 insertions(+), 132 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yuwei Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages