[Views] Close profile menu prior to showing sync passphrase dialog [chromium/src : main]
0 views
Skip to first unread message
David Roger (Gerrit)
Jul 23, 2026, 1:09:42 PM (18 hours ago) Jul 23
to Amelie Schneider, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Amelie Schneider and David Roger
Message from David Roger![]( "Open in Gerrit")
Set Ready For Review
CQ dry run passed! Sending for review (automated via send_after_cq_dryrun.py).
Related details
Attention is currently required from:
- Amelie Schneider
- David Roger
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Amelie Schneider (Gerrit)
4:43 AM (2 hours ago) 4:43 AM
to David Roger, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from David Roger
Amelie Schneider voted and added 1 comment![]( "Open in Gerrit")
Votes added by Amelie Schneider
| Code-Review | +1 |
1 comment
File chrome/browser/ui/views/profiles/profile_menu_view.cc
Line 372, Patchset 1 (Latest):
Browser* browser_ptr = &browser();Amelie Schneider . unresolved
Why can't we pass this directly? The browser shouldn't be affected by the widget closing, no?
Related details
Attention is currently required from:
- David Roger
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Roger (Gerrit)
5:07 AM (2 hours ago) 5:07 AM
to Amelie Schneider, Chromium LUCI CQ, chromium...@chromium.org
David Roger voted and added 1 comment![]( "Open in Gerrit")
Votes added by David Roger
| Commit-Queue | +2 |
1 comment
File chrome/browser/ui/views/profiles/profile_menu_view.cc
Line 372, Patchset 1 (Latest):
Browser* browser_ptr = &browser();Amelie Schneider . resolved
Why can't we pass this directly? The browser shouldn't be affected by the widget closing, no?
David Roger
We can, but I was concerned that closing the menu would destroy `this`, and then it is not safe to call `browser()` (UaF). In practice it seems that `CloseWithReason()` is in fact asynchronous, but I don't know if it's guaranteed to remain that way. To be extra sure I preferred copying the pointer on the stack.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:12 AM (2 hours ago) 5:12 AM
to David Roger, Amelie Schneider, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Views] Close profile menu prior to showing sync passphrase dialog
When the sync error button is clicked and a passphrase is needed, a
synchronous modal dialog is spawned. However, the profile menu bubble
Widget was not closed before launching it. On certain platforms like
Linux Wayland, this caused the profile menu to remain in focus or on
top, resulting in the passphrase dialog being uninteractible.
This change explicitly closes the profile menu widget first so that
the sync passphrase dialog can acquire the correct window focus.
TAG=agy
CONV=45a0a20c-3d44-4fb4-946a-a967172bb529
Bug: b:507949003
Test: Compiled chrome and browser_tests successfully
Change-Id: Ie49fb3cbe7669471110ffc075eba6b38e013c667
Commit-Queue: David Roger <dro...@chromium.org>
Reviewed-by: Amelie Schneider <ame...@google.com>
Cr-Commit-Position: refs/heads/main@{#1667728}
Files:
- M chrome/browser/ui/views/profiles/profile_menu_view.cc
Change size: XS
Delta: 1 file changed, 5 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Amelie Schneider
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages