Fix menu button focus outline disappearing on hover [chromium/src : main]
0 views
Skip to first unread message
Ben Chin (Gerrit)
12:23 AM (4 hours ago) 12:23 AM
to chromium...@chromium.org
Ben Chin has uploaded the change for review![]( "Open in Gerrit")
Commit message
Fix menu button focus outline disappearing on hover
Previously, menu_button_background_selector.xml used a single
StateListDrawable (<selector>) to manage all interaction states. Because
the state_hovered item was defined above the state_focused item,
hovering over an already-focused menu button would cause the selector to
match the hovered state first, replacing the focus outline ring with the
solid hover background.
This CL fixes the issue by wrapping the selectors in a <layer-list>.
The solid background overlays (hovered, pressed) are now handled
independently on a lower layer, while the focus ring outline is
handled on a higher layer. This ensures the focus ring remains
visible even when the icon is simultaneously being hovered or pressed.
Bug: 487866187
Change-Id: I378652cc92322b5b069b04e0f55b3d3a00c925d2
Change diff
Change information
Files:
- M chrome/android/java/res/drawable/menu_button_background_selector.xml
Change size: M
Delta: 1 file changed, 32 insertions(+), 24 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Chin (Gerrit)
12:25 AM (4 hours ago) 12:25 AM
to Sky Malice, chromium...@chromium.org
Attention needed from Sky Malice
Ben Chin voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages