net/disk_cache/sql: Store resource URL in CacheEntryKey [chromium/src : main]
Tsuyoshi Horo (Gerrit)
Tsuyoshi Horo added 1 comment![]( "Open in Gerrit")
Related details
- Mingyu Lei
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingyu Lei (Gerrit)
Mingyu Lei voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mingyu Lei
| Code-Review | +1 |
1 comment
const std::string resource_url;this comes from the AI suggestion and I found it quite meaningful: The `resource_url` is part of the `key` so we actually store the duplicate string twice here. It would be an optimization to store the resource_url as an offset into the `key` string.
Related details
- Tsuyoshi Horo
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
Tsuyoshi Horo voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tsuyoshi Horo
| Commit-Queue | +2 |
1 comment
const std::string resource_url;this comes from the AI suggestion and I found it quite meaningful: The `resource_url` is part of the `key` so we actually store the duplicate string twice here. It would be an optimization to store the resource_url as an offset into the `key` string.
Ah, good point. I will create another CL to do so as it requires changes in net/http/http_cache.h/cc.
Temporary marking as resolved to land this.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tsuyoshi Horo (Gerrit)
Tsuyoshi Horo added 1 comment![]( "Open in Gerrit")
const std::string resource_url;Tsuyoshi Horothis comes from the AI suggestion and I found it quite meaningful: The `resource_url` is part of the `key` so we actually store the duplicate string twice here. It would be an optimization to store the resource_url as an offset into the `key` string.
Ah, good point. I will create another CL to do so as it requires changes in net/http/http_cache.h/cc.
Temporary marking as resolved to land this.
Created https://crrev.com/c/7961760.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
net/disk_cache/sql: Store resource URL in CacheEntryKey
Extend CacheEntryKey to extract and store the resource URL and its
PersistentHash when the kRendererAccessibleHttpCache feature is enabled.
Calling resource_url() or resource_url_hash() requires the feature to be
enabled (enforced via CHECK). Also adds strong alias
SqlSharedCacheUrlHash.
- M net/disk_cache/sql/cache_entry_key.cc
- M net/disk_cache/sql/cache_entry_key.h
- M net/disk_cache/sql/cache_entry_key_unittest.cc
- M net/disk_cache/sql/sql_backend_aliases.h
Code-Review: +1 by Mingyu Lei
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |