Revert "[iOS][mvt-customization] Enable feature in fieldtrial testing" [chromium/src : main]
0 views
Skip to first unread message
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Jan 9, 2026, 1:50:29 PM (yesterday) Jan 9
to Chromium LUCI CQ, Ginny Huang, Gauthier Ambard, AyeAye, chromium...@chromium.org, Chromium Metrics Reviews
Attention needed from Gauthier Ambard and Ginny Huang
luci-bi...@appspot.gserviceaccount.com has uploaded the change for review![]( "Open in Gerrit")
luci-bi...@appspot.gserviceaccount.com would like Chromium LUCI CQ, Ginny Huang and Gauthier Ambard to review this change.
Commit message
Revert "[iOS][mvt-customization] Enable feature in fieldtrial testing"
This reverts commit ecd7b95b46e830ef7fdf441bb22faaa99b95e670.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5694254031568896
Sample build with failed test: https://ci.chromium.org/b/8693134194443577585
Affected test(s):
[://ios/chrome/test/earl_grey2\:ios_chrome_integration_eg2tests_module!xctest::NTPHomeTestCase#testMinimumHeight](https://ci.chromium.org/ui/test/chromium/:%2F%2Fios%2Fchrome%2Ftest%2Fearl_grey2%5C:ios_chrome_integration_eg2tests_module%21xctest::NTPHomeTestCase%23testMinimumHeight?q=VHash%3A727e62cef89dd85f)
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5694254031568896&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7408734&type=BUG
Original change's description:
> [iOS][mvt-customization] Enable feature in fieldtrial testing
>
> Also fixes the bug where the NTP returns to a different offset from the
> saved offset after navigating back.
>
> Bug: N/A
> Change-Id: I7a3805ba8f7547eac29f4c42bb56deff04e0aeac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7408734
> Commit-Queue: Ginny Huang <ginny...@chromium.org>
> Reviewed-by: Gauthier Ambard <gam...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1566965}
>
Bug: N/A
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Iaccf367092a9213597ce308e704b94171eb64c50
Change diff
Change information
Files:
- M ios/chrome/browser/content_suggestions/test/content_suggestions_egtest.mm
- M ios/chrome/browser/ntp/ui_bundled/new_tab_page_coordinator.mm
- M ios/chrome/browser/omnibox/eg_tests/BUILD.gn
- M ios/chrome/browser/omnibox/eg_tests/omnibox_popup_carousel_egtest.mm
- M testing/variations/fieldtrial_testing_config.json
Change size: S
Delta: 5 files changed, 3 insertions(+), 31 deletions(-)
Related details
Attention is currently required from:
- Gauthier Ambard
- Ginny Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Jan 9, 2026, 1:50:46 PM (yesterday) Jan 9
to Rubber Stamper, Chromium LUCI CQ, Ginny Huang, Gauthier Ambard, AyeAye, chromium...@chromium.org, Chromium Metrics Reviews, iwe...@google.com, awi...@google.com, marq+...@chromium.org, ios-revie...@chromium.org, christia...@chromium.org, thegreenf...@chromium.org, ios-r...@chromium.org, asvitkine...@chromium.org
Attention needed from Gauthier Ambard and Ginny Huang
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.
Related details
Attention is currently required from:
- Gauthier Ambard
- Ginny Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Jan 9, 2026, 1:51:28 PM (yesterday) Jan 9
to luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Ginny Huang, Gauthier Ambard, AyeAye, chromium...@chromium.org, Chromium Metrics Reviews, iwe...@google.com, awi...@google.com, marq+...@chromium.org, ios-revie...@chromium.org, christia...@chromium.org, thegreenf...@chromium.org, ios-r...@chromium.org, asvitkine...@chromium.org
Attention needed from Gauthier Ambard and Ginny Huang
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Gauthier Ambard
- Ginny Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Wells (Gerrit)
Jan 9, 2026, 1:52:14 PM (yesterday) Jan 9
to luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, Chromium LUCI CQ, Ginny Huang, Gauthier Ambard, AyeAye, chromium...@chromium.org, Chromium Metrics Reviews, iwe...@google.com, awi...@google.com, marq+...@chromium.org, ios-revie...@chromium.org, christia...@chromium.org, thegreenf...@chromium.org, ios-r...@chromium.org, asvitkine...@chromium.org
Attention needed from Gauthier Ambard and Ginny Huang
Ian Wells voted Owners-Override+1![]( "Open in Gerrit")
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Gauthier Ambard
- Ginny Huang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
Jan 9, 2026, 9:57:21 PM (18 hours ago) Jan 9
to luci-bi...@appspot.gserviceaccount.com, Ian Wells, Rubber Stamper, Chromium LUCI CQ, Gauthier Ambard, AyeAye, chromium...@chromium.org, Chromium Metrics Reviews, iwe...@google.com, awi...@google.com, marq+...@chromium.org, ios-revie...@chromium.org, christia...@chromium.org, thegreenf...@chromium.org, ios-r...@chromium.org, asvitkine...@chromium.org
Attention needed from Gauthier Ambard
Ginny Huang voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 9:57:32 PM (18 hours ago) Jan 9
to luci-bi...@appspot.gserviceaccount.com, Ginny Huang, Ian Wells, Rubber Stamper, Gauthier Ambard, AyeAye, chromium...@chromium.org, Chromium Metrics Reviews, iwe...@google.com, awi...@google.com, marq+...@chromium.org, ios-revie...@chromium.org, christia...@chromium.org, thegreenf...@chromium.org, ios-r...@chromium.org, asvitkine...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[iOS][mvt-customization] Enable feature in fieldtrial testing"
This reverts commit ecd7b95b46e830ef7fdf441bb22faaa99b95e670.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5694254031568896
Sample build with failed test: https://ci.chromium.org/b/8693134194443577585
Affected test(s):
[://ios/chrome/test/earl_grey2\:ios_chrome_integration_eg2tests_module!xctest::NTPHomeTestCase#testMinimumHeight](https://ci.chromium.org/ui/test/chromium/:%2F%2Fios%2Fchrome%2Ftest%2Fearl_grey2%5C:ios_chrome_integration_eg2tests_module%21xctest::NTPHomeTestCase%23testMinimumHeight?q=VHash%3A727e62cef89dd85f)
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5694254031568896&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7408734&type=BUG
Original change's description:
> [iOS][mvt-customization] Enable feature in fieldtrial testing
>
> Also fixes the bug where the NTP returns to a different offset from the
> saved offset after navigating back.
>
> Bug: N/A
> Change-Id: I7a3805ba8f7547eac29f4c42bb56deff04e0aeac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7408734
> Commit-Queue: Ginny Huang <ginny...@chromium.org>
> Reviewed-by: Gauthier Ambard <gam...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1566965}
>
Bug: N/A
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Iaccf367092a9213597ce308e704b94171eb64c50
Commit-Queue: Ginny Huang <ginny...@chromium.org>
Owners-Override: Ian Wells <iwe...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1567333}
Files:
- M ios/chrome/browser/content_suggestions/test/content_suggestions_egtest.mm
- M ios/chrome/browser/ntp/ui_bundled/new_tab_page_coordinator.mm
- M ios/chrome/browser/omnibox/eg_tests/BUILD.gn
- M ios/chrome/browser/omnibox/eg_tests/omnibox_popup_carousel_egtest.mm
- M testing/variations/fieldtrial_testing_config.json
Change size: S
Delta: 5 files changed, 3 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages