file_manager: Decouple VolumeManager from g_browser_process [chromium/src : main]
0 views
Skip to first unread message
Jun Ishiguro (Gerrit)
5:19 AM (7 hours ago) 5:19 AM
to Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, cbe-cep-eng...@google.com, chromium-a...@chromium.org, cros-enterpris...@chromium.org, crost...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, tote-eng...@google.com
Jun Ishiguro added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
8:14 AM (4 hours ago) 8:14 AM
to Jun Ishiguro, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, cbe-cep-eng...@google.com, chromium-a...@chromium.org, cros-enterpris...@chromium.org, crost...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, tote-eng...@google.com
Attention needed from Jun Ishiguro
Hidehiko Abe voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jun Ishiguro
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jun Ishiguro (Gerrit)
9:40 AM (3 hours ago) 9:40 AM
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, cbe-cep-eng...@google.com, chromium-a...@chromium.org, cros-enterpris...@chromium.org, crost...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, tote-eng...@google.com
Jun Ishiguro voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:46 AM (2 hours ago) 9:46 AM
to Jun Ishiguro, Hidehiko Abe, chromium...@chromium.org, Enterprise Policy Reviews, cbe-cep-eng...@google.com, chromium-a...@chromium.org, cros-enterpris...@chromium.org, crost...@chromium.org, extension...@chromium.org, filesapp...@chromium.org, rginda...@chromium.org, tote-eng...@google.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
file_manager: Decouple VolumeManager from g_browser_process
Replace direct access to g_browser_process->local_state() in
VolumeManager with explicit constructor dependency injection of
PrefService as the first parameter.
TAG=agy
Bug: b:404132053
Change-Id: I103360d0cfb984412262fb4f7123e25de06cedb0
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Commit-Queue: Jun Ishiguro <ju...@google.com>
Cr-Commit-Position: refs/heads/main@{#1658700}
Files:
- M chrome/browser/ash/app_list/search/files/file_result_unittest.cc
- M chrome/browser/ash/crostini/crostini_sshfs_unittest.cc
- M chrome/browser/ash/extensions/file_manager/event_router_unittest.cc
- M chrome/browser/ash/extensions/file_manager/system_notification_manager_unittest.cc
- M chrome/browser/ash/file_manager/DEPS
- M chrome/browser/ash/file_manager/copy_or_move_io_task_policy_unittest.cc
- M chrome/browser/ash/file_manager/copy_or_move_io_task_unittest.cc
- M chrome/browser/ash/file_manager/path_util_unittest.cc
- M chrome/browser/ash/file_manager/trash_unittest_base.cc
- M chrome/browser/ash/file_manager/volume_manager.cc
- M chrome/browser/ash/file_manager/volume_manager.h
- M chrome/browser/ash/file_manager/volume_manager_factory.cc
- M chrome/browser/ash/file_manager/volume_manager_unittest.cc
- M chrome/browser/ash/guest_os/guest_os_share_path_unittest.cc
- M chrome/browser/ash/guest_os/public/guest_os_mount_provider_unittest.cc
- M chrome/browser/ash/policy/dlp/files_policy_notification_manager_unittest.cc
- M chrome/browser/ash/policy/skyvault/local_files_migration_manager_unittest.cc
- M chrome/browser/ash/smb_client/smb_service_test_base.cc
- M chrome/browser/ash/smb_client/smbfs_share_unittest.cc
- M chrome/browser/enterprise/connectors/analysis/source_destination_matcher_ash_unittest.cc
- M chrome/browser/enterprise/connectors/analysis/source_destination_test_util.cc
- M chrome/browser/ui/ash/holding_space/holding_space_keyed_service_unittest.cc
Change size: S
Delta: 22 files changed, 35 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages