[iOS Blink][tvOS] Fix build break by adding crypto:test_support dependency [chromium/src : main]

0 views
Skip to first unread message

Gyuyoung Kim (Gerrit)

unread,
Jan 16, 2026, 1:48:28 AM (yesterday) Jan 16
to Dave Tapuska, Tom Sepez, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, chromium...@chromium.org, cobalt-...@google.com
Attention needed from Dave Tapuska and Tom Sepez

Gyuyoung Kim added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Gyuyoung Kim . resolved

tsepez@ and dtapuska@: PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id22d270c61c9007c4998fd7435fa8072bdf78ca8
Gerrit-Change-Number: 7487613
Gerrit-PatchSet: 1
Gerrit-Owner: Gyuyoung Kim <gyuy...@igalia.com>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
Gerrit-Comment-Date: Fri, 16 Jan 2026 06:48:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dave Tapuska (Gerrit)

unread,
Jan 16, 2026, 10:18:17 AM (yesterday) Jan 16
to Gyuyoung Kim, Chromium LUCI CQ, Tom Sepez, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, chromium...@chromium.org, cobalt-...@google.com
Attention needed from Gyuyoung Kim and Tom Sepez

Dave Tapuska voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Gyuyoung Kim
  • Tom Sepez
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id22d270c61c9007c4998fd7435fa8072bdf78ca8
    Gerrit-Change-Number: 7487613
    Gerrit-PatchSet: 2
    Gerrit-Owner: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
    Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Comment-Date: Fri, 16 Jan 2026 15:18:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gyuyoung Kim (Gerrit)

    unread,
    Jan 16, 2026, 10:42:49 AM (yesterday) Jan 16
    to Elly FJ, Dave Tapuska, Chromium LUCI CQ, Tom Sepez, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, chromium...@chromium.org, cobalt-...@google.com
    Attention needed from Elly FJ and Tom Sepez

    Gyuyoung Kim added 1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Gyuyoung Kim . resolved

    Add ellyjones@ to reviewers for the fast review.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Elly FJ
    • Tom Sepez
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id22d270c61c9007c4998fd7435fa8072bdf78ca8
    Gerrit-Change-Number: 7487613
    Gerrit-PatchSet: 2
    Gerrit-Owner: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
    Gerrit-Reviewer: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
    Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Elly FJ <elly...@chromium.org>
    Gerrit-Comment-Date: Fri, 16 Jan 2026 15:42:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tom Sepez (Gerrit)

    unread,
    Jan 16, 2026, 1:28:21 PM (yesterday) Jan 16
    to Gyuyoung Kim, Elly FJ, Dave Tapuska, Chromium LUCI CQ, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, chromium...@chromium.org, cobalt-...@google.com
    Attention needed from Elly FJ and Gyuyoung Kim

    Tom Sepez voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Elly FJ
    • Gyuyoung Kim
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id22d270c61c9007c4998fd7435fa8072bdf78ca8
    Gerrit-Change-Number: 7487613
    Gerrit-PatchSet: 2
    Gerrit-Owner: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
    Gerrit-Reviewer: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
    Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Elly FJ <elly...@chromium.org>
    Gerrit-Attention: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Comment-Date: Fri, 16 Jan 2026 18:28:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Gyuyoung Kim (Gerrit)

    unread,
    12:25 AM (14 hours ago) 12:25 AM
    to Tom Sepez, Elly FJ, Dave Tapuska, Chromium LUCI CQ, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, chromium...@chromium.org, cobalt-...@google.com
    Attention needed from Elly FJ

    Gyuyoung Kim voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Elly FJ
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id22d270c61c9007c4998fd7435fa8072bdf78ca8
    Gerrit-Change-Number: 7487613
    Gerrit-PatchSet: 2
    Gerrit-Owner: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
    Gerrit-Reviewer: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
    Gerrit-CC: Julie Jeongeun Kim <jk...@igalia.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Elly FJ <elly...@chromium.org>
    Gerrit-Comment-Date: Sat, 17 Jan 2026 05:25:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    12:37 AM (14 hours ago) 12:37 AM
    to Gyuyoung Kim, Tom Sepez, Elly FJ, Dave Tapuska, Raphael Kubo da Costa, Abhijeet Kandalkar, Julie Jeongeun Kim, chromium...@chromium.org, cobalt-...@google.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [iOS Blink][tvOS] Fix build break by adding crypto:test_support dependency

    After https://crrev.com/c/7414587 enabled
    crypto/apple/unexportable_key_mac.mm on iOS,
    authenticator_impl_unittest.cc requires headers from
    //crypto:test_support. This dependency was missing, causing build
    failures on iOS Blink and tvOS. Also, unexportable_key_apple.mm uses
    LAContext, which is not available on tvOS. Thus, this CL disables the
    files on tvOS.
    Bug: 432304211
    Change-Id: Id22d270c61c9007c4998fd7435fa8072bdf78ca8
    Reviewed-by: Tom Sepez <tse...@chromium.org>
    Reviewed-by: Dave Tapuska <dtap...@chromium.org>
    Commit-Queue: Gyuyoung Kim <gyuy...@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#1570746}
    Files:
    • M content/test/BUILD.gn
    • M crypto/BUILD.gn
    • M crypto/unexportable_key.cc
    Change size: S
    Delta: 3 files changed, 17 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Tom Sepez, +1 by Dave Tapuska
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id22d270c61c9007c4998fd7435fa8072bdf78ca8
    Gerrit-Change-Number: 7487613
    Gerrit-PatchSet: 3
    Gerrit-Owner: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
    Gerrit-Reviewer: Gyuyoung Kim <gyuy...@igalia.com>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Abhijeet Kandalkar <abhi...@igalia.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages