[iOS] Add Workaround Bottom Padding For AI Hub for iOS 26 [chromium/src : main]
0 views
Skip to first unread message
Adam Arcaro (Gerrit)
Sep 4, 2025, 8:32:56 PM (2 days ago) Sep 4
to Joemer Ramos, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Joemer Ramos
Adam Arcaro voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Arcaro
| Code-Review | +1 |
1 comment
File ios/chrome/browser/intelligence/page_action_menu/coordinator/page_action_menu_coordinator.mm
Line 32, Patchset 9 (Latest):
const CGFloat kMenuCornerRadius = 28;Adam Arcaro . unresolved
Can you please guard this change with the iOS 26 build flag too?
Related details
Attention is currently required from:
- Joemer Ramos
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joemer Ramos (Gerrit)
Sep 4, 2025, 9:06:10 PM (2 days ago) Sep 4
to Joemer Ramos, Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Joemer Ramos voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joemer Ramos
| Commit-Queue | +2 |
1 comment
File ios/chrome/browser/intelligence/page_action_menu/coordinator/page_action_menu_coordinator.mm
Can you please guard this change with the iOS 26 build flag too?
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 4, 2025, 10:01:36 PM (2 days ago) Sep 4
to Joemer Ramos, Adam Arcaro, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
9 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ios/chrome/browser/intelligence/page_action_menu/coordinator/page_action_menu_coordinator.mm
Insertions: 4, Deletions: 0.
@@ -29,7 +29,11 @@
namespace {
+#if defined(__IPHONE_26_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_26_0
const CGFloat kMenuCornerRadius = 28;
+#else
+const CGFloat kMenuCornerRadius = 20;
+#endif
}
@interface PageActionMenuCoordinator () <
```
Change information
Commit message:
[iOS] Add Workaround Bottom Padding For AI Hub for iOS 26
On an iOS 26 device, there is no bottom padding. This CL adjusts the
bottom padding to avoid this UI bug.
UI Screenshot: crbug.com/441278010#comment5
Bug: 441278010
Change-Id: I0876189644b1f2fb6214f79ec7eb51a188b509d1
Reviewed-by: Adam Arcaro <ada...@google.com>
Commit-Queue: Joemer Ramos <joeme...@google.com>
Cr-Commit-Position: refs/heads/main@{#1511273}
Files:
- M ios/chrome/browser/intelligence/page_action_menu/coordinator/page_action_menu_coordinator.mm
- M ios/chrome/browser/intelligence/page_action_menu/ui/page_action_menu_view_controller.mm
Change size: XS
Delta: 2 files changed, 8 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Adam Arcaro
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages