net: Retry HTTP/1.0 requests on ERR_SOCKET_NOT_CONNECTED net: Retry HTTP/1.0 requests on ERR_SOCKET_NOT_CONNECTED [chromium/src : main]

1 view
Skip to first unread message

NISCHAL SINGH (Gerrit)

unread,
1:28 AM (16 hours ago) 1:28 AM
to David Schinazi, Peter Conn, chromium...@chromium.org, net-r...@chromium.org
Attention needed from David Schinazi, Peter Conn and mmenke

NISCHAL SINGH added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
NISCHAL SINGH . resolved

hey there adding you as owner since you understand net stack properly and here is a small bug fix with test case

Open in Gerrit

Related details

Attention is currently required from:
  • David Schinazi
  • Peter Conn
  • mmenke
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I74ccb7c03695115924d48a82b84d681690fe5096
Gerrit-Change-Number: 7414403
Gerrit-PatchSet: 1
Gerrit-Owner: NISCHAL SINGH <singhni...@gmail.com>
Gerrit-Reviewer: David Schinazi <dsch...@chromium.org>
Gerrit-Reviewer: Peter Conn <pec...@chromium.org>
Gerrit-Reviewer: mmenke <mme...@chromium.org>
Gerrit-Attention: mmenke <mme...@chromium.org>
Gerrit-Attention: Peter Conn <pec...@chromium.org>
Gerrit-Attention: David Schinazi <dsch...@chromium.org>
Gerrit-Comment-Date: Sun, 11 Jan 2026 06:28:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

mmenke (Gerrit)

unread,
12:30 PM (5 hours ago) 12:30 PM
to NISCHAL SINGH, David Schinazi, Peter Conn, chromium...@chromium.org, net-r...@chromium.org
Attention needed from David Schinazi, NISCHAL SINGH and Peter Conn

mmenke voted and added 1 comment

Votes added by mmenke

Code-Review-1

1 comment

Patchset-level comments
mmenke . resolved

Per discussion on the bug, this seems to be making us retry when the server immediately hung up on a fresh connection. I could be missing something, but I'm going to go ahead and -1 this for now. Happy to talk more here, or on the bug itself.

Open in Gerrit

Related details

Attention is currently required from:
  • David Schinazi
  • NISCHAL SINGH
  • Peter Conn
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is blockingCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I74ccb7c03695115924d48a82b84d681690fe5096
    Gerrit-Change-Number: 7414403
    Gerrit-PatchSet: 1
    Gerrit-Owner: NISCHAL SINGH <singhni...@gmail.com>
    Gerrit-Reviewer: David Schinazi <dsch...@chromium.org>
    Gerrit-Reviewer: Peter Conn <pec...@chromium.org>
    Gerrit-Reviewer: mmenke <mme...@chromium.org>
    Gerrit-Attention: NISCHAL SINGH <singhni...@gmail.com>
    Gerrit-Attention: Peter Conn <pec...@chromium.org>
    Gerrit-Attention: David Schinazi <dsch...@chromium.org>
    Gerrit-Comment-Date: Sun, 11 Jan 2026 17:30:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    blocking_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages