net: Retry HTTP/1.0 requests on ERR_SOCKET_NOT_CONNECTED net: Retry HTTP/1.0 requests on ERR_SOCKET_NOT_CONNECTED [chromium/src : main]

1 view

Skip to first unread message

NISCHAL SINGH (Gerrit)

unread,

1:28 AM (16 hours ago) 1:28 AM

to David Schinazi, Peter Conn, chromium...@chromium.org, net-r...@chromium.org

Attention needed from David Schinazi, Peter Conn and mmenke

NISCHAL SINGH added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

NISCHAL SINGH . resolved

hey there adding you as owner since you understand net stack properly and here is a small bug fix with test case

Open in Gerrit

Related details

Attention is currently required from:

David Schinazi
Peter Conn
mmenke

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

mmenke (Gerrit)

unread,

12:30 PM (5 hours ago) 12:30 PM

to NISCHAL SINGH, David Schinazi, Peter Conn, chromium...@chromium.org, net-r...@chromium.org

Attention needed from David Schinazi, NISCHAL SINGH and Peter Conn

mmenke voted and added 1 comment

Votes added by mmenke

Code-Review

-1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

mmenke . resolved

Per discussion on the bug, this seems to be making us retry when the server immediately hung up on a fresh connection. I could be missing something, but I'm going to go ahead and -1 this for now. Happy to talk more here, or on the bug itself.

Open in Gerrit

Related details

Attention is currently required from:

David Schinazi
NISCHAL SINGH
Peter Conn

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

blocking_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages