Revert "Disable CreateNetworkContextNonBlocking field trial." [chromium/src : main]

0 views
Skip to first unread message

Tsuyoshi Horo (Gerrit)

unread,
Jun 17, 2026, 11:58:08 PM (8 days ago) Jun 17
to Chromium LUCI CQ, Mohamed Amir Yosef, chromium...@chromium.org, Chromium Metrics Reviews
Attention needed from Mohamed Amir Yosef

Tsuyoshi Horo has uploaded the change for review

Tsuyoshi Horo would like Chromium LUCI CQ and Mohamed Amir Yosef to review this change.

Commit message

Revert "Disable CreateNetworkContextNonBlocking field trial."

This reverts commit 1c851055596f91d03886dde8fcc0c5563f713b87.

Reason for revert: This speculative change didn't have any impact on the flaky Linux debug bots.


Original change's description:
> Disable CreateNetworkContextNonBlocking field trial.
>
> This feature seems to be causing widespread timeouts in browser tests
> and sync integration tests on Linux dbg bots. Disabling it to restore
> tree health.
>
> R=ho...@chromium.org
>
> TAG=agy
> CONV=19ca263f-4840-4168-b773-c3e27267ba88
>
> Bug: 519867149
> Change-Id: I6ed377bd4b7b8597139b4f1bfeb370908db62763
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7922850
> Reviewed-by: Tsuyoshi Horo <ho...@chromium.org>
> Commit-Queue: Mohamed Amir Yosef <ma...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1645944}
Bug: 519867149
Change-Id: I9b3570360f3b73d942fe1cfd0dfebe0e296f7891

Change diff

diff --git a/testing/variations/fieldtrial_testing_config.json b/testing/variations/fieldtrial_testing_config.json
index 0b2b613..316513e 100644
--- a/testing/variations/fieldtrial_testing_config.json
+++ b/testing/variations/fieldtrial_testing_config.json
@@ -7818,6 +7818,24 @@
]
}
],
+ "CreateNetworkContextNonBlocking": [
+ {
+ "platforms": [
+ "chromeos",
+ "linux",
+ "mac",
+ "windows"
+ ],
+ "experiments": [
+ {
+ "name": "Enabled",
+ "enable_features": [
+ "CreateNetworkContextNonBlocking"
+ ]
+ }
+ ]
+ }
+ ],
"CredentialManagementUnifiedUi": [
{
"platforms": [

Change information

Files:
  • M testing/variations/fieldtrial_testing_config.json
Change size: S
Delta: 1 file changed, 18 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Mohamed Amir Yosef
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9b3570360f3b73d942fe1cfd0dfebe0e296f7891
Gerrit-Change-Number: 7961277
Gerrit-PatchSet: 1
Gerrit-Owner: Tsuyoshi Horo <ho...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Mohamed Amir Yosef <ma...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

rubber-stamper@appspot.gserviceaccount.com (Gerrit)

unread,
Jun 17, 2026, 11:59:30 PM (8 days ago) Jun 17
to Tsuyoshi Horo, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Mohamed Amir Yosef, chromium...@chromium.org, Chromium Metrics Reviews, asvitkine...@chromium.org
Attention needed from Mohamed Amir Yosef

Related details

Attention is currently required from:
  • Mohamed Amir Yosef
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b3570360f3b73d942fe1cfd0dfebe0e296f7891
    Gerrit-Change-Number: 7961277
    Gerrit-PatchSet: 1
    Gerrit-Owner: Tsuyoshi Horo <ho...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Mohamed Amir Yosef <ma...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Jun 2026 03:59:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Tsuyoshi Horo (Gerrit)

    unread,
    Jun 18, 2026, 12:00:55 AM (8 days ago) Jun 18
    to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Mohamed Amir Yosef, chromium...@chromium.org, Chromium Metrics Reviews, asvitkine...@chromium.org
    Attention needed from Mohamed Amir Yosef

    Tsuyoshi Horo voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mohamed Amir Yosef
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b3570360f3b73d942fe1cfd0dfebe0e296f7891
    Gerrit-Change-Number: 7961277
    Gerrit-PatchSet: 1
    Gerrit-Owner: Tsuyoshi Horo <ho...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mohamed Amir Yosef <ma...@chromium.org>
    Gerrit-Reviewer: Tsuyoshi Horo <ho...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Jun 2026 04:00:20 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 18, 2026, 12:57:13 AM (8 days ago) Jun 18
    to Tsuyoshi Horo, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Mohamed Amir Yosef, chromium...@chromium.org, Chromium Metrics Reviews, asvitkine...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "Disable CreateNetworkContextNonBlocking field trial."

    This reverts commit 1c851055596f91d03886dde8fcc0c5563f713b87.

    Reason for revert: This speculative change didn't have any impact on the flaky Linux debug bots.


    Original change's description:
    > Disable CreateNetworkContextNonBlocking field trial.
    >
    > This feature seems to be causing widespread timeouts in browser tests
    > and sync integration tests on Linux dbg bots. Disabling it to restore
    > tree health.
    >
    > R=ho...@chromium.org
    >
    > TAG=agy
    > CONV=19ca263f-4840-4168-b773-c3e27267ba88
    >
    > Bug: 519867149
    > Change-Id: I6ed377bd4b7b8597139b4f1bfeb370908db62763
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7922850
    > Reviewed-by: Tsuyoshi Horo <ho...@chromium.org>
    > Commit-Queue: Mohamed Amir Yosef <ma...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1645944}
    Bug: 519867149
    Change-Id: I9b3570360f3b73d942fe1cfd0dfebe0e296f7891
    Files:
    • M testing/variations/fieldtrial_testing_config.json
    Change size: S
    Delta: 1 file changed, 18 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b3570360f3b73d942fe1cfd0dfebe0e296f7891
    Gerrit-Change-Number: 7961277
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages