[Gardener AI] Add UI Change for description [infra/luci/luci-go : main]
0 views
Skip to first unread message
Xiang Ji (Gerrit)
Oct 14, 2025, 5:10:55 PM (6 days ago) Oct 14
to Jiamei Liu, Jyothi Mathew, LUCI CQ, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
Attention needed from Jiamei Liu and Jyothi Mathew
Xiang Ji added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Xiang Ji . unresolved
Could you add a screenshot in the CL description so the UI could be also reviewed?
Related details
Attention is currently required from:
- Jiamei Liu
- Jyothi Mathew
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jiamei Liu (Gerrit)
Oct 14, 2025, 5:46:37 PM (6 days ago) Oct 14
to Xiang Ji, Jyothi Mathew, LUCI CQ, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
Attention needed from Jyothi Mathew and Xiang Ji
Jiamei Liu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jiamei Liu
| Commit-Queue | +1 |
Could you add a screenshot in the CL description so the UI could be also reviewed?
Jiamei Liu
SG, one thing, if i render it locally the justification field is blank, could it be bc that genai.pb.ts is not yet submitted? https://screenshot.googleplex.com/54ep23ju4wxNtxs
Related details
Attention is currently required from:
- Jyothi Mathew
- Xiang Ji
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiang Ji (Gerrit)
Oct 14, 2025, 5:48:49 PM (6 days ago) Oct 14
to Jiamei Liu, Jyothi Mathew, LUCI CQ, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
Attention needed from Jiamei Liu and Jyothi Mathew
Xiang Ji voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jiamei Liu
- Jyothi Mathew
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jyothi Mathew (Gerrit)
Oct 14, 2025, 6:35:23 PM (6 days ago) Oct 14
to Jiamei Liu, Matthew Warton, Xiang Ji, LUCI CQ, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
Attention needed from Jiamei Liu and Matthew Warton
Jyothi Mathew added 1 comment![]( "Open in Gerrit")
File milo/ui/src/bisection/components/gen_ai_analysis_table/gen_ai_analysis_table.tsx
Line 92, Patchset 4 (Latest):
<TableCell>{suspect.justification}</TableCell>Jyothi Mathew . unresolved
Do you have a screenshot of this with a text of the max 512 chars? If the columns don't look good at the max length, maybe it should be on the next row(occupying the whole length of the row).
Related details
Attention is currently required from:
- Jiamei Liu
- Matthew Warton
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthew Warton (Gerrit)
Oct 14, 2025, 9:55:13 PM (6 days ago) Oct 14
to Jiamei Liu, Xiang Ji, Jyothi Mathew, LUCI CQ, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
Attention needed from Jiamei Liu
Matthew Warton added 1 comment![]( "Open in Gerrit")
File milo/ui/src/bisection/components/gen_ai_analysis_table/gen_ai_analysis_table.tsx
Line 92, Patchset 4 (Latest):
<TableCell>{suspect.justification}</TableCell>Jyothi Mathew . unresolved
Do you have a screenshot of this with a text of the max 512 chars? If the columns don't look good at the max length, maybe it should be on the next row(occupying the whole length of the row).
Matthew Warton
Alternatively you could show the justification in a tooltip or a dialog, e.g the more info button on this page: https://ci.chromium.org/ui/tests/p/chromium/rules/b5089209e9b3c512f5f7e571b1bce977?annotated=false&historyTimeRange=30d&selectedMetrics=human-cls-failed-presubmit%2Ccritical-failures-exonerated%2Cfailures%2Cbuilds-failed-due-to-flaky-tests&tab=exonerations
Related details
Attention is currently required from:
- Jiamei Liu
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jiamei Liu (Gerrit)
Oct 15, 2025, 7:43:52 PM (5 days ago) Oct 15
to Matthew Warton, Xiang Ji, Jyothi Mathew, LUCI CQ, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
Attention needed from Jyothi Mathew, Matthew Warton and Xiang Ji
Jiamei Liu added 1 comment![]( "Open in Gerrit")
File milo/ui/src/bisection/components/gen_ai_analysis_table/gen_ai_analysis_table.tsx
Do you have a screenshot of this with a text of the max 512 chars? If the columns don't look good at the max length, maybe it should be on the next row(occupying the whole length of the row).
Jiamei Liu
Discussed with the team offline, we'll be adding a new row for justification below the existing row, example: https://screenshot.googleplex.com/6zHpxveQ7Sh3L7f so that the text are not wrapped.
Related details
Attention is currently required from:
- Jyothi Mathew
- Matthew Warton
- Xiang Ji
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jyothi Mathew (Gerrit)
Oct 16, 2025, 12:07:24 PM (4 days ago) Oct 16
to Jiamei Liu, Matthew Warton, Xiang Ji, LUCI CQ, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
Attention needed from Jiamei Liu, Matthew Warton and Xiang Ji
Jyothi Mathew voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jiamei Liu
- Matthew Warton
- Xiang Ji
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthew Warton (Gerrit)
Oct 19, 2025, 5:14:50 PM (yesterday) Oct 19
to Jiamei Liu, Jyothi Mathew, Xiang Ji, LUCI CQ, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
Attention needed from Jiamei Liu and Xiang Ji
Matthew Warton voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matthew Warton
| Code-Review | +1 |
1 comment
File milo/ui/src/bisection/components/gen_ai_analysis_table/gen_ai_analysis_table.tsx
Line 73, Patchset 7 (Latest):
<TableCell sx={{ whiteSpace: 'nowrap' }}>Suspect CL</TableCell>Matthew Warton . unresolved
Why set all of these to nowrap?
Related details
Attention is currently required from:
- Jiamei Liu
- Xiang Ji
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jiamei Liu (Gerrit)
3:56 PM (4 hours ago) 3:56 PM
to Matthew Warton, Jyothi Mathew, Xiang Ji, LUCI CQ, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
Attention needed from Xiang Ji
Jiamei Liu added 1 comment![]( "Open in Gerrit")
File milo/ui/src/bisection/components/gen_ai_analysis_table/gen_ai_analysis_table.tsx
Line 73, Patchset 7 (Latest):
<TableCell sx={{ whiteSpace: 'nowrap' }}>Suspect CL</TableCell>Matthew Warton . resolved
Why set all of these to nowrap?
Jiamei Liu
Cause we don't want those text to wrap - incase that the suspect cl msg is to long
Related details
Attention is currently required from:
- Xiang Ji
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jiamei Liu (Gerrit)
3:56 PM (4 hours ago) 3:56 PM
to Matthew Warton, Jyothi Mathew, Xiang Ji, LUCI CQ, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
Attention needed from Xiang Ji
Jiamei Liu voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Xiang Ji
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
LUCI CQ (Gerrit)
4:21 PM (4 hours ago) 4:21 PM
to Jiamei Liu, Matthew Warton, Jyothi Mathew, Xiang Ji, chromium...@chromium.org, chops-tfs-t...@google.com, infra-revi...@chromium.org
LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Gardener AI] Add UI Change for description
The description will be add here:
https://screenshot.googleplex.com/6zHpxveQ7Sh3L7f
Change-Id: I9de35ed9e45572a1fa173682294a6e2f4ba63e02
Bug: 445562638
Commit-Queue: Jiamei Liu <jia...@google.com>
Reviewed-by: Jyothi Mathew <jyom...@google.com>
Reviewed-by: Xiang Ji <jxi...@google.com>
Reviewed-by: Matthew Warton <mwa...@google.com>
Files:
- M milo/ui/src/bisection/components/gen_ai_analysis_table/gen_ai_analysis_table.test.tsx
- M milo/ui/src/bisection/components/gen_ai_analysis_table/gen_ai_analysis_table.tsx
- M milo/ui/src/bisection/testing_tools/mocks/gen_ai_suspect_mocks.ts
Change size: S
Delta: 3 files changed, 21 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jyothi Mathew, +1 by Xiang Ji, +1 by Matthew Warton
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages