Replace Profile with BrowserContext in chrome/browser/chromeos/cros_apps [chromium/src : main]

0 views
Skip to first unread message

Mitsuru Oshima (Gerrit)

unread,
Mar 21, 2026, 9:37:25 PM (2 days ago) Mar 21
to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org
Attention needed from Hidehiko Abe

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4effdb83089bef5fe35351b568f4fe7ccd3c79ef
Gerrit-Change-Number: 7686816
Gerrit-PatchSet: 3
Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Comment-Date: Sun, 22 Mar 2026 01:37:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Mar 22, 2026, 10:32:45 PM (13 hours ago) Mar 22
to Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org
Attention needed from Mitsuru Oshima

Hidehiko Abe voted and added 3 comments

Votes added by Hidehiko Abe

Code-Review+1

3 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Hidehiko Abe . resolved

LGTM

File chrome/browser/chromeos/cros_apps/api/cros_apps_api_frame_context.h
Line 51, Patchset 3 (Latest): // Returns the BrowserContext.
Hidehiko Abe . unresolved

nit: the comment looks redundant?

As you touch this, `GetBrowserContext` for consistency?

Line 21, Patchset 3 (Latest):}
Hidehiko Abe . unresolved

nit: `// namespace content` for consistency

Open in Gerrit

Related details

Attention is currently required from:
  • Mitsuru Oshima
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4effdb83089bef5fe35351b568f4fe7ccd3c79ef
    Gerrit-Change-Number: 7686816
    Gerrit-PatchSet: 3
    Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Comment-Date: Mon, 23 Mar 2026 02:32:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mitsuru Oshima (Gerrit)

    unread,
    9:28 AM (2 hours ago) 9:28 AM
    to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org

    Mitsuru Oshima added 2 comments

    File chrome/browser/chromeos/cros_apps/api/cros_apps_api_frame_context.h
    Line 51, Patchset 3: // Returns the BrowserContext.
    Hidehiko Abe . resolved

    nit: the comment looks redundant?

    As you touch this, `GetBrowserContext` for consistency?

    Mitsuru Oshima

    Done

    Line 21, Patchset 3:}
    Hidehiko Abe . resolved

    nit: `// namespace content` for consistency

    Mitsuru Oshima

    Donee (merged)

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4effdb83089bef5fe35351b568f4fe7ccd3c79ef
      Gerrit-Change-Number: 7686816
      Gerrit-PatchSet: 4
      Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Comment-Date: Mon, 23 Mar 2026 13:28:19 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
      satisfied_requirement
      open
      diffy

      Mitsuru Oshima (Gerrit)

      unread,
      9:28 AM (2 hours ago) 9:28 AM
      to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org

      Mitsuru Oshima voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4effdb83089bef5fe35351b568f4fe7ccd3c79ef
      Gerrit-Change-Number: 7686816
      Gerrit-PatchSet: 4
      Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Comment-Date: Mon, 23 Mar 2026 13:28:25 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      10:14 AM (2 hours ago) 10:14 AM
      to Mitsuru Oshima, Hidehiko Abe, chromium...@chromium.org, oshima...@chromium.org

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      3 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: chrome/browser/chromeos/cros_apps/api/cros_apps_api_frame_context.cc
      Insertions: 2, Deletions: 1.

      The diff is too large to show. Please review the diff.
      ```
      ```
      The name of the file: chrome/browser/chromeos/cros_apps/api/cros_apps_api_mutable_registry.cc
      Insertions: 1, Deletions: 1.

      The diff is too large to show. Please review the diff.
      ```
      ```
      The name of the file: chrome/browser/chromeos/cros_apps/api/cros_apps_api_frame_context.h
      Insertions: 2, Deletions: 6.

      The diff is too large to show. Please review the diff.
      ```

      Change information

      Commit message:
      Replace Profile with BrowserContext in chrome/browser/chromeos/cros_apps

      Bug: 372684192
      Change-Id: I4effdb83089bef5fe35351b568f4fe7ccd3c79ef
      Reviewed-by: Hidehiko Abe <hide...@chromium.org>
      Commit-Queue: Mitsuru Oshima <osh...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1603450}
      Files:
      • M chrome/browser/chromeos/cros_apps/BUILD.gn
      • M chrome/browser/chromeos/cros_apps/api/BUILD.gn
      • M chrome/browser/chromeos/cros_apps/api/cros_apps_api_frame_context.cc
      • M chrome/browser/chromeos/cros_apps/api/cros_apps_api_frame_context.h
      • M chrome/browser/chromeos/cros_apps/api/cros_apps_api_mutable_registry.cc
      • M chrome/browser/chromeos/cros_apps/api/cros_apps_api_mutable_registry.h
      • M chrome/browser/chromeos/cros_apps/api/cros_apps_api_registry.cc
      • M chrome/browser/chromeos/cros_apps/api/cros_apps_api_registry.h
      • M chrome/browser/chromeos/cros_apps/cros_apps_tab_helper.cc
      Change size: M
      Delta: 9 files changed, 41 insertions(+), 36 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Hidehiko Abe
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4effdb83089bef5fe35351b568f4fe7ccd3c79ef
      Gerrit-Change-Number: 7686816
      Gerrit-PatchSet: 5
      Gerrit-Owner: Mitsuru Oshima <osh...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
      Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages