Spanification of base/memory/ref_counted_memory.h, etc. [chromium/src : main]
0 views
Skip to first unread message
Daniel Angulo (Gerrit)
May 22, 2026, 4:38:39 PM (6 days ago) May 22
to android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Sadrul Chowdhury, gavinp...@chromium.org
Message from Daniel Angulo![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikihito Matsuura (Gerrit)
May 26, 2026, 12:44:46 AM (3 days ago) May 26
to Daniel Angulo, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Sadrul Chowdhury, gavinp...@chromium.org
Attention needed from Daniel Angulo
Mikihito Matsuura voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Daniel Angulo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
3:42 PM (1 hour ago) 3:42 PM
to Daniel Angulo, Dan Clark, Chromium LUCI CQ, Mikihito Matsuura, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Sadrul Chowdhury, gavinp...@chromium.org
Attention needed from Dan Clark and Daniel Angulo
Mark Mentovai added 4 comments![]( "Open in Gerrit")
File base/memory/ref_counted_memory.h
Line 61, Patchset 4 (Latest):
// The data/size members (or begin/end) give conversion to span already, but
// we provide this operator as an optimization to combine two virtual method
// calls into one.
explicit operator base::span<const uint8_t>() const LIFETIME_BOUND {
return AsSpan();
}Mark Mentovai . unresolved
Why are you promoting `AsSpan` out of `protected:` instead of using this?
File components/sync_bookmarks/bookmark_specifics_conversions.cc
Line 334, Patchset 4 (Latest):
const auto favicon_span = base::as_chars(favicon_bytes->AsSpan());Mark Mentovai . unresolved
I don’t think there’s a strong argument in favor of `auto` for this.
File ui/base/x/selection_owner.cc
Line 338, Patchset 4 (Latest):
base::ToVector(mem->AsSpan()));Mark Mentovai . unresolved
It seems like some of this’s internal span-accepting SetArrayPropertyImpl should be exposed, rather than forcing the creation of vectors when you’re already holding a span.
Line 351, Patchset 4 (Latest):
auto span = transfer->data->AsSpan().subspan(transfer->offset, chunk_length);Mark Mentovai . unresolved
Same.
Related details
Attention is currently required from:
- Dan Clark
- Daniel Angulo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages