[account_settings] Move account_settings to its own component [chromium/src : main]
0 views
Skip to first unread message
Marc Treib (Gerrit)
Mar 19, 2026, 7:17:15 AM (4 days ago) Mar 19
to Norge Vizcay, Marc Treib, Florian Leimgruber, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, droger+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Florian Leimgruber and Norge Vizcay
Marc Treib voted and added 6 comments![]( "Open in Gerrit")
Votes added by Marc Treib
| Code-Review | +1 |
6 comments
Commit Message
Line 11, Patchset 13 (Latest):
- Updated references in callers.Marc Treib . unresolved
Could you add some background on the "why"? I guess there are plans for using this outside of autofill?
File chrome/browser/autofill/account_setting_service_factory.h
Line 5, Patchset 13 (Latest):
#ifndef CHROME_BROWSER_AUTOFILL_ACCOUNT_SETTING_SERVICE_FACTORY_H_Marc Treib . unresolved
I guess this should also move out of the /autofill folder, but that can be another CL.
File components/account_settings/DEPS
Line 6, Patchset 13 (Latest):
"+components/keyed_service/core",
"+components/sync/model",
"+components/sync/base",Marc Treib . unresolved
nit: sort alphabetically
File ios/chrome/browser/autofill/model/DEPS
Line 2, Patchset 13 (Latest):
"+components/account_settings",Marc Treib . unresolved
nit: Move down into the keep-sorted block
File ios/chrome/browser/autofill/ui_bundled/DEPS
Line 2, Patchset 13 (Latest):
"+components/account_settings",Marc Treib . unresolved
Move into the keep-sorted block
File ios/chrome/browser/autofill/ui_bundled/chrome_autofill_client_ios.mm
Line 22, Patchset 13 (Latest):
#import "components/account_settings/account_setting_service.h"Marc Treib . unresolved
nit: Not used?
Related details
Attention is currently required from:
- Florian Leimgruber
- Norge Vizcay
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Florian Leimgruber (Gerrit)
Mar 19, 2026, 9:17:39 AM (4 days ago) Mar 19
to Norge Vizcay, Marc Treib, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, droger+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Norge Vizcay
Florian Leimgruber voted and added 1 comment![]( "Open in Gerrit")
Votes added by Florian Leimgruber
| Code-Review | +1 |
1 comment
Commit Message
Line 9, Patchset 13 (Latest):
- Moved account_settings from components/autofill/core/browser/webdata/account_settings/ to components/account_settings/.Florian Leimgruber . unresolved
Should there be an OWNERS file for this new component?
Related details
Attention is currently required from:
- Norge Vizcay
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
Mar 19, 2026, 9:21:39 AM (4 days ago) Mar 19
to Norge Vizcay, Florian Leimgruber, Marc Treib, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, droger+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Norge Vizcay
Marc Treib added 1 comment![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 13 (Latest):
- Moved account_settings from components/autofill/core/browser/webdata/account_settings/ to components/account_settings/.Florian Leimgruber . unresolved
Should there be an OWNERS file for this new component?
Marc Treib
Oh yes, there definitely should be! (I thought about this but then forgot to comment :-/)
Norge Vizcay (Gerrit)
Mar 19, 2026, 10:41:37 AM (4 days ago) Mar 19
to Florian Leimgruber, Marc Treib, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, droger+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Norge Vizcay added 7 comments![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 13:
- Moved account_settings from components/autofill/core/browser/webdata/account_settings/ to components/account_settings/.Florian Leimgruber . resolved
Marc TreibShould there be an OWNERS file for this new component?
Oh yes, there definitely should be! (I thought about this but then forgot to comment :-/)
Norge Vizcay
It's on the previous CL :)
Could you add some background on the "why"? I guess there are plans for using this outside of autofill?
Norge Vizcay
Done
File chrome/browser/autofill/account_setting_service_factory.h
Line 5, Patchset 13:
#ifndef CHROME_BROWSER_AUTOFILL_ACCOUNT_SETTING_SERVICE_FACTORY_H_Marc Treib . resolved
I guess this should also move out of the /autofill folder, but that can be another CL.
Norge Vizcay
It's on the next CL :)
File components/account_settings/DEPS
Line 6, Patchset 13:
"+components/keyed_service/core",
"+components/sync/model",
"+components/sync/base",Marc Treib . resolved
Norge Vizcaynit: sort alphabetically
Done
File ios/chrome/browser/autofill/model/DEPS
nit: Move down into the keep-sorted block
Norge Vizcay
Done
File ios/chrome/browser/autofill/ui_bundled/DEPS
Move into the keep-sorted block
Norge Vizcay
Done
File ios/chrome/browser/autofill/ui_bundled/chrome_autofill_client_ios.mm
Line 22, Patchset 13:
#import "components/account_settings/account_setting_service.h"Marc Treib . resolved
Norge Vizcaynit: Not used?
Removed.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Norge Vizcay (Gerrit)
Mar 19, 2026, 11:03:17 AM (4 days ago) Mar 19
to Florian Leimgruber, Marc Treib, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, droger+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Christoph Schwering
Norge Vizcay added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 16 (Latest):
Norge Vizcay . resolved
Chris, can you take a look a the iOS files?
Thank you!
Related details
Attention is currently required from:
- Christoph Schwering
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christoph Schwering (Gerrit)
Mar 19, 2026, 11:49:28 AM (4 days ago) Mar 19
to Norge Vizcay, Florian Leimgruber, Marc Treib, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, droger+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Norge Vizcay
Christoph Schwering voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Norge Vizcay
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Florian Leimgruber (Gerrit)
5:06 AM (8 hours ago) 5:06 AM
to Norge Vizcay, Marc Treib, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, droger+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Christoph Schwering, Marc Treib and Norge Vizcay
Florian Leimgruber voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Christoph Schwering
- Marc Treib
- Norge Vizcay
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marc Treib (Gerrit)
5:20 AM (8 hours ago) 5:20 AM
to Norge Vizcay, Marc Treib, Florian Leimgruber, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, droger+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Christoph Schwering and Norge Vizcay
Marc Treib voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Christoph Schwering
- Norge Vizcay
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christoph Schwering (Gerrit)
5:49 AM (7 hours ago) 5:49 AM
to Norge Vizcay, Marc Treib, Florian Leimgruber, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, droger+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Norge Vizcay
Christoph Schwering voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Norge Vizcay
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Norge Vizcay (Gerrit)
9:47 AM (3 hours ago) 9:47 AM
to Alexis Hétu, Marc Treib, Florian Leimgruber, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, droger+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Alexis Hétu
Norge Vizcay added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 18 (Latest):
Norge Vizcay . resolved
Hi Alexis, could you take a look at the changes in `ios/chrome/browser/account_settings/model/`?
Thanks!
Related details
Attention is currently required from:
- Alexis Hétu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexis Hétu (Gerrit)
9:53 AM (3 hours ago) 9:53 AM
to Norge Vizcay, Marc Treib, Florian Leimgruber, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, droger+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Norge Vizcay
Alexis Hétu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexis Hétu
| Code-Review | +1 |
1 comment
File ios/chrome/browser/account_settings/model/DEPS
Line 4, Patchset 18 (Latest):
"+components/sync/base",
"+components/sync/model",Alexis Hétu . unresolved
I think these 2 are not needed, `"+components/sync",` is already in ios/chrome/browser/DEPS
Related details
Attention is currently required from:
- Norge Vizcay
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Norge Vizcay (Gerrit)
10:11 AM (3 hours ago) 10:11 AM
to Alexis Hétu, Marc Treib, Florian Leimgruber, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, droger+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Norge Vizcay voted and added 2 comments![]( "Open in Gerrit")
Votes added by Norge Vizcay
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File ios/chrome/browser/account_settings/model/DEPS
I think these 2 are not needed, `"+components/sync",` is already in ios/chrome/browser/DEPS
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
11:39 AM (2 hours ago) 11:39 AM
to Norge Vizcay, Alexis Hétu, Marc Treib, Florian Leimgruber, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, droger+w...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
18 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ios/chrome/browser/account_settings/model/DEPS
Insertions: 0, Deletions: 2.
@@ -1,8 +1,6 @@
include_rules = [
# keep-sorted start
"+components/account_settings",
- "+components/sync/base",
- "+components/sync/model",
"+ios/chrome/browser/shared/model/profile",
"+ios/chrome/browser/sync/model",
# keep-sorted end
```
Change information
Commit message:
[account_settings] Move account_settings to its own component
This CL extracts the account settings logic into a dedicated component.
Originally housed within components/autofill as its sole consumer, the
logic is being decoupled to support upcoming integration with other
components.
Specifically, the CL:
- Moved account_settings from components/autofill/core/browser/webdata/account_settings/ to components/account_settings/.
- Renamed namespace to account_settings.
- Updated references in callers.
Bug: 494149753
Bypass-Check-License: Files were moved.
Change-Id: I7fb4a905628b7390fc419c5f0f7cefa0f20b9271
Reviewed-by: Marc Treib <tr...@chromium.org>
Reviewed-by: Florian Leimgruber <fleim...@google.com>
Reviewed-by: Alexis Hétu <su...@chromium.org>
Reviewed-by: Christoph Schwering <schw...@google.com>
Commit-Queue: Norge Vizcay <viz...@google.com>
Cr-Commit-Position: refs/heads/main@{#1603502}
Files:
- M chrome/browser/BUILD.gn
- M chrome/browser/DEPS
- M chrome/browser/autofill/BUILD.gn
- M chrome/browser/autofill/account_setting_service_factory.cc
- M chrome/browser/autofill/account_setting_service_factory.h
- M chrome/browser/autofill/android/entity_data_manager_android.cc
- M chrome/browser/autofill/android/entity_data_manager_android.h
- M chrome/browser/sync/test/integration/BUILD.gn
- M chrome/browser/sync/test/integration/single_client_account_setting_sync_test.cc
- M chrome/browser/ui/autofill/BUILD.gn
- M chrome/browser/ui/autofill/chrome_autofill_client.cc
- M components/BUILD.gn
- A components/account_settings/BUILD.gn
- A components/account_settings/DEPS
- R components/account_settings/account_setting_service.cc
- R components/account_settings/account_setting_service.h
- R components/account_settings/account_setting_service_unittest.cc
- R components/account_settings/account_setting_sync_bridge.cc
- R components/account_settings/account_setting_sync_bridge.h
- R components/account_settings/account_setting_sync_bridge_unittest.cc
- R components/account_settings/account_setting_sync_util.cc
- A components/account_settings/account_setting_sync_util.h
- M components/autofill/core/browser/BUILD.gn
- D components/autofill/core/browser/webdata/account_settings/account_setting_sync_util.h
- M components/browser_sync/BUILD.gn
- M components/browser_sync/DEPS
- M components/browser_sync/common_controller_builder.cc
- M components/browser_sync/common_controller_builder.h
- M ios/chrome/browser/account_settings/model/BUILD.gn
- M ios/chrome/browser/account_settings/model/DEPS
- M ios/chrome/browser/account_settings/model/ios_account_setting_service_factory.h
- M ios/chrome/browser/account_settings/model/ios_account_setting_service_factory.mm
- M ios/chrome/browser/autofill/model/BUILD.gn
- M ios/chrome/browser/autofill/model/DEPS
- M ios/chrome/browser/autofill/model/autofill_ai_util.mm
- M ios/chrome/browser/autofill/ui_bundled/BUILD.gn
- M ios/chrome/browser/autofill/ui_bundled/DEPS
- M ios/chrome/browser/autofill/ui_bundled/chrome_autofill_client_ios.mm
Change size: L
Delta: 38 files changed, 184 insertions(+), 107 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexis Hétu, +1 by Christoph Schwering, +1 by Florian Leimgruber, +1 by Marc Treib
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages