[GlassFrame] Add local state pref to enable glass frame [chromium/src : main]
0 views
Skip to first unread message
David Pennington (Gerrit)
12:08 PM (8 hours ago) 12:08 PM
to Steven Luong, Eshwar Stalin, Dominic Austria, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Eshwar Stalin and Steven Luong
David Pennington voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Eshwar Stalin
- Steven Luong
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steven Luong (Gerrit)
12:10 PM (8 hours ago) 12:10 PM
to David Pennington, Eshwar Stalin, Dominic Austria, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Eshwar Stalin
Steven Luong voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Eshwar Stalin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:15 PM (8 hours ago) 12:15 PM
to Steven Luong, David Pennington, Eshwar Stalin, Dominic Austria, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[GlassFrame] Add local state pref to enable glass frame
Adds a local state pref so that when enabled, the glass frame is shown
on the browser window. Otherwise, the glass frame is off for all browser
windows.
Fixed: 525119344
Change-Id: I84cbd47fb8dc5583d19109a52682847f204fb9b5
Commit-Queue: Steven Luong <stl...@chromium.org>
Reviewed-by: David Pennington <dpen...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1659610}
Files:
- M chrome/browser/prefs/browser_prefs.cc
- M chrome/browser/ui/views/frame/glass_frame_service.cc
- M chrome/browser/ui/views/frame/glass_frame_service.h
- M chrome/browser/ui/views/frame/glass_frame_service_interactive_uitest.cc
- M chrome/common/pref_names.h
Change size: M
Delta: 5 files changed, 74 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by David Pennington
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages