[Persist] Create DirectChildWalker for tab collections. [chromium/src : main]
0 views
Skip to first unread message
Sky Malice (Gerrit)
1:31 AM (20 hours ago) 1:31 AM
to David Pennington, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from David Pennington
Sky Malice added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- David Pennington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sky Malice (Gerrit)
1:36 AM (20 hours ago) 1:36 AM
to Eshwar Stalin, David Pennington, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from David Pennington and Eshwar Stalin
Sky Malice added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Sky Malice . resolved
-David +Eshwar due to OOO.
This is to follow up to comment thread https://docs.google.com/document/d/1k-tgbOFr97gBFhwlKGHyueFEcdpAlMVLrsIf9K6VDe8/edit?disco=AAABr10vTFI . Tried to create something that was explicit about what it was doing, and didn't significantly reduce the previous protections. Tried to add slight value by reducing the std::holds_alternative boilerplate, but I think you could make the argument it's not worth it. And instead I should just create getDirectChildren() w/o a PassKey.
PTAL
Related details
Attention is currently required from:
- David Pennington
- Eshwar Stalin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eshwar Stalin (Gerrit)
12:19 PM (10 hours ago) 12:19 PM
to Sky Malice, David Pennington, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from David Pennington and Sky Malice
Eshwar Stalin voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- David Pennington
- Sky Malice
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sky Malice (Gerrit)
12:23 PM (10 hours ago) 12:23 PM
to Eshwar Stalin, David Pennington, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from David Pennington
Sky Malice voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- David Pennington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:26 PM (10 hours ago) 12:26 PM
to Sky Malice, Eshwar Stalin, David Pennington, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Persist] Create DirectChildWalker for tab collections.
Bug: 427254267
Change-Id: I5508097b13e5219b99f361e1ed7691d46994c347
Reviewed-by: Eshwar Stalin <est...@chromium.org>
Commit-Queue: Sky Malice <sk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1520673}
Files:
- M components/tabs/BUILD.gn
- M components/tabs/impl/tab_collection.cc
- A components/tabs/public/direct_child_walker.h
- A components/tabs/public/direct_child_walker_unittest.cc
- M components/tabs/public/tab_collection.h
Change size: M
Delta: 5 files changed, 148 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eshwar Stalin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages