Launch PerUser metrics feature. [chromium/src : main]
Jong Ahn (Gerrit)
Attention is currently required from: Osama Fathy, Roman Sorokin.
To view, visit change 3805041. To unsubscribe, or for help writing mail filters, visit settings.
Jong Ahn (Gerrit)
Attention is currently required from: Osama Fathy, Roman Sorokin.
Patch set 2:-Commit-Queue
Jong Ahn (Gerrit)
Attention is currently required from: Osama Fathy, Roman Sorokin.
Patch set 4:Commit-Queue +1
1 comment:
Patchset:
Please take a look at the test changes I made and make sure that these are actually the intended behaviors 😊
To view, visit change 3805041. To unsubscribe, or for help writing mail filters, visit settings.
Roman Sorokin (Gerrit)
Attention is currently required from: Jong Ahn, Osama Fathy.
2 comments:
Patchset:
please fix failed tests
File chrome/browser/ash/login/consolidated_consent_field_trial.cc:
When will we remove the file?
To view, visit change 3805041. To unsubscribe, or for help writing mail filters, visit settings.
Jong Ahn (Gerrit)
Attention is currently required from: Osama Fathy, Roman Sorokin.
2 comments:
Patchset:
please fix failed tests
Opps I missed one.
Fixed 😊
File chrome/browser/ash/login/consolidated_consent_field_trial.cc:
When will we remove the file?
I will remove this file once the feature has landed in a stable channel.
I added a TODO.
To view, visit change 3805041. To unsubscribe, or for help writing mail filters, visit settings.
Roman Sorokin (Gerrit)
Attention is currently required from: Jong Ahn, Osama Fathy.
Patch set 5:Code-Review +1
Osama Fathy (Gerrit)
Attention is currently required from: Jong Ahn, Osama Fathy.
Patch set 5:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
Launch PerUser metrics feature.
Fix some tests that were broken as a result of enabling the feature by default.
Bug: 1186354
Change-Id: Ic0efa88063c90bc8c90c96f0d3eddd87d9280116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3805041
Reviewed-by: Roman Sorokin <rsor...@google.com>
Commit-Queue: Osama Fathy <osama...@google.com>
Cr-Commit-Position: refs/heads/main@{#1031448}
---
M ash/constants/ash_features.cc
M chrome/browser/ash/login/consolidated_consent_field_trial.cc
M chrome/browser/ash/login/consolidated_consent_field_trial.h
M chrome/browser/ash/login/reporting/login_logout_reporter_browsertest.cc
M chrome/browser/ash/login/test/oobe_screens_utils.cc
M chrome/browser/ash/login/test/oobe_screens_utils.h
M chrome/browser/ash/login/wizard_controller_browsertest.cc
M chrome/browser/ash/policy/reporting/user_added_removed/user_added_removed_reporter_browsertest.cc
8 files changed, 49 insertions(+), 11 deletions(-)