Move Proxy API to //extensions [chromium/src : main]
1 view
Skip to first unread message
Miyoung Shin (Gerrit)
Jul 9, 2026, 1:52:09 AM (13 days ago) Jul 9
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, net-r...@chromium.org
Attention needed from Devlin Cronin
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Jul 9, 2026, 11:52:35 AM (12 days ago) Jul 9
to Miyoung Shin, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, net-r...@chromium.org
Attention needed from Miyoung Shin
Devlin Cronin added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File chrome/common/extensions/api/_api_features.json
Line 888, Patchset 3 (Parent):
"dependencies": ["permission:proxy"],Devlin Cronin . unresolved
please also move the feature from permission_features.json
File extensions/browser/BUILD.gn
Line 181, Patchset 3 (Latest):
"api/proxy/proxy_api_constants.cc",
"api/proxy/proxy_api_constants.h",
"api/proxy/proxy_api_helpers.cc",
"api/proxy/proxy_api_helpers.h",
"api/proxy/proxy_pref_transformer.cc",
"api/proxy/proxy_pref_transformer.h",Devlin Cronin . unresolved
Ideally, //extensions/browser/BUILD.gn does not include API implementations (ditto for //chrome/browser/extensions/BUILD.gn) -- see comment at line 106. For various reasons, there's dependencies between these that meant that some of these couldn't be moved out -- but given these were previously in //chrome, it seems like these dependencies must have been broken. Can these be in //extensions/browser/api/proxy/BUILD.gn?
Related details
Attention is currently required from:
- Miyoung Shin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Miyoung Shin (Gerrit)
Jul 15, 2026, 9:22:34 AM (7 days ago) Jul 15
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, net-r...@chromium.org
Attention needed from Devlin Cronin
Miyoung Shin added 2 comments![]( "Open in Gerrit")
File chrome/common/extensions/api/_api_features.json
Line 888, Patchset 3 (Parent):
"dependencies": ["permission:proxy"],Devlin Cronin . resolved
please also move the feature from permission_features.json
Miyoung Shin
moved it as well. Thanks!
File extensions/browser/BUILD.gn
Line 181, Patchset 3:
"api/proxy/proxy_api_constants.cc",
"api/proxy/proxy_api_constants.h",
"api/proxy/proxy_api_helpers.cc",
"api/proxy/proxy_api_helpers.h",
"api/proxy/proxy_pref_transformer.cc",
"api/proxy/proxy_pref_transformer.h",Devlin Cronin . resolved
Ideally, //extensions/browser/BUILD.gn does not include API implementations (ditto for //chrome/browser/extensions/BUILD.gn) -- see comment at line 106. For various reasons, there's dependencies between these that meant that some of these couldn't be moved out -- but given these were previously in //chrome, it seems like these dependencies must have been broken. Can these be in //extensions/browser/api/proxy/BUILD.gn?
Attention is currently required from:
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Jul 16, 2026, 4:09:41 PM (5 days ago) Jul 16
to Miyoung Shin, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, net-r...@chromium.org
Attention needed from Miyoung Shin
Devlin Cronin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Devlin Cronin
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Miyoung Shin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Miyoung Shin (Gerrit)
Jul 16, 2026, 10:01:35 PM (5 days ago) Jul 16
to Adam Rice, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, net-r...@chromium.org
Attention needed from Adam Rice
Miyoung Shin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Adam Rice
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Miyoung Shin (Gerrit)
1:57 AM (20 hours ago) 1:57 AM
to Adam Rice, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, net-r...@chromium.org
Attention needed from Adam Rice
Miyoung Shin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Miyoung Shin . resolved
ricea@, friendly ping
Related details
Attention is currently required from:
- Adam Rice
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
8:58 AM (13 hours ago) 8:58 AM
to Miyoung Shin, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, net-r...@chromium.org
Attention needed from Miyoung Shin
Adam Rice voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Rice
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Miyoung Shin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Miyoung Shin (Gerrit)
8:32 PM (1 hour ago) 8:32 PM
to Adam Rice, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, net-r...@chromium.org
Miyoung Shin voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:31 PM (10 minutes ago) 9:31 PM
to Miyoung Shin, Adam Rice, Devlin Cronin, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, net-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Move Proxy API to //extensions
This CL moves the Proxy API from //chrome to //extensions,
as they no longer depend on //chrome.
Bug: 358567092
Change-Id: Ibd709a69dfed278544c46f2a63a94543fe617861
Bypass-Check-License: Moving files
Reviewed-by: Devlin Cronin <rdevlin...@chromium.org>
Reviewed-by: Adam Rice <ri...@chromium.org>
Commit-Queue: Miyoung Shin <myid...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1665960}
Files:
- M chrome/browser/extensions/BUILD.gn
- M chrome/browser/extensions/api/BUILD.gn
- D chrome/browser/extensions/api/proxy/BUILD.gn
- M chrome/browser/extensions/chrome_extensions_browser_client.cc
- M chrome/browser/net/BUILD.gn
- M chrome/browser/net/proxy_config_monitor.cc
- M chrome/common/extensions/api/BUILD.gn
- M chrome/common/extensions/api/_api_features.json
- M chrome/common/extensions/api/_permission_features.json
- M chrome/common/extensions/permissions/chrome_api_permissions.cc
- M extensions/browser/BUILD.gn
- M extensions/browser/api/BUILD.gn
- M extensions/browser/api/DEPS
- A extensions/browser/api/proxy/BUILD.gn
- R extensions/browser/api/proxy/OWNERS
- R extensions/browser/api/proxy/proxy_api.cc
- R extensions/browser/api/proxy/proxy_api.h
- R extensions/browser/api/proxy/proxy_api_constants.cc
- R extensions/browser/api/proxy/proxy_api_constants.h
- R extensions/browser/api/proxy/proxy_api_helpers.cc
- R extensions/browser/api/proxy/proxy_api_helpers.h
- R extensions/browser/api/proxy/proxy_api_helpers_unittest.cc
- R extensions/browser/api/proxy/proxy_pref_transformer.cc
- R extensions/browser/api/proxy/proxy_pref_transformer.h
- M extensions/common/api/_api_features.json
- M extensions/common/api/_permission_features.json
- R extensions/common/api/proxy.json
- M extensions/common/api/schema.gni
- M extensions/common/permissions/extensions_api_permissions.cc
Change size: M
Delta: 29 files changed, 103 insertions(+), 82 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Devlin Cronin, +1 by Adam Rice
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages