Remove dead code UpdateHeaderView() in PaymentRequestSheetController [chromium/src : main]

0 views
Skip to first unread message

Slobodan Pejic (Gerrit)

unread,
11:44 AM (3 hours ago) 11:44 AM
to chromium...@chromium.org, sloboda...@chromium.org

Slobodan Pejic has uploaded the change for review

Commit message

Remove dead code UpdateHeaderView() in PaymentRequestSheetController

UpdateHeaderView() is no longer used and can be safely removed.
Bug: None
Change-Id: I9cf3aac9cdfbaf29e7f490e340d041a257efbf06

Change diff

diff --git a/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc b/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
index 4aa882f1..2331650 100644
--- a/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
+++ b/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
@@ -386,18 +386,6 @@
   RelayoutPane();
 }
 
-void PaymentRequestSheetController::UpdateHeaderView() {
-  // Do not update the view if the payment request is being aborted.
-  if (!is_active_) {
-    return;
-  }
-
-  header_view_->RemoveAllChildViews();
-  PopulateSheetHeaderView(header_view_);
-  header_view_->InvalidateLayout();
-  header_view_->SchedulePaint();
-}
-
 void PaymentRequestSheetController::UpdateFocus(views::View* focused_view) {
   DialogViewID sheet_id;
   if (GetSheetId(&sheet_id)) {
diff --git a/chrome/browser/ui/views/payments/payment_request_sheet_controller.h b/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
index 58ba1d33..dad809d 100644
--- a/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
+++ b/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
@@ -89,9 +89,6 @@
   // calls FillContentView again to re-populate it with updated views.
   void UpdateContentView();
 
-  // Clears and recreates the header view for this sheet.
-  void UpdateHeaderView();
-
   // Update the focus to |focused_view|.
   void UpdateFocus(views::View* focused_view);

Change information

Files:
  • M chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
  • M chrome/browser/ui/views/payments/payment_request_sheet_controller.h
Change size: S
Delta: 2 files changed, 0 insertions(+), 15 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9cf3aac9cdfbaf29e7f490e340d041a257efbf06
Gerrit-Change-Number: 8070518
Gerrit-PatchSet: 1
Gerrit-Owner: Slobodan Pejic <slob...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Slobodan Pejic (Gerrit)

unread,
12:07 PM (3 hours ago) 12:07 PM
to Xuehui Chen, Chromium LUCI CQ, chromium...@chromium.org, sloboda...@chromium.org
Attention needed from Xuehui Chen

Slobodan Pejic voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Xuehui Chen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9cf3aac9cdfbaf29e7f490e340d041a257efbf06
Gerrit-Change-Number: 8070518
Gerrit-PatchSet: 1
Gerrit-Owner: Slobodan Pejic <slob...@chromium.org>
Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
Gerrit-Reviewer: Xuehui Chen <xuehu...@google.com>
Gerrit-Attention: Xuehui Chen <xuehu...@google.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 16:07:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Xuehui Chen (Gerrit)

unread,
12:09 PM (3 hours ago) 12:09 PM
to Slobodan Pejic, Chromium LUCI CQ, chromium...@chromium.org, sloboda...@chromium.org
Attention needed from Slobodan Pejic

Xuehui Chen voted and added 1 comment

Votes added by Xuehui Chen

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Xuehui Chen . resolved

LGTM, I have a exact same change haha

Open in Gerrit

Related details

Attention is currently required from:
  • Slobodan Pejic
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9cf3aac9cdfbaf29e7f490e340d041a257efbf06
    Gerrit-Change-Number: 8070518
    Gerrit-PatchSet: 1
    Gerrit-Owner: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Reviewer: Xuehui Chen <xuehu...@google.com>
    Gerrit-Attention: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Comment-Date: Thu, 09 Jul 2026 16:08:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Xuehui Chen (Gerrit)

    unread,
    12:32 PM (2 hours ago) 12:32 PM
    to Slobodan Pejic, Chromium LUCI CQ, chromium...@chromium.org, sloboda...@chromium.org
    Attention needed from Slobodan Pejic

    Xuehui Chen voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Slobodan Pejic
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9cf3aac9cdfbaf29e7f490e340d041a257efbf06
    Gerrit-Change-Number: 8070518
    Gerrit-PatchSet: 1
    Gerrit-Owner: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Reviewer: Xuehui Chen <xuehu...@google.com>
    Gerrit-Attention: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Comment-Date: Thu, 09 Jul 2026 16:32:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    12:37 PM (2 hours ago) 12:37 PM
    to Slobodan Pejic, Xuehui Chen, chromium...@chromium.org, sloboda...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove dead code UpdateHeaderView() in PaymentRequestSheetController

    UpdateHeaderView() is no longer used and can be safely removed.
    Bug: None
    Change-Id: I9cf3aac9cdfbaf29e7f490e340d041a257efbf06
    Commit-Queue: Slobodan Pejic <slob...@chromium.org>
    Auto-Submit: Slobodan Pejic <slob...@chromium.org>
    Commit-Queue: Xuehui Chen <xuehu...@google.com>
    Reviewed-by: Xuehui Chen <xuehu...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1659629}
    Files:
    • M chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
    • M chrome/browser/ui/views/payments/payment_request_sheet_controller.h
    Change size: S
    Delta: 2 files changed, 0 insertions(+), 15 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Xuehui Chen
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9cf3aac9cdfbaf29e7f490e340d041a257efbf06
    Gerrit-Change-Number: 8070518
    Gerrit-PatchSet: 2
    Gerrit-Owner: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Slobodan Pejic <slob...@chromium.org>
    Gerrit-Reviewer: Xuehui Chen <xuehu...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages