Mike Wittman (Gerrit)

unread,

Jul 8, 2026, 1:18:00 AMJul 8

to Devin Cabillo, Mike Wittman, Nathan Memmott, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Devin Cabillo and Nathan Memmott

Mike Wittman voted and added 1 comment

Votes added by Mike Wittman

Code-Review

+1

1 comment

Commit Message

Line 16, Patchset 5 (Latest):Binary-Size: Size increase is unavoidable (see above).

Mike Wittman . unresolved

blank line before this line, between the description contents and the footers

Open in Gerrit

Related details

Attention is currently required from:

Devin Cabillo
Nathan Memmott

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Devin Cabillo (Gerrit)

unread,

Jul 8, 2026, 1:24:37 AMJul 8

to Mike Wittman, Nathan Memmott, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Nathan Memmott

Devin Cabillo added 1 comment

Commit Message

Line 16, Patchset 5:Binary-Size: Size increase is unavoidable (see above).

Mike Wittman . resolved

blank line before this line, between the description contents and the footers

Devin Cabillo

Done

Open in Gerrit

Related details

Attention is currently required from:

Nathan Memmott

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alan Ding (Gerrit)

unread,

Jul 8, 2026, 1:43:51 AMJul 8

to Devin Cabillo, Mike Wittman, Nathan Memmott, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Devin Cabillo and Nathan Memmott

Alan Ding voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Devin Cabillo
Nathan Memmott

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Devin Cabillo (Gerrit)

unread,

Jul 8, 2026, 12:37:12 PMJul 8

to Alan Ding, Mike Wittman, Nathan Memmott, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Nathan Memmott

Devin Cabillo voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Nathan Memmott

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 8, 2026, 12:44:12 PMJul 8

to Devin Cabillo, Alan Ding, Mike Wittman, Nathan Memmott, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

Roll TFLite/LiteRT to Next Green Version

Android binary size increase caused by xnnpack roll.

Version Changes:

XNNPACK: 4b7c368f5e48d9292c5834593c2f83e66b55ce83 to d9ff5bf36955f97c657013272acd3a46d696b301
tflite: 66fe77c30816f9c0a503fb9f2f12fdb56c6eee76 to a12cd7d36bb3dbae1dd7a4b572643084bc62f6e1
litert: ee121300b37b49cd4f9942c0f1256936aa9e611a to d419a5d6b81ad7f6db0a469dac5b82d47f3ac980

Binary-Size: Size increase is unavoidable (see above).

Bug: 388311883

Change-Id: I5f57eef7dd07192372323c2064fb2bf87b634cb6

Cq-Include-Trybots: luci.chrome.try:optimization_guide-linux;luci.chrome.try:optimization_guide-mac-arm64;luci.chrome.try:optimization_guide-mac-x64;luci.chrome.try:optimization_guide-win32;luci.chrome.try:optimization_guide-win64

Include-Ci-Only-Tests: chromium.android:android-pie-arm64-rel|android_browsertests

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8059947

Reviewed-by: Alan Ding <alan...@chromium.org>

Reviewed-by: Mike Wittman <wit...@chromium.org>

Commit-Queue: Devin Cabillo <devinc...@google.com>

Cr-Commit-Position: refs/heads/main@{#1658841}

Files:

M DEPS
M third_party/litert/README.chromium
M third_party/litert/src
M third_party/tflite/BUILD.gn
M third_party/tflite/README.chromium
M third_party/tflite/src
M third_party/xnnpack/BUILD.gn
M third_party/xnnpack/README.chromium
M third_party/xnnpack/build_identifier.c
M third_party/xnnpack/src

Change size: XL

Delta: 10 files changed, 1191 insertions(+), 35 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Alan Ding, +1 by Mike Wittman

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Steven Holte (Gerrit)

unread,

Jul 13, 2026, 5:00:08 PMJul 13

to Jaewon Lee, Steven Holte, Nathan Memmott, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee and Nathan Memmott

Steven Holte voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Jaewon Lee
Nathan Memmott

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nathan Memmott (Gerrit)

unread,

Jul 13, 2026, 5:00:43 PMJul 13

to Jaewon Lee, Steven Holte, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee

Nathan Memmott voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Jaewon Lee

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Steven Holte (Gerrit)

unread,

Jul 13, 2026, 5:55:20 PMJul 13

to Jaewon Lee, Steven Holte, Nathan Memmott, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee and Nathan Memmott

Steven Holte voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Jaewon Lee
Nathan Memmott

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Steven Holte (Gerrit)

unread,

Jul 13, 2026, 8:02:03 PMJul 13

to Jaewon Lee, Steven Holte, Nathan Memmott, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee and Nathan Memmott

Steven Holte voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Jaewon Lee
Nathan Memmott

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nathan Memmott (Gerrit)

unread,

Jul 13, 2026, 8:05:41 PMJul 13

to Jaewon Lee, Steven Holte, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee

Nathan Memmott voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Jaewon Lee

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Jaewon Lee (Gerrit)

unread,

Jul 13, 2026, 10:37:21 PMJul 13

to Nathan Memmott, Steven Holte, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Jaewon Lee voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lynne Jiang (Gerrit)

unread,

Jul 14, 2026, 7:05:45 PMJul 14

to Jaewon Lee, Nathan Memmott, Steven Holte, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee

Lynne Jiang added 1 comment

File third_party/litert/BUILD.gn

Line 69, Patchset 3 (Latest): "LITERT_COMPILE_LIBRARY",

Lynne Jiang . unresolved

Here is the Gemini explained why it failed on Windows but not Linux, "on Linux, shared objects ( .so ) resolve symbols globally at runtime regardless of LITERT_COMPILE_LIBRARY. On Windows ( LITERT_WINDOWS_OS ), LITERT_CAPI_EXPORT expands to __declspec(dllexport) when LITERT_COMPILE_LIBRARY is defined, and __declspec(dllimport) when it is not defined."

Can you try remove "LITERT_COMPILE_LIBRARY" from config("litert_config") in third_party/litert/BUILD.gn and apply it via a private config ( configs += [":litert_private_config"]) only on targets that build the LiteRT library implementation (litert_c , litert_runtime , etc.), so external DLLs properly import (__declspec(dllimport)) across Windows DLL boundaries?

Open in Gerrit

Related details

Attention is currently required from:

Jaewon Lee

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jaewon Lee (Gerrit)

unread,

Jul 14, 2026, 7:58:59 PMJul 14

to Lynne Jiang, Nathan Memmott, Steven Holte, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Lynne Jiang, Nathan Memmott and Steven Holte

Jaewon Lee added 1 comment

File third_party/litert/BUILD.gn

Line 69, Patchset 3: "LITERT_COMPILE_LIBRARY",

Lynne Jiang . resolved

Here is the Gemini explained why it failed on Windows but not Linux, "on Linux, shared objects ( .so ) resolve symbols globally at runtime regardless of LITERT_COMPILE_LIBRARY. On Windows ( LITERT_WINDOWS_OS ), LITERT_CAPI_EXPORT expands to __declspec(dllexport) when LITERT_COMPILE_LIBRARY is defined, and __declspec(dllimport) when it is not defined."
Can you try remove "LITERT_COMPILE_LIBRARY" from config("litert_config") in third_party/litert/BUILD.gn and apply it via a private config ( configs += [":litert_private_config"]) only on targets that build the LiteRT library implementation (litert_c , litert_runtime , etc.), so external DLLs properly import (__declspec(dllimport)) across Windows DLL boundaries?

Jaewon Lee

Thanks for running this on your machine! Really appreciate it. I've gone ahead and implemented what you suggested. Fingers crossed for the CQ.

Open in Gerrit

Related details

Attention is currently required from:

Lynne Jiang
Nathan Memmott
Steven Holte

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lynne Jiang (Gerrit)

unread,

Jul 14, 2026, 8:33:16 PMJul 14

to Jaewon Lee, Nathan Memmott, Steven Holte, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee, Nathan Memmott and Steven Holte

Lynne Jiang added 1 comment

File third_party/litert/BUILD.gn

Line 69, Patchset 3: "LITERT_COMPILE_LIBRARY",

Lynne Jiang . unresolved

Here is the Gemini explained why it failed on Windows but not Linux, "on Linux, shared objects ( .so ) resolve symbols globally at runtime regardless of LITERT_COMPILE_LIBRARY. On Windows ( LITERT_WINDOWS_OS ), LITERT_CAPI_EXPORT expands to __declspec(dllexport) when LITERT_COMPILE_LIBRARY is defined, and __declspec(dllimport) when it is not defined."
Can you try remove "LITERT_COMPILE_LIBRARY" from config("litert_config") in third_party/litert/BUILD.gn and apply it via a private config ( configs += [":litert_private_config"]) only on targets that build the LiteRT library implementation (litert_c , litert_runtime , etc.), so external DLLs properly import (__declspec(dllimport)) across Windows DLL boundaries?

Jaewon Lee

Thanks for running this on your machine! Really appreciate it. I've gone ahead and implemented what you suggested. Fingers crossed for the CQ.

Lynne Jiang

Actually it may still have issue, I sent out cl/947995524 and cc'd you on that, after that you can just define LITERT_STATIC instead of LITERT_COMPILE_LIBRARY to workaround this issue.

Open in Gerrit

Related details

Attention is currently required from:

Jaewon Lee
Nathan Memmott
Steven Holte

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lynne Jiang (Gerrit)

unread,

Jul 15, 2026, 5:54:03 PMJul 15

to Jaewon Lee, Nathan Memmott, Steven Holte, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee, Nathan Memmott and Steven Holte

Lynne Jiang added 1 comment

File third_party/litert/BUILD.gn

Line 69, Patchset 3: "LITERT_COMPILE_LIBRARY",

Lynne Jiang . unresolved

Here is the Gemini explained why it failed on Windows but not Linux, "on Linux, shared objects ( .so ) resolve symbols globally at runtime regardless of LITERT_COMPILE_LIBRARY. On Windows ( LITERT_WINDOWS_OS ), LITERT_CAPI_EXPORT expands to __declspec(dllexport) when LITERT_COMPILE_LIBRARY is defined, and __declspec(dllimport) when it is not defined."
Can you try remove "LITERT_COMPILE_LIBRARY" from config("litert_config") in third_party/litert/BUILD.gn and apply it via a private config ( configs += [":litert_private_config"]) only on targets that build the LiteRT library implementation (litert_c , litert_runtime , etc.), so external DLLs properly import (__declspec(dllimport)) across Windows DLL boundaries?

Jaewon Lee

Thanks for running this on your machine! Really appreciate it. I've gone ahead and implemented what you suggested. Fingers crossed for the CQ.

Lynne Jiang

Actually it may still have issue, I sent out cl/947995524 and cc'd you on that, after that you can just define LITERT_STATIC instead of LITERT_COMPILE_LIBRARY to workaround this issue.

Lynne Jiang

FYI cl/948456770 was submitted, can you update to the latest version contains the cl and then defines LITERT_STATIC in the public `litert_config` to solve the issue.

satisfied_requirement

unsatisfied_requirement

open

diffy

Jaewon Lee (Gerrit)

unread,

Jul 15, 2026, 6:27:20 PMJul 15

to Steven Holte, Nathan Memmott, Lynne Jiang, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Nathan Memmott and Steven Holte

Jaewon Lee voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Nathan Memmott
Steven Holte

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Steven Holte (Gerrit)

unread,

Jul 15, 2026, 6:29:00 PMJul 15

to Jaewon Lee, Steven Holte, Chromium LUCI CQ, Nathan Memmott, Lynne Jiang, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee and Nathan Memmott

Steven Holte voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Jaewon Lee
Nathan Memmott

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jaewon Lee (Gerrit)

unread,

Jul 15, 2026, 6:29:55 PMJul 15

to Lynne Jiang, Nathan Memmott, Steven Holte, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Lynne Jiang, Nathan Memmott and Steven Holte

Jaewon Lee added 1 comment

File third_party/litert/BUILD.gn

Line 69, Patchset 3: "LITERT_COMPILE_LIBRARY",

Lynne Jiang . resolved

Here is the Gemini explained why it failed on Windows but not Linux, "on Linux, shared objects ( .so ) resolve symbols globally at runtime regardless of LITERT_COMPILE_LIBRARY. On Windows ( LITERT_WINDOWS_OS ), LITERT_CAPI_EXPORT expands to __declspec(dllexport) when LITERT_COMPILE_LIBRARY is defined, and __declspec(dllimport) when it is not defined."
Can you try remove "LITERT_COMPILE_LIBRARY" from config("litert_config") in third_party/litert/BUILD.gn and apply it via a private config ( configs += [":litert_private_config"]) only on targets that build the LiteRT library implementation (litert_c , litert_runtime , etc.), so external DLLs properly import (__declspec(dllimport)) across Windows DLL boundaries?

Jaewon Lee

Thanks for running this on your machine! Really appreciate it. I've gone ahead and implemented what you suggested. Fingers crossed for the CQ.

Lynne Jiang

Actually it may still have issue, I sent out cl/947995524 and cc'd you on that, after that you can just define LITERT_STATIC instead of LITERT_COMPILE_LIBRARY to workaround this issue.

Lynne Jiang

FYI cl/948456770 was submitted, can you update to the latest version contains the cl and then defines LITERT_STATIC in the public `litert_config` to solve the issue.

Jaewon Lee

Thank you Lynne for your fast work on this! I've gone ahead and created a new roll here: https://crrev.com/c/8102719/1..2

Going to mark this CL as abandoned now.

Open in Gerrit

Related details

Attention is currently required from:

Lynne Jiang
Nathan Memmott
Steven Holte

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jaewon Lee (Gerrit)

unread,

Jul 15, 2026, 6:29:58 PMJul 15

to Lynne Jiang, Nathan Memmott, Steven Holte, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Jaewon Lee abandoned this change.

View Change

Abandoned

Jaewon Lee abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nathan Memmott (Gerrit)

unread,

Jul 15, 2026, 6:31:10 PMJul 15

to Jaewon Lee, Steven Holte, Chromium LUCI CQ, Lynne Jiang, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee

Nathan Memmott voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Jaewon Lee

Submit Requirements:

Code-Coverage

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lynne Jiang (Gerrit)

unread,

Jul 15, 2026, 8:33:42 PMJul 15

to Jaewon Lee, Nathan Memmott, Steven Holte, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee, Nathan Memmott and Steven Holte

Lynne Jiang added 1 comment

File DEPS

Line 3064, Patchset 4:

    Var('chromium_git') + '/external/github.com/google-ai-edge/LiteRT.git' + '@' + '3bb8b6529011d69dc17613152ae4003c2b5ed6f6',

Lynne Jiang . unresolved

This version doesn't include the fix yet https://github.com/google-ai-edge/LiteRT/commit/e38ed2ff061f3c61f512e9d4e8a738301f90aba6.

Open in Gerrit

Related details

Attention is currently required from:

Jaewon Lee
Nathan Memmott
Steven Holte

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jaewon Lee (Gerrit)

unread,

Jul 16, 2026, 1:10:08 PMJul 16

to Nathan Memmott, Steven Holte, Chromium LUCI CQ, Lynne Jiang, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Lynne Jiang, Nathan Memmott and Steven Holte

Jaewon Lee added 1 comment

File DEPS

Line 3064, Patchset 4:

    Var('chromium_git') + '/external/github.com/google-ai-edge/LiteRT.git' + '@' + '3bb8b6529011d69dc17613152ae4003c2b5ed6f6',

Lynne Jiang . unresolved

This version doesn't include the fix yet https://github.com/google-ai-edge/LiteRT/commit/e38ed2ff061f3c61f512e9d4e8a738301f90aba6.

Jaewon Lee

I have a new roll set up with the fixes here: https://crrev.com/c/8105154 now; abandoning this CL and thank you for the catch!

Open in Gerrit

Related details

Attention is currently required from:

Lynne Jiang
Nathan Memmott
Steven Holte

satisfied_requirement

unsatisfied_requirement

open

diffy

Jaewon Lee (Gerrit)

unread,

Jul 16, 2026, 1:10:18 PMJul 16

to Nathan Memmott, Steven Holte, Chromium LUCI CQ, Lynne Jiang, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Jaewon Lee abandoned this change.

View Change

Abandoned

Jaewon Lee abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lynne Jiang (Gerrit)

unread,

Jul 16, 2026, 5:11:59 PMJul 16

to Jaewon Lee, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee

Lynne Jiang added 2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Lynne Jiang . unresolved

The test failures are caused by the ABI discrepancies when internal and external litert code misaligned, more sprcifically cl/943394391 needs to be included in both internal and external litert.

File third_party/litert/BUILD.gn

Line 421, Patchset 2 (Latest): defines = [ "LITERT_COMPILE_LIBRARY" ]

Lynne Jiang . unresolved

You don't need to define LITERT_COMPILE_LIBRARY any more if we defined LITERT_STATIC, same as below.

Open in Gerrit

Related details

Attention is currently required from:

Jaewon Lee

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jaewon Lee (Gerrit)

unread,

Jul 16, 2026, 6:03:54 PMJul 16

to Lynne Jiang, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Lynne Jiang

Jaewon Lee added 1 comment

File third_party/litert/BUILD.gn

Line 421, Patchset 2: defines = [ "LITERT_COMPILE_LIBRARY" ]

Lynne Jiang . resolved

You don't need to define LITERT_COMPILE_LIBRARY any more if we defined LITERT_STATIC, same as below.

Jaewon Lee

Done

Open in Gerrit

Related details

Attention is currently required from:

Lynne Jiang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jaewon Lee (Gerrit)

unread,

Jul 17, 2026, 12:36:08 AMJul 17

to Steven Holte, Nathan Memmott, Lynne Jiang, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Lynne Jiang, Nathan Memmott and Steven Holte

Jaewon Lee added 1 comment

Patchset-level comments

File-level comment, Patchset 2:

Lynne Jiang . resolved

The test failures are caused by the ABI discrepancies when internal and external litert code misaligned, more sprcifically cl/943394391 needs to be included in both internal and external litert.

Jaewon Lee

Resolved offline: we found that the ABI discrepancies were caused by the ODML roll, which has been behind by several weeks now. Significant progress has been made on the roll, which now depends on some of the changes we've made in the litert BUILD.gn file here.

We decided to move forward by temporarily disabling the WebNN tests to get this TF Lite roll in first; then shortly after we will attempt to get the ODML roll in, solving the ABI discrepancies. Afterwards, we will re-enable the WebNN tests.

Open in Gerrit

Related details

Attention is currently required from:

Lynne Jiang
Nathan Memmott
Steven Holte

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nathan Memmott (Gerrit)

unread,

Jul 17, 2026, 11:41:12 AMJul 17

to Jaewon Lee, Steven Holte, Lynne Jiang, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee, Lynne Jiang and Steven Holte

Nathan Memmott voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Jaewon Lee
Lynne Jiang
Steven Holte

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jaewon Lee (Gerrit)

unread,

Jul 17, 2026, 12:37:33 PMJul 17

to Nathan Memmott, Steven Holte, Lynne Jiang, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Lynne Jiang and Steven Holte

Jaewon Lee voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Lynne Jiang
Steven Holte

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mike Wasserman (Gerrit)

unread,

Jul 17, 2026, 12:40:05 PMJul 17

to Jaewon Lee, Nathan Memmott, Lynne Jiang, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jaewon Lee and Lynne Jiang

Mike Wasserman voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Jaewon Lee
Lynne Jiang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 17, 2026, 12:44:08 PMJul 17

to Jaewon Lee, Mike Wasserman, Nathan Memmott, Lynne Jiang, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

Roll TFLite/LiteRT to Next Green Version

Version Changes:
XNNPACK: d9ff5bf36955f97c657013272acd3a46d696b301 to dff8cb5db8c102d0f65140838f11de8bc9668c86
tflite: a12cd7d36bb3dbae1dd7a4b572643084bc62f6e1 to 6eded1ce7a1aa23f6ff3e22f163c43061bc14c9f
litert: d419a5d6b81ad7f6db0a469dac5b82d47f3ac980 to 61f432493259e1eddbb72a24426b15beea9395fd

Bug: 388311883

Change-Id: I7c9fc900107f1371ee40dc54e48224163b8b07c3

Cq-Include-Trybots: luci.chrome.try:optimization_guide-linux;luci.chrome.try:optimization_guide-mac-arm64;luci.chrome.try:optimization_guide-mac-x64;luci.chrome.try:optimization_guide-win32;luci.chrome.try:optimization_guide-win64

Include-Ci-Only-Tests: chromium.android:android-pie-arm64-rel|android_browsertests

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8105154

Reviewed-by: Mike Wasserman <m...@chromium.org>

Reviewed-by: Nathan Memmott <mem...@chromium.org>

Auto-Submit: Jaewon Lee <jae...@google.com>

Commit-Queue: Mike Wasserman <m...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1663983}

Files:

M DEPS
M third_party/litert/BUILD.gn
M third_party/litert/README.chromium
M third_party/litert/src

M third_party/tflite/README.chromium
M third_party/tflite/src
M third_party/xnnpack/BUILD.gn
M third_party/xnnpack/README.chromium
M third_party/xnnpack/build_identifier.c
M third_party/xnnpack/src

Change size: L

Delta: 10 files changed, 233 insertions(+), 22 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Mike Wasserman, +1 by Nathan Memmott

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Steven Holte (Gerrit)

unread,

Jul 22, 2026, 7:08:21 PMJul 22

to Steven Holte, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Steven Holte voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lynne Jiang (Gerrit)

unread,

Jul 23, 2026, 12:12:27 PMJul 23

to Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Lynne Jiang

Message from Lynne Jiang

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

Lynne Jiang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lynne Jiang (Gerrit)

unread,

Jul 23, 2026, 12:12:56 PMJul 23

to Steven Holte, Nathan Memmott, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Lynne Jiang, Nathan Memmott and Steven Holte

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Lynne Jiang
Nathan Memmott
Steven Holte

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nathan Memmott (Gerrit)

unread,

Jul 23, 2026, 12:13:38 PMJul 23

to Lynne Jiang, Steven Holte, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Lynne Jiang and Steven Holte

Nathan Memmott voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Lynne Jiang
Steven Holte

Submit Requirements:

Code-Coverage

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Steven Holte (Gerrit)

unread,

Jul 23, 2026, 12:18:28 PMJul 23

to Lynne Jiang, Steven Holte, Nathan Memmott, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Lynne Jiang

Steven Holte voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Lynne Jiang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lynne Jiang (Gerrit)

unread,

Jul 23, 2026, 12:48:06 PMJul 23

to Steven Holte, Nathan Memmott, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Lynne Jiang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 23, 2026, 12:55:07 PMJul 23

to Lynne Jiang, Steven Holte, Nathan Memmott, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

Roll TFLite/LiteRT to Next Green Version

Version Changes:

    TFLite: 6eded1ce7a1aa23f6ff3e22f163c43061bc14c9f to 7bedf2e94aff6ca62150d74fd40aa63cb73c6583
    LiteRT: 44c71d8b9300fb9ec8f646261f5ce3eaf1e76a47 to 1ae23176dd5d3a43e35961d8236d5adda7f8c0a1
    XNNPACK: dff8cb5db8c102d0f65140838f11de8bc9668c86 to 09c4a9137f3a19b053dc45724a62f4f73ec7746a

Bug: 388311883

Change-Id: Ib835bf74ee3aed00a309ee3fc94ad6349b4579ad

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8128510

Reviewed-by: Nathan Memmott <mem...@chromium.org>

Reviewed-by: Steven Holte <ho...@chromium.org>

Commit-Queue: Lynne Jiang <lyj...@google.com>

Cr-Commit-Position: refs/heads/main@{#1667202}

Files:

M DEPS
M third_party/litert/BUILD.gn
M third_party/litert/README.chromium
M third_party/litert/src
M third_party/tflite/README.chromium
M third_party/tflite/src
M third_party/xnnpack/BUILD.gn
M third_party/xnnpack/README.chromium

M third_party/xnnpack/src

Change size: S

Delta: 9 files changed, 28 insertions(+), 14 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Steven Holte, +1 by Nathan Memmott

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Jingyun Liu (Gerrit)

unread,

Jul 28, 2026, 4:03:59 PM (12 days ago) Jul 28

to Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Jingyun Liu abandoned this change.

View Change

Abandoned

Jingyun Liu abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nathan Memmott (Gerrit)

unread,

Jul 28, 2026, 7:39:44 PM (12 days ago) Jul 28

to Jingyun Liu, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Jingyun Liu

Nathan Memmott voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Jingyun Liu

Submit Requirements:

Code-Coverage

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Jingyun Liu (Gerrit)

unread,

Jul 28, 2026, 7:40:03 PM (12 days ago) Jul 28

to Nathan Memmott, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Jingyun Liu voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 28, 2026, 7:43:55 PM (12 days ago) Jul 28

to Jingyun Liu, Nathan Memmott, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

Roll TFLite/LiteRT to Next Green Version

Version Changes:

XNNPACK: 09c4a9137f3a19b053dc45724a62f4f73ec7746a to 711f2b6e4c71fd17ca7b8001ebc3744c11aa8cf1
tflite: 7bedf2e94aff6ca62150d74fd40aa63cb73c6583 to cf01bcbd0605c40e8e4e060d23e6bfea7bc9a93e
litert: 1ae23176dd5d3a43e35961d8236d5adda7f8c0a1 to 9eedac0510c52e2014d54a2d1112d96c00d0adc2

Bug: 388311883

Change-Id: I028cde82bcc54c10be93d2f0bf248101fbef4076

Cq-Include-Trybots: luci.chrome.try:optimization_guide-linux;luci.chrome.try:optimization_guide-mac-arm64;luci.chrome.try:optimization_guide-mac-x64;luci.chrome.try:optimization_guide-win32;luci.chrome.try:optimization_guide-win64

Include-Ci-Only-Tests: chromium.android:android-pie-arm64-rel|android_browsertests

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8162317

Commit-Queue: Jingyun Liu <jin...@google.com>

Reviewed-by: Nathan Memmott <mem...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1669869}

Files:

M DEPS

M third_party/litert/README.chromium
M third_party/litert/src
M third_party/tflite/README.chromium
M third_party/tflite/src
M third_party/xnnpack/BUILD.gn
M third_party/xnnpack/README.chromium

M third_party/xnnpack/build_identifier.c
M third_party/xnnpack/src

Change size: L

Delta: 9 files changed, 638 insertions(+), 46 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Nathan Memmott

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Steven Holte (Gerrit)

unread,

Aug 4, 2026, 6:25:34 PM (5 days ago) Aug 4

to Steven Holte, Chromium LUCI CQ, chromium...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Steven Holte abandoned this change.

View Change

Abandoned

Steven Holte abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nathan Memmott (Gerrit)

unread,

Aug 7, 2026, 5:48:47 PM (2 days ago) Aug 7

to Lynne Jiang, chromium...@chromium.org, Chromium LUCI CQ, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Lynne Jiang

Nathan Memmott added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Nathan Memmott . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Lynne Jiang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lynne Jiang (Gerrit)

unread,

Aug 7, 2026, 6:03:00 PM (2 days ago) Aug 7

to Nathan Memmott, chromium...@chromium.org, Chromium LUCI CQ, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Attention needed from Nathan Memmott

Lynne Jiang voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Nathan Memmott

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Nathan Memmott (Gerrit)

unread,

Aug 7, 2026, 6:03:29 PM (2 days ago) Aug 7

to Lynne Jiang, chromium...@chromium.org, Chromium LUCI CQ, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

Nathan Memmott voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Nathan Memmott (Gerrit)

unread,

10:55 AM (9 hours ago) 10:55 AM

to Lynne Jiang, chromium...@chromium.org, Chromium LUCI CQ, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

satisfied_requirement

open

diffy

Nathan Memmott (Gerrit)

unread,

6:20 PM (2 hours ago) 6:20 PM

to Lynne Jiang, chromium...@chromium.org, Chromium LUCI CQ, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Roll TFLite/LiteRT to Next Green Version [chromium/src : main]

Mike Wittman (Gerrit)

Mike Wittman voted and added 1 comment

Votes added by Mike Wittman

1 comment

Related details

Devin Cabillo (Gerrit)

Devin Cabillo added 1 comment

Related details

Alan Ding (Gerrit)

Alan Ding voted Code-Review+1

Related details

Devin Cabillo (Gerrit)

Devin Cabillo voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Steven Holte (Gerrit)

Steven Holte voted Code-Review+1

Related details

Nathan Memmott (Gerrit)

Nathan Memmott voted Code-Review+1

Related details

Steven Holte (Gerrit)

Steven Holte voted Code-Review+1

Related details

Steven Holte (Gerrit)

Steven Holte voted Code-Review+1

Related details

Nathan Memmott (Gerrit)

Nathan Memmott voted Code-Review+1

Related details

Jaewon Lee (Gerrit)

Jaewon Lee voted Commit-Queue+2

Related details

Lynne Jiang (Gerrit)

Lynne Jiang added 1 comment

Related details

Jaewon Lee (Gerrit)

Jaewon Lee added 1 comment

Related details

Lynne Jiang (Gerrit)

Lynne Jiang added 1 comment

Related details

Lynne Jiang (Gerrit)

Lynne Jiang added 1 comment

Jaewon Lee (Gerrit)

Jaewon Lee voted Commit-Queue+1

Related details

Steven Holte (Gerrit)

Steven Holte voted Code-Review+1

Related details

Jaewon Lee (Gerrit)

Jaewon Lee added 1 comment

Related details

Jaewon Lee (Gerrit)

Jaewon Lee abandoned this change

Related details

Nathan Memmott (Gerrit)

Nathan Memmott voted Code-Review+1

Related details

Lynne Jiang (Gerrit)

Lynne Jiang added 1 comment

Related details

Jaewon Lee (Gerrit)

Jaewon Lee added 1 comment

Related details

Jaewon Lee (Gerrit)

Jaewon Lee abandoned this change

Related details

Lynne Jiang (Gerrit)

Lynne Jiang added 2 comments

Related details

Jaewon Lee (Gerrit)

Jaewon Lee added 1 comment

Related details

Jaewon Lee (Gerrit)

Jaewon Lee added 1 comment

Related details