[Tab Storage] Create feature param for authoritative read source [chromium/src : main]
0 views
Skip to first unread message
Calder Kitagawa (Gerrit)
Sep 24, 2025, 4:43:20 PM (yesterday) Sep 24
to Sky Malice, chromium...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org
Attention needed from Sky Malice
Calder Kitagawa voted and added 1 comment![]( "Open in Gerrit")
Votes added by Calder Kitagawa
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Sky Malice
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sky Malice (Gerrit)
Sep 24, 2025, 4:49:23 PM (yesterday) Sep 24
to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org
Attention needed from Calder Kitagawa
Sky Malice voted![]( "Open in Gerrit")
Attention is currently required from:
- Calder Kitagawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Calder Kitagawa (Gerrit)
11:21 AM (12 hours ago) 11:21 AM
to Sky Malice, Chromium LUCI CQ, chromium...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org
Attention needed from Sky Malice
Calder Kitagawa voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Sky Malice
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:03 PM (11 hours ago) 12:03 PM
to Calder Kitagawa, Sky Malice, chromium...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: chrome/android/java/src/org/chromium/chrome/browser/app/tabmodel/TabbedModeTabModelOrchestrator.java
Insertions: 5, Deletions: 0.
@@ -11,6 +11,7 @@
import androidx.annotation.VisibleForTesting;
+import org.chromium.base.Log;
import org.chromium.base.ThreadUtils;
import org.chromium.base.supplier.OneshotSupplier;
import org.chromium.build.annotations.Initializer;
@@ -50,6 +51,8 @@
*/
@NullMarked
public class TabbedModeTabModelOrchestrator extends TabModelOrchestrator {
+ private static final String TAG = "TMTMOrchestrator";
+
private final boolean mTabMergingEnabled;
private final ActivityLifecycleDispatcher mActivityLifecycleDispatcher;
private final CipherFactory mCipherFactory;
@@ -237,6 +240,8 @@
ChromeFeatureList.TAB_STORAGE_SQLITE_PROTOTYPE,
"authoritative_read_source",
false);
+ // Temporary variable usage to avoid unused variable warning.
+ Log.i(TAG, "mTabStateStoreIsAuthoritative: " + mTabStateStoreIsAuthoritative);
assert mProfileProviderSupplier.get() != null;
ProfileProvider profileProvider = mProfileProviderSupplier.get();
```
Change information
Commit message:
[Tab Storage] Create feature param for authoritative read source
Create a feature param to control the authoritative read source for
tab state on startup.
Fixed: 447187752
Change-Id: Ied5b0557413a4e6c8a7c24ea027ed071015c40fe
Reviewed-by: Sky Malice <sk...@chromium.org>
Auto-Submit: Calder Kitagawa <ckit...@chromium.org>
Commit-Queue: Calder Kitagawa <ckit...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1520652}
Files:
- M chrome/android/java/src/org/chromium/chrome/browser/app/tabmodel/TabbedModeTabModelOrchestrator.java
- M chrome/browser/about_flags.cc
Change size: S
Delta: 2 files changed, 23 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sky Malice
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages