Fix focus issue for 3 vertical button permission dialog [chromium/src : main]
0 views
Skip to first unread message
Lijin Shen (Gerrit)
Apr 20, 2026, 9:18:00 PM (10 days ago) Apr 20
to Theresa Wellington, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Theresa Wellington
Lijin Shen voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Theresa Wellington
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Theresa Wellington (Gerrit)
Apr 21, 2026, 12:16:05 PM (9 days ago) Apr 21
to Lijin Shen, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Lijin Shen
Theresa Wellington voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Lijin Shen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lijin Shen (Gerrit)
Apr 21, 2026, 1:23:31 PM (9 days ago) Apr 21
to Theresa Wellington, Chromium LUCI CQ, chromium...@chromium.org
Lijin Shen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 1:27:16 PM (9 days ago) Apr 21
to Lijin Shen, Theresa Wellington, chromium...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix focus issue for 3 vertical button permission dialog
The focus was not moved to dialog when dialog appears. This issue is
only reproducible for vertical button mode dialogs.
This was due to the removal of `announceForAccessibility` in
`TabModalPresenter.java` in a previous CL https://crrev.com/c/6050760,
and the fact that in vertical-button mode, the content is inside a
`ScrollView`, which TalkBack might not read automatically.
This CL: 1. Update `ModalDialogViewBinder.java` to set the content
description on `ModalDialogView` when `CONTENT_DESCRIPTION` is set. This
ensures TalkBack reads the message when the dialog gains focus. 2.
Remove dead method `getContentDescription` 3. Add an assertion in
`TabModalPresenter.java` to ensure that any Tab modal dialog has at
least a title or a content description set
Bug: 483460874
Change-Id: I598976b0ad7ec96005ae65eabd0e53b40052ee18
Reviewed-by: Theresa Wellington <twell...@chromium.org>
Commit-Queue: Lijin Shen <laz...@google.com>
Cr-Commit-Position: refs/heads/main@{#1618291}
Files:
- M chrome/android/java/src/org/chromium/chrome/browser/signin/WebSigninRedirectCoordinator.java
- M components/browser_ui/modaldialog/android/java/src/org/chromium/components/browser_ui/modaldialog/ModalDialogViewBinder.java
- M components/browser_ui/modaldialog/android/java/src/org/chromium/components/browser_ui/modaldialog/TabModalPresenter.java
- M ui/android/java/src/org/chromium/ui/modaldialog/ModalDialogManager.java
Change size: S
Delta: 4 files changed, 8 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Theresa Wellington
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages