Aryan Krishnan (Gerrit)

unread,

Jul 7, 2026, 11:01:43 AM (4 days ago) Jul 7

to Lei Zhang, Tom Sepez, Andy Phan, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, pdf-r...@chromium.org

Attention needed from Andy Phan, Lei Zhang and Tom Sepez

Aryan Krishnan added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Aryan Krishnan . resolved

Hey guys, added the CL to link the feature flag up to pdfium_engine.cc to enable the same library initialization to set up brotli being enabled. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan
Lei Zhang
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Jul 7, 2026, 2:03:55 PM (4 days ago) Jul 7

to Aryan Krishnan, Lei Zhang, Tom Sepez, Andy Phan, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, pdf-r...@chromium.org

Attention needed from Andy Phan, Aryan Krishnan and Tom Sepez

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Commit-Queue

+1

1 comment

File pdf/pdfium/pdfium_engine.cc

Line 787, Patchset 7 (Latest): config.m_FontLibraryType = FPDF_FONTBACKENDTYPE_FREETYPE;

Lei Zhang . unresolved

Move these above line 775. I think the pattern here is non-conditional (well, sort of) assignments first.

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan
Aryan Krishnan
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Aryan Krishnan (Gerrit)

unread,

Jul 7, 2026, 2:10:18 PM (4 days ago) Jul 7

to Chromium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, pdf-r...@chromium.org

Attention needed from Andy Phan, Lei Zhang and Tom Sepez

Aryan Krishnan added 1 comment

File pdf/pdfium/pdfium_engine.cc

Line 787, Patchset 7: config.m_FontLibraryType = FPDF_FONTBACKENDTYPE_FREETYPE;

Lei Zhang . resolved

Move these above line 775. I think the pattern here is non-conditional (well, sort of) assignments first.

Aryan Krishnan

Done

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan
Lei Zhang
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Andy Phan (Gerrit)

unread,

Jul 9, 2026, 6:39:45 PM (2 days ago) Jul 9

to Aryan Krishnan, Chromium LUCI CQ, Lei Zhang, Tom Sepez, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, pdf-r...@chromium.org

Attention needed from Aryan Krishnan, Lei Zhang and Tom Sepez

Andy Phan added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Andy Phan . resolved

red bots.

Open in Gerrit

Related details

Attention is currently required from:

Aryan Krishnan
Lei Zhang
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Aryan Krishnan (Gerrit)

unread,

Jul 9, 2026, 11:51:04 PM (2 days ago) Jul 9

to Chromium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, pdf-r...@chromium.org

Attention needed from Andy Phan, Lei Zhang and Tom Sepez

Aryan Krishnan added 1 comment

Patchset-level comments

File-level comment, Patchset 11:

Andy Phan . resolved

red bots.

Aryan Krishnan

Should be resolved now.

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan
Lei Zhang
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Aryan Krishnan (Gerrit)

unread,

Jul 10, 2026, 2:40:36 PM (24 hours ago) Jul 10

to Chromium LUCI CQ, Lei Zhang, Tom Sepez, Andy Phan, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, pdf-r...@chromium.org

Attention needed from Andy Phan, Lei Zhang and Tom Sepez

Aryan Krishnan added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Aryan Krishnan . resolved

Can someone restart the MacOS bot, seems like one of the tests is flaky (crbug.com/500070329).

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan
Lei Zhang
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Jul 10, 2026, 2:57:02 PM (23 hours ago) Jul 10

to Aryan Krishnan, Lei Zhang, Chromium LUCI CQ, Tom Sepez, Andy Phan, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, pdf-r...@chromium.org

Attention needed from Andy Phan, Aryan Krishnan and Tom Sepez

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Code-Review	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Aryan Krishnan . resolved

Can someone restart the MacOS bot, seems like one of the tests is flaky (crbug.com/500070329).

Lei Zhang

It went green.

Open in Gerrit

Related details

Attention is currently required from:

Andy Phan
Aryan Krishnan
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Andy Phan (Gerrit)

unread,

Jul 10, 2026, 7:10:37 PM (19 hours ago) Jul 10

to Aryan Krishnan, Lei Zhang, Chromium LUCI CQ, Tom Sepez, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, pdf-r...@chromium.org

Attention needed from Aryan Krishnan, Lei Zhang and Tom Sepez

Andy Phan voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Aryan Krishnan
Lei Zhang
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Jul 10, 2026, 7:35:51 PM (19 hours ago) Jul 10

to Aryan Krishnan, Andy Phan, Lei Zhang, Chromium LUCI CQ, Tom Sepez, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, pdf-r...@chromium.org

Attention needed from Aryan Krishnan and Tom Sepez

Lei Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Aryan Krishnan
Tom Sepez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jul 10, 2026, 9:05:30 PM (17 hours ago) Jul 10

to Aryan Krishnan, Andy Phan, Lei Zhang, Tom Sepez, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, pdf-r...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Update //pdf to use the Brotli feature flag

This CL enables BrotliDecode based on the state of the pdf-enable-brotli
feature flag by editing the library configuration options in
pdfium_engine.cc and pdfium_test_base.cc.

Specifically, this CL updates the configuration version to 6 and adds
additional configuration to enable brotli based on the state of the
base::Feature.

In the process, this CL also sets the default build override to true due
to the presence of the flag as a runtime check for whether Brotli is
enabled.

Bug: 475855993

Change-Id: Ib90fe6032fc8d872d44f8deab9bc6dc5168402d8

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8055324

Reviewed-by: Lei Zhang <the...@chromium.org>

Commit-Queue: Lei Zhang <the...@chromium.org>

Reviewed-by: Andy Phan <andy...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1660629}

Files:

M build_overrides/pdfium.gni
M pdf/pdfium/pdfium_engine.cc
M pdf/pdfium/pdfium_test_base.cc

Change size: S

Delta: 3 files changed, 11 insertions(+), 3 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Lei Zhang, +1 by Andy Phan

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Aryan Krishnan (Gerrit)

unread,

11:46 AM (3 hours ago) 11:46 AM

to Chromium LUCI CQ, Andy Phan, Lei Zhang, Tom Sepez, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, pdf-r...@chromium.org

Aryan Krishnan added 1 comment

Patchset-level comments

File-level comment, Patchset 16 (Latest):

Aryan Krishnan . unresolved

Tested on release build just as latest canary came out and it seems like feature isn't working yet. If the override is set, isn't chromium going to be built with BrotliDecode support builtin anyway, or do i need to get a Chromium build from appspot instead.

In the mean time am trying to find the reason for the issue. Let me know if there is anything I am missing here Thanks!

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Update //pdf to use the Brotli feature flag [chromium/src : main]

Aryan Krishnan (Gerrit)

Aryan Krishnan added 1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

1 comment

Related details

Aryan Krishnan (Gerrit)

Aryan Krishnan added 1 comment

Related details

Andy Phan (Gerrit)

Andy Phan added 1 comment

Related details

Aryan Krishnan (Gerrit)

Aryan Krishnan added 1 comment

Related details

Aryan Krishnan (Gerrit)

Aryan Krishnan added 1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

1 comment

Related details

Andy Phan (Gerrit)

Andy Phan voted Code-Review+1

Related details

Lei Zhang (Gerrit)

Lei Zhang voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Aryan Krishnan (Gerrit)

Aryan Krishnan added 1 comment

Related details