[blink] Remove size from ColorBuffer in favor of shared image params [chromium/src : main]
0 views
Skip to first unread message
Saifuddin Hitawala (Gerrit)
Jul 7, 2026, 3:23:27 PM (21 hours ago) Jul 7
to Alexander Cooper, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Alexander Cooper
Saifuddin Hitawala voted and added 1 comment![]( "Open in Gerrit")
Votes added by Saifuddin Hitawala
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Alexander Cooper
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Cooper (Gerrit)
Jul 7, 2026, 4:17:05 PM (20 hours ago) Jul 7
to Saifuddin Hitawala, android-bu...@system.gserviceaccount.com, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, feature-me...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Saifuddin Hitawala
Alexander Cooper voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Saifuddin Hitawala (Gerrit)
9:45 AM (3 hours ago) 9:45 AM
to Alexander Cooper, android-bu...@system.gserviceaccount.com, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, feature-me...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Saifuddin Hitawala voted and added 1 comment![]( "Open in Gerrit")
Votes added by Saifuddin Hitawala
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:50 AM (2 hours ago) 9:50 AM
to Saifuddin Hitawala, Alexander Cooper, android-bu...@system.gserviceaccount.com, Vasiliy Telezhnikov, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, feature-me...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, feature-v...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[blink] Remove size from ColorBuffer in favor of shared image params
Remove size from ColorBuffer as it is the same as that within
shared image. This remove it and updates callsites to use data from
shared image within ColorBuffer.
Bug: 494245873
Change-Id: Ic3f873ae1cb486fcaf7ea723d81f6a0ff5970390
Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>
Reviewed-by: Alexander Cooper <alco...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1658704}
Files:
- M third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc
- M third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.h
Change size: S
Delta: 2 files changed, 4 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Cooper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages