[bedrock] Eliminate BrowserList::get() from ChromeOS kiosk code [chromium/src : main]
0 views
Skip to first unread message
Tom Lukaszewicz (Gerrit)
Sep 4, 2025, 8:52:21 PM (2 days ago) Sep 4
to Hidehiko Abe, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-kio...@google.com, oshima...@chromium.org
Attention needed from Hidehiko Abe
Tom Lukaszewicz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Hidehiko Abe
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hidehiko Abe (Gerrit)
Sep 4, 2025, 8:54:42 PM (2 days ago) Sep 4
to Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-kio...@google.com, oshima...@chromium.org
Attention needed from Tom Lukaszewicz
Hidehiko Abe voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tom Lukaszewicz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Sep 4, 2025, 8:56:02 PM (2 days ago) Sep 4
to Hidehiko Abe, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromeos-kio...@google.com, oshima...@chromium.org
Tom Lukaszewicz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 4, 2025, 9:13:28 PM (2 days ago) Sep 4
to Tom Lukaszewicz, Hidehiko Abe, AyeAye, chromium...@chromium.org, chromeos-kio...@google.com, oshima...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[bedrock] Eliminate BrowserList::get() from ChromeOS kiosk code
This CL removes instances of the BrowserList::get() API from kiosk
code. BrowserList is now deprecated and clients are expected to
shift to using APIs in browser_window_interface_iterator.h.
In both cases clients expected only a single Browser instance in the
environment, so the
GetLastActiveBrowserWindowInterfaceWithAnyProfile() API was used
instead.
Bug: 431672609
Change-Id: I69be728511ba7216f634430f31473c48000237b1
Commit-Queue: Tom Lukaszewicz <tl...@chromium.org>
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1511259}
Files:
- M chrome/browser/chromeos/app_mode/DEPS
- M chrome/browser/chromeos/app_mode/kiosk_app_level_logs_browsertest.cc
- M chrome/browser/chromeos/app_mode/kiosk_browser_window_handler.cc
Change size: S
Delta: 3 files changed, 13 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages