Make "All rights reserved" Optional in the License [chromium/tools/depot_tools : main]
Robert Liao (Gerrit)
Attention is currently required from: Bruce Dawson.
Patch set 1:Auto-Submit +1Commit-Queue +1
1 comment:
Patchset:
brucedawson: Please review this change. Thanks!
To view, visit change 3811744. To unsubscribe, or for help writing mail filters, visit settings.
Mike Frysinger (Gerrit)
Attention is currently required from: Bruce Dawson, Robert Liao.
1 comment:
File presubmit_canned_checks.py:
Patch Set #1, Line 656:
# removed from all files.it's not clear whether it will be removed. the check we've deployed in CrOS is ban it from files using a copyright year of 2023+.
To view, visit change 3811744. To unsubscribe, or for help writing mail filters, visit settings.
Bruce Dawson (Gerrit)
Attention is currently required from: Mike Frysinger, Robert Liao.
2 comments:
Patchset:
Sorry about the delay. See comment
File presubmit_canned_checks.py:
Patch Set #1, Line 656:
# removed from all files.
it's not clear whether it will be removed. […]
Should we do the same here and disallow "All rights reserved" if the copyright year is 2023 or higher? Otherwise I know that copy/paste means that it will continue to show up in some new files.
To view, visit change 3811744. To unsubscribe, or for help writing mail filters, visit settings.
Bruce Dawson (Gerrit)
Attention is currently required from: Mike Frysinger, Robert Liao.
Patch set 1:Code-Review +1Commit-Queue +2
1 comment:
File presubmit_canned_checks.py:
Patch Set #1, Line 656:
# removed from all files.
Should we do the same here and disallow "All rights reserved" if the copyright year is 2023 or highe […]
That can be fixed later - this needs to be landed now to avoid conflicts with the already-made changes to boilerplate.py (https://crrev.com/c/3808222).
To view, visit change 3811744. To unsubscribe, or for help writing mail filters, visit settings.
LUCI CQ (Gerrit)
LUCI CQ submitted this change.
Make "All rights reserved" Optional in the License
This update is per http://crrev.com/1031130 where OSS licensing
requested removal of "All rights reserved" from new files.
Change-Id: I52a9deab99539ea90403798606c7bbeb261df994
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3811744
Commit-Queue: Bruce Dawson <bruce...@chromium.org>
Auto-Submit: Robert Liao <rob...@chromium.org>
Reviewed-by: Bruce Dawson <bruce...@chromium.org>
---
M presubmit_canned_checks.py
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index 38a2682..2c96eb1 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -652,9 +652,11 @@
key_line = ('Use of this source code is governed by a BSD-style license '
'that can be')
# The (c) is deprecated, but tolerate it until it's removed from all files.
+ # "All rights reserved" is also deprecated, but tolerate it until it's
+ # removed from all files.
license_re = (
- r'.*? Copyright (\(c\) )?%(year)s The %(project)s Authors\. '
- r'All rights reserved\.\r?\n'
+ r'.*? Copyright (\(c\) )?%(year)s The %(project)s Authors\.'
+ r'( All rights reserved\.)?\r?\n'
r'.*? %(key_line)s\r?\n'
r'.*? found in the LICENSE file\.(?: \*/)?\r?\n'
) % {
To view, visit change 3811744. To unsubscribe, or for help writing mail filters, visit settings.