hats: Implement client side config for the slow and laggy survey [chromium/src : main]
0 views
Skip to first unread message
Jun Ishiguro (Gerrit)
Jun 16, 2026, 7:04:19 AM (11 days ago) Jun 16
to Kyle Horimoto, Hidehiko Abe, Chromium Metrics Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, oshima...@chromium.org, asvitkine...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Kyle Horimoto
Jun Ishiguro added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Jun Ishiguro . resolved
Hi Kyle, please review the hats config change. Thanks!
Related details
Attention is currently required from:
- Kyle Horimoto
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kyle Horimoto (Gerrit)
Jun 17, 2026, 3:48:33 PM (9 days ago) Jun 17
to Jun Ishiguro, Kyle Horimoto, Hidehiko Abe, Chromium Metrics Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, oshima...@chromium.org, asvitkine...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Jun Ishiguro
Kyle Horimoto voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jun Ishiguro
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jun Ishiguro (Gerrit)
Jun 17, 2026, 11:48:30 PM (9 days ago) Jun 17
to Mitsuru Oshima, Kyle Horimoto, Hidehiko Abe, Chromium Metrics Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, oshima...@chromium.org, asvitkine...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Mitsuru Oshima
Jun Ishiguro added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jun Ishiguro . unresolved
@osh...@chromium.org Please review `ash/constants/ash_pref_names.h`. Thanks!
Related details
Attention is currently required from:
- Mitsuru Oshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Jun 18, 2026, 12:03:51 AM (9 days ago) Jun 18
to Jun Ishiguro, Kyle Horimoto, Hidehiko Abe, Chromium Metrics Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, oshima...@chromium.org, asvitkine...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Attention needed from Jun Ishiguro
Mitsuru Oshima voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jun Ishiguro
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jun Ishiguro (Gerrit)
Jun 18, 2026, 12:21:41 AM (9 days ago) Jun 18
to Mitsuru Oshima, Kyle Horimoto, Hidehiko Abe, Chromium Metrics Reviews, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, oshima...@chromium.org, asvitkine...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Jun Ishiguro voted and added 2 comments![]( "Open in Gerrit")
Votes added by Jun Ishiguro
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Jun Ishiguro . resolved
Thank you for the review!
Jun Ishiguro . resolved
@osh...@chromium.org Please review `ash/constants/ash_pref_names.h`. Thanks!
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 18, 2026, 1:01:38 AM (9 days ago) Jun 18
to Jun Ishiguro, Mitsuru Oshima, Kyle Horimoto, Hidehiko Abe, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, oshima...@chromium.org, asvitkine...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
hats: Implement client side config for the slow and laggy survey
Bug: b:512307777
Change-Id: I60324f7785c019beac220a4feb7e7c4f4ca3ed0d
Reviewed-by: Kyle Horimoto <khor...@chromium.org>
Commit-Queue: Jun Ishiguro <ju...@google.com>
Reviewed-by: Mitsuru Oshima <osh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1648801}
Files:
- M ash/constants/ash_features.cc
- M ash/constants/ash_features.h
- M ash/constants/ash_pref_names.h
- M chrome/browser/ash/hats/hats_config.cc
- M chrome/browser/ash/hats/hats_config.h
- M chrome/browser/ash/login/session/user_session_manager.cc
- M tools/metrics/histograms/metadata/chromeos/histograms.xml
Change size: S
Delta: 7 files changed, 32 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mitsuru Oshima, +1 by Kyle Horimoto
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages