Return the anchor boundary for line queries at a node's ignored edge [chromium/src : main]

0 views
Skip to first unread message

Joanmarie Diggs (Gerrit)

unread,
Jul 20, 2026, 7:55:28 AM (yesterday) Jul 20
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Joanmarie Diggs

Message from Joanmarie Diggs

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Joanmarie Diggs
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idb732ce7ff7738652410f0f441b0c588f58da5ff
Gerrit-Change-Number: 8117629
Gerrit-PatchSet: 1
Gerrit-Owner: Joanmarie Diggs <jdi...@igalia.com>
Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Joanmarie Diggs <jdi...@igalia.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 11:55:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Joanmarie Diggs (Gerrit)

unread,
Jul 20, 2026, 7:58:57 AM (yesterday) Jul 20
to Jacques Newman, Benjamin Beaudry, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Benjamin Beaudry and Jacques Newman

Joanmarie Diggs added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Joanmarie Diggs . resolved

Hi Jacques and Benjamin. Since it looks like you wrapped your head around this in crrev.com/c/6500379, could you please take a look at my proposed tweak? Thanks in advance!

Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Beaudry
  • Jacques Newman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idb732ce7ff7738652410f0f441b0c588f58da5ff
Gerrit-Change-Number: 8117629
Gerrit-PatchSet: 1
Gerrit-Owner: Joanmarie Diggs <jdi...@igalia.com>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Attention: Jacques Newman <jane...@microsoft.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 11:58:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Benjamin Beaudry (Gerrit)

unread,
Jul 20, 2026, 10:38:47 AM (23 hours ago) Jul 20
to Joanmarie Diggs, Jacques Newman, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Jacques Newman and Joanmarie Diggs

Benjamin Beaudry voted and added 1 comment

Votes added by Benjamin Beaudry

Code-Review+1

1 comment

Patchset-level comments
Benjamin Beaudry . resolved

This makes sense to me, but can we add one or more unit tests that run on all platforms please? Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Jacques Newman
  • Joanmarie Diggs
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idb732ce7ff7738652410f0f441b0c588f58da5ff
Gerrit-Change-Number: 8117629
Gerrit-PatchSet: 1
Gerrit-Owner: Joanmarie Diggs <jdi...@igalia.com>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Jacques Newman <jane...@microsoft.com>
Gerrit-Attention: Joanmarie Diggs <jdi...@igalia.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 14:38:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jacques Newman (Gerrit)

unread,
Jul 20, 2026, 11:56:17 AM (22 hours ago) Jul 20
to Joanmarie Diggs, Benjamin Beaudry, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Joanmarie Diggs

Jacques Newman voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joanmarie Diggs
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idb732ce7ff7738652410f0f441b0c588f58da5ff
Gerrit-Change-Number: 8117629
Gerrit-PatchSet: 1
Gerrit-Owner: Joanmarie Diggs <jdi...@igalia.com>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Joanmarie Diggs <jdi...@igalia.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 15:56:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jacques Newman (Gerrit)

unread,
Jul 20, 2026, 11:57:03 AM (22 hours ago) Jul 20
to Joanmarie Diggs, Benjamin Beaudry, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Joanmarie Diggs

Jacques Newman added 1 comment

Patchset-level comments
Jacques Newman . unresolved

lgtm % ask for additional tests.

Open in Gerrit

Related details

Attention is currently required from:
  • Joanmarie Diggs
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idb732ce7ff7738652410f0f441b0c588f58da5ff
    Gerrit-Change-Number: 8117629
    Gerrit-PatchSet: 1
    Gerrit-Owner: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
    Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
    Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Attention: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-Comment-Date: Mon, 20 Jul 2026 15:56:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joanmarie Diggs (Gerrit)

    unread,
    Jul 20, 2026, 12:41:24 PM (21 hours ago) Jul 20
    to Jacques Newman, Benjamin Beaudry, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Joanmarie Diggs

    Joanmarie Diggs added 1 comment

    Patchset-level comments
    File-level comment, Patchset 1:
    Jacques Newman . resolved

    lgtm % ask for additional tests.

    Joanmarie Diggs

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Joanmarie Diggs
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idb732ce7ff7738652410f0f441b0c588f58da5ff
    Gerrit-Change-Number: 8117629
    Gerrit-PatchSet: 2
    Gerrit-Owner: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
    Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
    Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Attention: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-Comment-Date: Mon, 20 Jul 2026 16:41:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Jacques Newman <jane...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Benjamin Beaudry (Gerrit)

    unread,
    Jul 20, 2026, 1:12:21 PM (20 hours ago) Jul 20
    to Joanmarie Diggs, Jacques Newman, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Joanmarie Diggs

    Benjamin Beaudry voted and added 1 comment

    Votes added by Benjamin Beaudry

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Benjamin Beaudry . resolved

    lgtm, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Joanmarie Diggs
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idb732ce7ff7738652410f0f441b0c588f58da5ff
    Gerrit-Change-Number: 8117629
    Gerrit-PatchSet: 2
    Gerrit-Owner: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
    Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
    Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Attention: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-Comment-Date: Mon, 20 Jul 2026 17:12:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Joanmarie Diggs (Gerrit)

    unread,
    Jul 20, 2026, 3:29:51 PM (18 hours ago) Jul 20
    to Benjamin Beaudry, Jacques Newman, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

    Joanmarie Diggs voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idb732ce7ff7738652410f0f441b0c588f58da5ff
    Gerrit-Change-Number: 8117629
    Gerrit-PatchSet: 2
    Gerrit-Owner: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
    Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
    Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-Comment-Date: Mon, 20 Jul 2026 19:29:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 20, 2026, 3:46:14 PM (18 hours ago) Jul 20
    to Joanmarie Diggs, Benjamin Beaudry, Jacques Newman, android-bu...@system.gserviceaccount.com, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Return the anchor boundary for line queries at a node's ignored edge

    TryAsUnignoredPositionPreservingAnchor() returned a null position when
    the end of an unignored anchor had an ignored leaf equivalent. That can
    happen when an anchor's text is immediately followed by ignored content,
    e.g. a display:block <code> element whose last child is an aria-hidden
    "line-numbers" gutter. Under kStopAtAnchorBoundary this made text APIs
    report no line for the anchor's last line, e.g. ATK's
    get_string_at_offset(LINE) returned (-1, -1) for every offset.

    The anchor's own end is a valid boundary rooted on the same node even
    when its leaf equivalent is ignored, so return it instead of null.

    AX-Relnotes: Fix bug that caused Orca to say "blank" and/or get stuck/
    loop in some code elements due to invalid offsets.
    Bug: 536662914
    Change-Id: Idb732ce7ff7738652410f0f441b0c588f58da5ff
    Reviewed-by: Benjamin Beaudry <benjamin...@microsoft.com>
    Commit-Queue: Joanmarie Diggs <jdi...@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#1664860}
    Files:
    • M content/browser/accessibility/accessibility_auralinux_browsertest.cc
    • M ui/accessibility/ax_node_position_unittest.cc
    • M ui/accessibility/ax_position.h
    Change size: M
    Delta: 3 files changed, 158 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Benjamin Beaudry
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idb732ce7ff7738652410f0f441b0c588f58da5ff
    Gerrit-Change-Number: 8117629
    Gerrit-PatchSet: 3
    Gerrit-Owner: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
    Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages