[Vertical Tabs] Adding Basic Tab Interactions [chromium/src : main]

0 views
Skip to first unread message

Kunal Daftari (Gerrit)

unread,
Dec 4, 2025, 2:08:56 PM (2 days ago) Dec 4
to David Pennington, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, shimazu...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, blink-revie...@chromium.org, horo+...@chromium.org, kinuko...@chromium.org

New activity on the change

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I24865f9a856df9c0593b8ae0487e6e9a90195a74
Gerrit-Change-Number: 7212920
Gerrit-PatchSet: 15
Gerrit-Owner: Kunal Daftari <kunald...@google.com>
Gerrit-Reviewer: Kunal Daftari <kunald...@google.com>
Gerrit-CC: David Pennington <dpen...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Dec 2025 19:08:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kunal Daftari (Gerrit)

unread,
Dec 4, 2025, 2:09:03 PM (2 days ago) Dec 4
to blink-revie...@chromium.org, David Pennington, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, shimazu...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, horo+...@chromium.org, kinuko...@chromium.org

Kunal Daftari removed blink-revie...@chromium.org from this change

Deleted Reviewers:
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
satisfied_requirement
unsatisfied_requirement
open
diffy

Kunal Daftari (Gerrit)

unread,
Dec 4, 2025, 2:09:14 PM (2 days ago) Dec 4
to blink-...@chromium.org, David Pennington, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, shimazu...@chromium.org, blink-work...@chromium.org, horo+...@chromium.org, kinuko...@chromium.org

Kunal Daftari removed blink-...@chromium.org from this change

Deleted Reviewers:
satisfied_requirement
unsatisfied_requirement
open
diffy

Eshwar Stalin (Gerrit)

unread,
Dec 5, 2025, 10:22:41 PM (5 hours ago) Dec 5
to Kunal Daftari, David Pennington, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, shimazu...@chromium.org, blink-work...@chromium.org, horo+...@chromium.org, kinuko...@chromium.org
Attention needed from David Pennington and Kunal Daftari

Eshwar Stalin added 1 comment

File chrome/browser/ui/views/tabs/vertical/vertical_tab_strip_controller.h
Line 41, Patchset 18 (Latest): bool OnKeyPressed(TabCollectionNode* collection_node,
const ui::KeyEvent& event);
bool OnKeyReleased(TabCollectionNode* collection_node,
const ui::KeyEvent& event);
bool OnMousePressed(TabCollectionNode* collection_node,
const ui::MouseEvent& event);
void OnMouseReleased(TabCollectionNode* collection_node,
const ui::MouseEvent& event);
Eshwar Stalin . unresolved

We need to rework the design a bit to separate out view and controller logic. The controller should provide interface to the view for model mutations. It shouldn't be directly processing keyboard events. That logic for that should be in the view itself. View should call into the model to for control actions (e.g SelectTab, ToggleSelection, CloseTab, ToggleSelection, ExtendSelectionTo/AddSelectionFromAnchorTo etc). Any kind of state you want to maintain for key down etc should also be in the view.

Open in Gerrit

Related details

Attention is currently required from:
  • David Pennington
  • Kunal Daftari
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I24865f9a856df9c0593b8ae0487e6e9a90195a74
    Gerrit-Change-Number: 7212920
    Gerrit-PatchSet: 18
    Gerrit-Owner: Kunal Daftari <kunald...@google.com>
    Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
    Gerrit-Reviewer: Kunal Daftari <kunald...@google.com>
    Gerrit-CC: Eshwar Stalin <est...@chromium.org>
    Gerrit-Attention: David Pennington <dpen...@chromium.org>
    Gerrit-Attention: Kunal Daftari <kunald...@google.com>
    Gerrit-Comment-Date: Sat, 06 Dec 2025 03:22:28 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages