[iOS] Add feature detection methods to PageActionMenuMutator. [chromium/src : main]
0 views
Skip to first unread message
Adam Arcaro (Gerrit)
Sep 24, 2025, 3:30:53 PM (2 days ago) Sep 24
to Ibrahim Kanouche, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ibrahim Kanouche
Adam Arcaro added 1 comment![]( "Open in Gerrit")
File ios/chrome/browser/intelligence/page_action_menu/ui/page_action_menu_mutator.h
Line 47, Patchset 2 (Latest):
- (BOOL)isMicrophonePermissionGranted;Adam Arcaro . unresolved
Do these represent whether the feature row should be shown at all?
Can we leverage the feature enum to simplify these to a single function? Something like `isFeatureAvailable:(FeatureEnum)feature`?
Related details
Attention is currently required from:
- Ibrahim Kanouche
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ibrahim Kanouche (Gerrit)
Sep 25, 2025, 9:44:19 AM (17 hours ago) Sep 25
to Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Adam Arcaro
Ibrahim Kanouche voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ibrahim Kanouche
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
File ios/chrome/browser/intelligence/page_action_menu/ui/page_action_menu_mutator.h
Do these represent whether the feature row should be shown at all?
Can we leverage the feature enum to simplify these to a single function? Something like `isFeatureAvailable:(FeatureEnum)feature`?
Ibrahim Kanouche
I updated this to only keep The availability methods will determine row visibility, while the others determine row content/state. But following our previous CL, we are just keeping the availability methods here.
Switched to using isFeatureAvailable to simplify the availability methods.
Related details
Attention is currently required from:
- Adam Arcaro
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Arcaro (Gerrit)
Sep 25, 2025, 10:28:41 AM (17 hours ago) Sep 25
to Ibrahim Kanouche, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ibrahim Kanouche
Adam Arcaro voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Arcaro
| Code-Review | +1 |
1 comment
File ios/chrome/browser/intelligence/page_action_menu/ui/page_action_menu_mutator.h
Line 26, Patchset 6 (Latest):
- (BOOL)isReaderModeActive;Adam Arcaro . unresolved
Can you add a TODO to eventually migrate Reader Mode to the feature type system? It can probably be done post-MVP, unless you see an easy way to make it fit
Related details
Attention is currently required from:
- Ibrahim Kanouche
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ibrahim Kanouche (Gerrit)
Sep 25, 2025, 12:25:22 PM (15 hours ago) Sep 25
to Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Ibrahim Kanouche voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ibrahim Kanouche
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
File ios/chrome/browser/intelligence/page_action_menu/ui/page_action_menu_mutator.h
Can you add a TODO to eventually migrate Reader Mode to the feature type system? It can probably be done post-MVP, unless you see an easy way to make it fit
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ibrahim Kanouche (Gerrit)
Sep 25, 2025, 12:25:28 PM (15 hours ago) Sep 25
to Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Ibrahim Kanouche voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 25, 2025, 1:20:09 PM (14 hours ago) Sep 25
to Ibrahim Kanouche, Adam Arcaro, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ios/chrome/browser/intelligence/page_action_menu/coordinator/page_action_menu_mediator.mm
Insertions: 1, Deletions: 0.
@@ -88,6 +88,7 @@
}
- (BOOL)isReaderModeAvailable {
+ // TODO(crbug.com/447371545): Migrate Reader Mode to the feature type system.
if (!_readerModeTabHelper) {
return NO;
}
```
Change information
Commit message:
[iOS] Add feature detection methods to PageActionMenuMutator.
Extends PageActionMenuMutator protocol with methods for detecting feature
availability (translate, popup blocker, permissions) and querying feature
state.
Bug: 447143165
Change-Id: I0eec1031b1932e5a44d9184dfba5ef5b61755f27
Commit-Queue: Ibrahim Kanouche <kano...@google.com>
Reviewed-by: Adam Arcaro <ada...@google.com>
Auto-Submit: Ibrahim Kanouche <kano...@google.com>
Cr-Commit-Position: refs/heads/main@{#1520706}
Files:
- M ios/chrome/browser/intelligence/page_action_menu/coordinator/page_action_menu_mediator.mm
- M ios/chrome/browser/intelligence/page_action_menu/ui/page_action_menu_mutator.h
Change size: M
Delta: 2 files changed, 51 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Adam Arcaro
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages