url: Fix UNSAFE_TODOs in url_canon_ip.cc [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
7:06 PM (4 hours ago) 7:06 PM
to Kent Tamura, Hayato Ito, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Hayato Ito

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kent Tamura . resolved

hayato@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Hayato Ito
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I69e17187a1f74d2c6c4be0b896a90a52632c543f
Gerrit-Change-Number: 7453432
Gerrit-PatchSet: 2
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Attention: Hayato Ito <hay...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Jan 2026 00:05:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Hayato Ito (Gerrit)

unread,
7:36 PM (4 hours ago) 7:36 PM
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Kent Tamura

Hayato Ito voted and added 1 comment

Votes added by Hayato Ito

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Hayato Ito . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I69e17187a1f74d2c6c4be0b896a90a52632c543f
Gerrit-Change-Number: 7453432
Gerrit-PatchSet: 2
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Jan 2026 00:36:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
7:39 PM (4 hours ago) 7:39 PM
to Kent Tamura, Hayato Ito, chromium...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
url: Fix UNSAFE_TODOs in url_canon_ip.cc
Bug: 350788890
Change-Id: I69e17187a1f74d2c6c4be0b896a90a52632c543f
Commit-Queue: Hayato Ito <hay...@chromium.org>
Reviewed-by: Hayato Ito <hay...@chromium.org>
Auto-Submit: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1569434}
Files:
  • M url/url_canon_ip.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Hayato Ito
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I69e17187a1f74d2c6c4be0b896a90a52632c543f
Gerrit-Change-Number: 7453432
Gerrit-PatchSet: 3
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Hayato Ito <hay...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages