[Blink] Add check for context lost to CRPSI::RasterRecord() [chromium/src : main]
0 views
Skip to first unread message
Colin Blundell (Gerrit)
10:55 AM (7 hours ago) 10:55 AM
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Vasiliy Telezhnikov
Colin Blundell voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
11:03 AM (7 hours ago) 11:03 AM
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:02 PM (6 hours ago) 12:02 PM
to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Blink] Add check for context lost to CRPSI::RasterRecord()
It's not clear whether this is causing the issue in the linked bug, but
in any case it is an issue as the call to GetSyncToken() will crash if
the RasterInterface is not present.
This CL also defensively adds a check in CanvasResource::GetSyncToken(),
which we plan to remove later.
Bug: 447237526
Change-Id: I350da623003804191657327e68cc4cdeda85c553
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Auto-Submit: Colin Blundell <blun...@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1520651}
Files:
- M third_party/blink/renderer/platform/graphics/canvas_resource.cc
- M third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
Change size: S
Delta: 2 files changed, 12 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages